From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Tue, 25 Jul 2023 10:47:53 -0400 Message-ID: References: <047EC69F-EAC7-458F-A288-13DDC77DE187@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24529"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Aaron Jensen , Kai Ma , 63187@debbugs.gnu.org, Eli Zaretskii , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 25 16:49:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOJLm-0006E0-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jul 2023 16:49:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOJLZ-0004GG-LQ; Tue, 25 Jul 2023 10:49:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOJLU-000497-PA for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 10:49:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOJLT-0007Ev-Dh for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 10:49:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOJLS-0008Vo-F7 for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2023 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.169029649332538 (code B ref 63187); Tue, 25 Jul 2023 14:49:02 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 25 Jul 2023 14:48:13 +0000 Original-Received: from localhost ([127.0.0.1]:46709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOJKe-0008Se-Dm for submit@debbugs.gnu.org; Tue, 25 Jul 2023 10:48:12 -0400 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:51444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOJKc-0008Ri-JQ for 63187@debbugs.gnu.org; Tue, 25 Jul 2023 10:48:11 -0400 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51e429e1eabso8299690a12.2 for <63187@debbugs.gnu.org>; Tue, 25 Jul 2023 07:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690296485; x=1690901285; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eeDnhW8G235QmN4gi+lXNv+PCGenviFDXl3lddVtThE=; b=X88eRXaQ8nOUnyAQk0SlZKB7s80hQkY0H4tC/7HC3cPncXPK7WsDz83xsdgKN/DEe1 8FLev3OM+iyeoFsZfAd2M2sE4j+x5weGa7IeYcsXgVfXKhL/fIwx0f0sbnTCUdwV0TP6 NzHngAOKZjp7Oi3Nh/DU8G8Jcc2zh3AP1abuWsC67xSs36jTwXy/P7IAsYzU8JnFjsJX w9yWX5Vx9OVm6UlUNrMUQfHrEVjwo+APG0U+FpJtsZou3HQl79MjD/VvEVVqvb0KUD0Y gFvXOZYMtiuAGZLQ8EcOlFRwENHVWs3Mqip0AL3xWrsbrpjsu6uf1GziikM7E7pZR+SK lIOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690296485; x=1690901285; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eeDnhW8G235QmN4gi+lXNv+PCGenviFDXl3lddVtThE=; b=P87jgP3xyqLFvqveyyKmHZHj86ERONXBjAK7Ao4xvuU5hiy47/nhw7DJ3NF9uNk7zz K1bjJDhFr8qz/jqJqbJmOaMXrwylmm/JekHR2HSr14hAmm5XtHrRRWiPABdTPbdtAMGW BJ3P7gJKrWAPcqoEOd+EBfHPS9qRYAKi01/9aj73UBdGZ0YOLD1rUONg8Clkmh57QZgE pLnd31V9+IUlR3DDuwqvtHKX/J+V0iER8g6VJJ0NYJkxP/svBAxOu5CmpZpJIV09pMrs udHSwwjKm9hhAI06+fBh8QFp5bq7eIlAJ/OZTVx/gntOoAuOmnbc5nkGGCaFuM9ycLMu KrXQ== X-Gm-Message-State: ABy/qLa/gZS6dvfRzPI6uFjoC5x2iBTmc80qdB1CBVUMY6rLIdve5KqA gR171fnyzu+49FN0FqQXjjFQ4JzJRRfwiaPBKUE= X-Google-Smtp-Source: APBJJlFpCtqPsmB6743UNGUbVdUjt+KlIyrPq5iAQzvlKxpSDiQXYcRWInmZ4eV883smdHizoY61s0Pdfk42rGNj6c0= X-Received: by 2002:aa7:cfcd:0:b0:522:1d1d:1de8 with SMTP id r13-20020aa7cfcd000000b005221d1d1de8mr7781026edy.2.1690296484635; Tue, 25 Jul 2023 07:48:04 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266072 Archived-At: Would it be worth putting this in Emacs 29 since the RC is out? This is likely better and so far there are no obvious issues. Aaron On Sun, Jul 23, 2023 at 9:01=E2=80=AFAM Aaron Jensen wrote: > > On Sun, Jul 23, 2023 at 7:20=E2=80=AFAM Alan Third wrot= e: > > > > On Thu, Jul 20, 2023 at 10:02:53PM -0400, Aaron Jensen wrote: > > > > > > I've been using this for about a month now and have seen no artifacts= : > > > > > > diff --git a/src/nsterm.m b/src/nsterm.m > > > index 78089906752..d23fb650ab8 100644 > > > --- a/src/nsterm.m > > > +++ b/src/nsterm.m > > > @@ -2708,9 +2708,6 @@ Hide the window (X11 semantics) > > > EmacsView *view =3D FRAME_NS_VIEW (f); > > > > > > [view copyRect:srcRect to:dest]; > > > -#ifdef NS_IMPL_COCOA > > > - [view setNeedsDisplayInRect:destRect]; > > > -#endif > > > } > > > > > > unblock_input (); > > > @@ -10435,7 +10432,7 @@ @implementation EmacsLayer > > > cache. If no free surfaces are found in the cache then a new one > > > is created. */ > > > > > > -#define CACHE_MAX_SIZE 2 > > > +#define CACHE_MAX_SIZE 1 > > > > > > - (id) initWithColorSpace: (CGColorSpaceRef)cs > > > { > > > @@ -10621,7 +10618,7 @@ - (void) display > > > { > > > NSTRACE_WHEN (NSTRACE_GROUP_FOCUS, "[EmacsLayer display]"); > > > > > > - if (context) > > > + if (context && context !=3D [NSGraphicsContext currentContext]) > > > { > > > [self releaseContext]; > > > > > > > > > I'm not sure what the ramifications are for CACHE_MAX_SIZE 1 on slowe= r > > > machines, but I don't notice any performance issues on my M1. > > > > > > Alan, what do you think we should do? Is there anything else you thin= k > > > I should test for the next bit of time? > > > > I dug out my mac and built this and it still flickers with animated > > gifs. It's pretty easy to make happen, so it must be some hardware > > performance thing. > > > > Anyway, I've tried simplifying the double buffering code and put in > > all the wee changes I've thought about. Who knows if this will work > > any better... > > > > (It may be worth making the single/double buffering a run-time option > > as theoretically the single buffering will perform better, although > > always at the increased risk of tearing effects etc.) > > Thanks, I'll try this one out. FYI there was a typo in a comment: doible > > Aaron