From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#23928: 25.0.95; Performance regression observable with smartparens Date: Sun, 10 Jul 2016 02:55:31 +0000 Message-ID: References: <83wpkug2zs.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c04a0d2d5285305373f2bd2 X-Trace: ger.gmane.org 1468119389 32497 80.91.229.3 (10 Jul 2016 02:56:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jul 2016 02:56:29 +0000 (UTC) Cc: 23928@debbugs.gnu.org To: Eli Zaretskii , Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 10 04:56:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bM4uk-0002xE-70 for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jul 2016 04:56:14 +0200 Original-Received: from localhost ([::1]:53165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bM4ui-0007N3-RL for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2016 22:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bM4uc-0007Mm-Dm for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 22:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bM4uY-0006E6-8I for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 22:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bM4uY-0006E2-4o for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 22:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bM4uX-0001n2-Mo for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 22:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2016 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23928-submit@debbugs.gnu.org id=B23928.14681193496862 (code B ref 23928); Sun, 10 Jul 2016 02:56:01 +0000 Original-Received: (at 23928) by debbugs.gnu.org; 10 Jul 2016 02:55:49 +0000 Original-Received: from localhost ([127.0.0.1]:44559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bM4uK-0001mc-Ox for submit@debbugs.gnu.org; Sat, 09 Jul 2016 22:55:49 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:36624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bM4uI-0001mN-Vm for 23928@debbugs.gnu.org; Sat, 09 Jul 2016 22:55:47 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id f6so31014549ith.1 for <23928@debbugs.gnu.org>; Sat, 09 Jul 2016 19:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0Tuw0fQKThu1KOK2tLE1RgA44Enph/kFXoWL0vHetrE=; b=ysWFd1cDswoDoP6vGCwxn9TvUgC9VWDmrAQK1I9FwwzgIvOqZ2niI/SI/1MILYOyMf 7F+g8yeGx7IVFVXlp46xPlcCWgKI9STMy3x9NL9b577YHpkQvEJ4ywUC0eJSY+bSdlCB gg3O0CAFi0aTlme7BhOawnhZeliYjOpY7FYUg5x4hyMh0Psnn9jxwn4jeK0Hf9Q5Zc4J lyI1G3UF1hw76mSaWfViLxLZMQrDS319WvzSaUezRdVue8Bjw5LUzU9idX6sFjbtXdd/ OYMfZMppXDEbT0xxMjNzwxvhQUAlRlkwSg++SzFq+N44ElxuzaLAUfxMO+NmRnvfu0jd ToHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Tuw0fQKThu1KOK2tLE1RgA44Enph/kFXoWL0vHetrE=; b=Rod9Do3eu5nZquuDooirOaFExobhS8rAVxRtSbUo+XvyroInLe3hwcFSob3F/IfiWD tz9fJ36KTM8e7o54xUjqpZbQXarPX8Ybpbh/p94pw4FicwRl9JpSqEobqWb3mt6OPAh1 3/o3axIvAnhNXjGTYeC/rjtSx8eu/IkycWmb4qbAelKPGAb4Kt4nITW6+O8N5yGRGwY4 nAPYjJqqrVtd26d1bH8OhrrtqAARFUuadu9d1Q+5BxkjARbSw9Xcw/X4kaknfBXRfkXR pyVm6wS14+Ha0mih+ixX7uzI8D2kK7KRftmhTPWokpH7ZE+e5saMlLGsETLsIkabgCe2 H+dQ== X-Gm-Message-State: ALyK8tKLthsd+ACBlqX8ac9O6ILN64NLqChlGt+upA1H+OXGyB1+oZmsWqTt3xe7Q5xOtyr086+v0su4VZ7pxw== X-Received: by 10.36.142.129 with SMTP id h123mr10155927ite.66.1468119341408; Sat, 09 Jul 2016 19:55:41 -0700 (PDT) In-Reply-To: <83wpkug2zs.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120736 Archived-At: --94eb2c04a0d2d5285305373f2bd2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, Jul 9, 2016 at 10:01 AM Eli Zaretskii wrote: > > To narrow things down, it would be helpful to have a profile from 24.5 > > (which I understand doesn't have this performance problem?) for > > comparison. > I=E2=80=99ve added profiles of both here: https://gist.github.com/aaronjensen/a1c2b56eac192b0d9cac76b493822070 In this profile, they=E2=80=99re showing pretty much the exact same perform= ance, so that doesn=E2=80=99t tell us much. I believe the performance degradation is something that happens over time, and these are fresh runs of emacs. I=E2= =80=99ll have to try and get from 25 next time it slows down on me. One curious thing is that the emacs 24 profile shows all of the builtins (let/if/save-excusion) and the emacs 25 profile does not. Is there something I=E2=80=99m doing wrong that is causing that? I=E2=80=99m using t= he same `profiler-start` function. > > I think the version of smartparens and some kind of recipe starting > from "emacs -Q" is also required, because saying it's unusable doesn't > really tell enough. > I=E2=80=99ll work on this. It seems possible that it will be very hard to t= rack down given the nature=E2=80=94the performance isn=E2=80=99t *always* bad, i= t just becomes bad at some point in the session. It=E2=80=99s possible that this is not an= emacs or even a smartparens bug, I mostly opened this in case something stood out, =E2=80=9COh, yea we changed the regex engine and=E2=80=A6=E2=80=9D or = something like that. > > As I said, I'm not yet convinced it's an Emacs core problem. I see no > evidence to that effect. > > And please don't use elp.el to produce profiles, use profiler.el, > because the latter can profile primitives as well. > I don=E2=80=99t even know how to use elp.el, was there some indication that= I was? As I said above, I=E2=80=99m confused by the fact that emacs 25 profiler ou= tput is missing built in functions (Is this what you mean by primitives?) Thanks! --=20 Aaron --94eb2c04a0d2d5285305373f2bd2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Sat, Jul 9, 2016 at 10:01 AM Eli Zaretskii <eliz@gnu.org> wrote:
<= div dir=3D"ltr">
&= gt; To narrow things down, it would be helpful to have a profile from 24.5<= br> > (which I understand doesn't have this performance problem?) for > comparison.

I=E2=80=99ve added profiles of both here:= =C2=A0https://gist.github.com/aaronjensen/a1c2b56eac192b0d9cac76b493= 822070

In this profile, they=E2=80=99re showin= g pretty much the exact same performance, so that doesn=E2=80=99t tell us m= uch. I believe the performance degradation is something that happens over t= ime, and these are fresh runs of emacs. I=E2=80=99ll have to try and get fr= om 25 next time it slows down on me.

One curious t= hing is that the emacs 24 profile shows all of the builtins (let/if/save-ex= cusion) and the emacs 25 profile does not. Is there something I=E2=80=99m d= oing wrong that is causing that? I=E2=80=99m using the same `profiler-start= ` function.

I think the version of smartparens and some kind of recipe starting
from "emacs -Q" is also required, because saying it's unusabl= e doesn't
really tell enough.

I=E2=80=99ll work on this. It seems po= ssible that it will be very hard to track down given the nature=E2=80=94the= performance isn=E2=80=99t *always* bad, it just becomes bad at some point = in the session. It=E2=80=99s possible that this is not an emacs or even a s= martparens bug, I mostly opened this in case something stood out, =E2=80=9C= Oh, yea we changed the regex engine and=E2=80=A6=E2=80=9D or something like= that.=C2=A0
<= div>=C2=A0

As I said, I'm not yet convinced it's an Emacs core problem.=C2=A0 = I see no
evidence to that effect.

And please don't use elp.el to produce profiles, use profiler.el,
because the latter can profile primitives as well.
I don=E2=80=99t even know how to use elp.el, was there some ind= ication that I was? As I said above, I=E2=80=99m confused by the fact that = emacs 25 profiler output is missing built in functions (Is this what you me= an by primitives?)

Thanks!
=
--
Aaron
--94eb2c04a0d2d5285305373f2bd2--