From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line Date: Thu, 15 Jun 2023 22:30:22 -0400 Message-ID: References: <831qij24qm.fsf@gnu.org> <83wn0bzoeb.fsf@gnu.org> <83y1kltgeq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18724"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eshel Yaron , 63988@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 16 04:31:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9zFB-0004ii-AF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Jun 2023 04:31:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9zEu-0002Qn-5D; Thu, 15 Jun 2023 22:31:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9zEs-0002Qc-PR for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 22:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9zEs-00011f-Gm for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 22:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9zEr-0001vG-V2 for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 22:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2023 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63988 X-GNU-PR-Package: emacs Original-Received: via spool by 63988-submit@debbugs.gnu.org id=B63988.16868826427357 (code B ref 63988); Fri, 16 Jun 2023 02:31:01 +0000 Original-Received: (at 63988) by debbugs.gnu.org; 16 Jun 2023 02:30:42 +0000 Original-Received: from localhost ([127.0.0.1]:48282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9zEX-0001ub-TD for submit@debbugs.gnu.org; Thu, 15 Jun 2023 22:30:42 -0400 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:53490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9zEV-0001uM-EY for 63988@debbugs.gnu.org; Thu, 15 Jun 2023 22:30:40 -0400 Original-Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6b29b9f5a94so227030a34.2 for <63988@debbugs.gnu.org>; Thu, 15 Jun 2023 19:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686882633; x=1689474633; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h9MEbRpDTRi3vkkeszAsjFEl00sOMB5S7JobSC37sMw=; b=o4A5eZ/jMhudJaegpSj5daNDPiF6pz/dWm/W0Xv4DYcYESKMjXMeKoj1R1dE4Ju5Ui 084HnSuT75sUYKycz4xqqh9aD6bqzLexGIAN8NlCRiiDkLLSOLKyo8Srl2VTwtwqUNFC N/YlltjnPMwyAyAaSL/uCUoFFnQN+6U5QoFTPLU0XRl+SP583HFWDp+fRmv+EJDg9yAs qIyIMDmEEP5/FNAH5KZSl/stPiWO/kugqWrNOSDbMvQwXgzsthO/ABBGF45URQE+Pzsq bdjuRWjisZQrcH+KPl52bnFwAYNY4joJPdKq53ZNd7rdfnmibhVj74w0GCDedAika3Cp h/AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686882633; x=1689474633; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h9MEbRpDTRi3vkkeszAsjFEl00sOMB5S7JobSC37sMw=; b=VTQyoXO4d0QUD06kl2S6lP6nYzAlTMzFtA1V0M4MJACoiplKC77qVRNH6eCn8gdUjw MZ2yM9seL4q1RbOTsnlae7un9zIjm/JhzzL8NFceW2Bt5J6DtolfousPT0eCPfwOMbvh P0EGDAopzEzEaD3nTp/TGko0aKdu68yACEc8KVXT/TVGVzBe9WErpz4eNu7101ZRlJiY BMTZNVAaPfUTSma/g4xrsHGQrbaU6HZiiKdt/WHsrkbc6x3Fhsq9d3hERXZoFG/pjeFv 97+IuBJ/hFNI1YmDVlihCnynvFsnK/Xs/4UJ47aFhtxtQ2owujBqolMrnmlK7/T9Xbb9 2LdA== X-Gm-Message-State: AC+VfDxsRn42osltQ2kD3WGAFe1fafYAYYPmhlX2hLLuKiyhPqYTMhlF fObSno7WH8MuXnvQff7KUqWsDLiYeNKsyJ3QT/U= X-Google-Smtp-Source: ACHHUZ519BIpK7Hryjfg1wxmeaTxIQkN0nNERB5i6X2WWMrANK4aqdoGVePsTzWKzkz4MBncOuefjpfP6bvXhbfruck= X-Received: by 2002:a54:410a:0:b0:398:26c5:558a with SMTP id l10-20020a54410a000000b0039826c5558amr823823oic.46.1686882633436; Thu, 15 Jun 2023 19:30:33 -0700 (PDT) In-Reply-To: <83y1kltgeq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263444 Archived-At: On Thu, Jun 15, 2023 at 1:58=E2=80=AFAM Eli Zaretskii wrote: > > > From: Eshel Yaron > > Cc: aaronjensen@gmail.com, 63988@debbugs.gnu.org, Stefan Monnier > > > > Date: Sat, 10 Jun 2023 12:07:22 +0300 > > > > > So maybe we should declare this feature a failed experiment and remov= e > > > it? > > > > FWIW I think that make sense, but IMO it'd be best to only remove the > > treatment of `:eval` in `window_wants_header_line`, and keep the new > > treatment of `header-line-format` being a cons cell with a void or > > nil-valued variable car. That's still useful because it works well wit= h > > minor mode variables, and it's less risky as it doesn't involve > > evaluating arbitrary lisp, just inspecting a variable. > > Why would it make sense to leave the non-nil car case? > > It sounds like the consensus here is that indeed this feature is not > worth the complications, and so, unless I hear some good reasons not > to do so, I intend to delete it in a week's time. I strongly support this. It's a major performance regression for me and it seems to correspond with crashes on window resizing: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x191054724 __pthread_kill + 8 1 libsystem_pthread.dylib 0x19108bc28 pthread_kill + 288 2 libsystem_c.dylib 0x190f6246c raise + 32 3 Emacs 0x100a215b0 terminate_due_to_signal + 212 4 Emacs 0x100a21dfc emacs_abort + 20 5 Emacs 0x1009f0594 ns_term_shutdown + 13= 2 6 Emacs 0x1008dcc90 shut_down_emacs + 332 7 Emacs 0x100a21578 terminate_due_to_signal + 156 8 Emacs 0x1008fd4bc deliver_fatal_thread_signal + 128 9 Emacs 0x1008fee80 handle_sigsegv + 64 10 libsystem_platform.dylib 0x1910baa24 _sigtramp + 56 11 Emacs 0x10083a90c start_display + 56 12 Emacs 0x10085010c try_window + 144 13 Emacs 0x10086c88c display_echo_area_1 += 136 14 Emacs 0x1008496dc with_echo_area_buffer + 784 15 Emacs 0x1008485bc echo_area_display + 2= 68 16 Emacs 0x1008483bc message3_nolog + 548 17 Emacs 0x100847f5c message3 + 132 18 Emacs 0x100952470 Fmessage + 68 19 Emacs 0x100958074 eval_sub + 1980 20 Emacs 0x10095824c Fprogn + 48 21 Emacs 0x10095d728 funcall_lambda + 1276 22 Emacs 0x10095c284 apply_lambda + 280 23 Emacs 0x100957da8 eval_sub + 1264 24 Emacs 0x1009581c8 Fand + 60 25 Emacs 0x100957f7c eval_sub + 1732 26 Emacs 0x1009593f0 FletX + 268 27 Emacs 0x100957f7c eval_sub + 1732 28 Emacs 0x100957ed0 eval_sub + 1560 29 Emacs 0x100957ed0 eval_sub + 1560 30 Emacs 0x100957ed0 eval_sub + 1560 31 Emacs 0x10095824c Fprogn + 48 32 Emacs 0x10095d728 funcall_lambda + 1276 33 Emacs 0x10095c284 apply_lambda + 280 34 Emacs 0x100957da8 eval_sub + 1264 35 Emacs 0x10095974c Flet + 316 36 Emacs 0x100957f7c eval_sub + 1732 37 Emacs 0x100958034 eval_sub + 1916 38 Emacs 0x10095824c Fprogn + 48 39 Emacs 0x10095d728 funcall_lambda + 1276 40 Emacs 0x100959dc8 Ffuncall + 316 41 Emacs 0x100958074 eval_sub + 1980 42 Emacs 0x10095824c Fprogn + 48 43 Emacs 0x100957f7c eval_sub + 1732 44 Emacs 0x10095824c Fprogn + 48 45 Emacs 0x10095d728 funcall_lambda + 1276 46 Emacs 0x100959dc8 Ffuncall + 316 47 Emacs 0x1009677d4 mapcar1 + 328 48 Emacs 0x1009675b4 Fmapconcat + 460 49 Emacs 0x1009580d8 eval_sub + 2080 50 Emacs 0x1009593f0 FletX + 268 51 Emacs 0x100957f7c eval_sub + 1732 52 Emacs 0x10095c070 Feval + 84 53 Emacs 0x100959dc8 Ffuncall + 316 54 Emacs 0x10095ab74 internal_condition_case_n + 156 55 Emacs 0x100842d84 safe__call + 296 56 Emacs 0x100842e40 safe__call1 + 36 57 Emacs 0x100842e68 safe_eval_inhibit_quit + 28 58 Emacs 0x10088d47c null_header_line_format + 388 59 Emacs 0x100881800 window_wants_header_line + 296 60 Emacs 0x100839e0c window_box_height + 8= 60 61 Emacs 0x100829838 required_matrix_height + 72 62 Emacs 0x100829908 allocate_matrices_for_window_redisplay + 148 63 Emacs 0x100823728 adjust_frame_glyphs += 88 64 Emacs 0x10088f638 Fset_window_configuration + 4068 65 tab-bar-f81d329c-3b6a0fc2.eln 0x107163bc8 F7461622d6261722d73656c6563742d746162_tab_bar_select_tab_0 + 868 66 Emacs 0x100959dc8 Ffuncall + 316 67 tab-bar-f81d329c-3b6a0fc2.eln 0x1071641d4 F7461622d6261722d7377697463682d746f2d6e6578742d746162_tab_bar_switch_to_nex= t_tab_0 + 260 68 Emacs 0x100959dc8 Ffuncall + 316 69 Emacs 0x10095592c Ffuncall_interactively + 68 70 Emacs 0x100959dc8 Ffuncall + 316 71 Emacs 0x100956a08 Fcall_interactively += 4292 72 simple-fab5b0cf-e1c8f2a9.eln 0x102b54b0c F636f6d6d616e642d65786563757465_command_execute_0 + 652