From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Mon, 1 May 2023 09:47:50 -0400 Message-ID: References: <87ilddec31.fsf@yahoo.com> <87edo0exct.fsf@yahoo.com> <83wn1sns1n.fsf@gnu.org> <87pm7kchqw.fsf@yahoo.com> <83pm7knpzi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Alan Third , 63187@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 15:49:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptTu5-0009Tm-Gd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 15:49:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptTtr-0000D4-Sq; Mon, 01 May 2023 09:49:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptTto-0000CJ-FU for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:49:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptTtn-0002p7-5c for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptTtn-0001ki-29 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:49:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 13:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.16829488906545 (code B ref 63187); Mon, 01 May 2023 13:49:03 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 1 May 2023 13:48:10 +0000 Original-Received: from localhost ([127.0.0.1]:39206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptTsv-0001hQ-Gx for submit@debbugs.gnu.org; Mon, 01 May 2023 09:48:10 -0400 Original-Received: from mail-pf1-f182.google.com ([209.85.210.182]:61847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptTst-0001gS-LI for 63187@debbugs.gnu.org; Mon, 01 May 2023 09:48:08 -0400 Original-Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-63b4960b015so1704513b3a.3 for <63187@debbugs.gnu.org>; Mon, 01 May 2023 06:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682948881; x=1685540881; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DXPDHvghEjMIqFD5CgDdx/k4Lj3PxenqaWOMTVigIZQ=; b=nimImWgbdiPKpd//UI02L8FAZ9ep1SdRJYdyRi7CW7VqS4CZ+uuwjTtvw+PGv34eg0 ZgdRfaOdkCOXNrqmhABi3B03N/jzfoXQICqQa9IykwfaMKAZtQti+ZLnDhSuNJEO8zXr xE0+LCUQ+ZFTIYpQCmHKuEXfwOLkPw4zqoMihmWGC3i91kT1nPnrrEb8VnTXVjFYFc8i LJoQGFyZNm5QHCrPAiihC2UvqGEcbuF9PK/NI8+BgImJ1vQR6aW+6eKvQ//EIugdxrur l9aeDkBgzNug3lwDGjoYFkOhAzS0rz0kxTMNTWgkj94Cge7l+Aj2P9RQ1z/AGEZyuX2O yaow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682948881; x=1685540881; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXPDHvghEjMIqFD5CgDdx/k4Lj3PxenqaWOMTVigIZQ=; b=AuTAOA/cnvAR/DiKqZ7APhQOAmC37jxWfVTWifiyt95rPBd6hgJmuBCdF+whcAK8eu +NnogI6wnJNyrYhw8J6/kBdrF5FI5PZML46bgPysUOu8H/gOAvfPpomgCvyYs931nWFg 37tgUY/XGqY2M/sxLZhRMEY5sx+HPbhRAdLXuG1bkNnQxA1kq8ngShFaFS/ih1pcYkcw lN/3L8fdwZAsOudb5eY98ISfv9sxTGgHMfTZ0DGqNoVXagC4pewpn2Kd/H5JyasMjbwV BiooOsSUjkoPBGnvijswhfnJODbNRcs3oDCMDGcSXLK2gcKwXn5L+ecmkAwUGApwyN0N /hvA== X-Gm-Message-State: AC+VfDwhwRSEQMn7sAZ8NNnS+lkib4wKRRcLjepoOhXdB1FCdRe9T9CL wfR9WjKbkFY2AADuTPj45sN/7zYijtakWwhIp+k= X-Google-Smtp-Source: ACHHUZ4ef9IFQrZ1eT7Wdr4uc2NiuZk9penRKFvRPeGpUTARCEX/CsasRP25jD/eUqZo4uw4+kIrYVu/0nR+yqDRH5o= X-Received: by 2002:a05:6a20:8403:b0:f6:d60d:dbc2 with SMTP id c3-20020a056a20840300b000f6d60ddbc2mr17724696pzd.28.1682948881164; Mon, 01 May 2023 06:48:01 -0700 (PDT) In-Reply-To: <83pm7knpzi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260869 Archived-At: On Mon, May 1, 2023 at 9:24=E2=80=AFAM Eli Zaretskii wrote: > > > From: Po Lu > > Cc: aaronjensen@gmail.com, 63187@debbugs.gnu.org > > Date: Mon, 01 May 2023 21:18:31 +0800 > > > > Eli Zaretskii writes: > > > > >> Cc: 63187@debbugs.gnu.org > > >> Date: Mon, 01 May 2023 07:58:26 +0800 > > >> From: Po Lu via "Bug reports for GNU Emacs, > > >> the Swiss army knife of text editors" > > >> > > >> Aaron Jensen writes: > > >> > > >> > Is there anything specific to macOS that is involved in scrolling = optimization? > > >> > > >> Yes, Apple deleted the API used to perform bit blits, so Emacs uses = a > > >> workaround that I don't really understand, and seems unreliable. > > > > > > You mean, ns_scroll_run in nsterm.m? Which parts of it do you not > > > understand? > > > > No, I meant the implementation of [EmacsView copyRect:] enabled under > > Mac OS; see line 8655 of nsterm.m. I don't understand how the system > > synchronizes its access to the window's backing store with Emacs's. > > Alan, can you help? > > If this is unworkable on macOS, we could simply disable this > optimization there. But note that scroll_run_hook is also called from > xdisp.c, in several places, so we may need to disable it there as > well. Is this suspect? { NSRect srcRect =3D NSMakeRect (x, from_y, width, height); NSPoint dest =3D NSMakePoint (x, to_y); EmacsView *view =3D FRAME_NS_VIEW (f); [view copyRect:srcRect to:dest]; #ifdef NS_IMPL_COCOA [view setNeedsDisplayInRect:srcRect]; #endif } Why is the source being marked for redisplay? I would expect the destination to be marked as such, or am I missing something?