From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Mon, 23 Dec 2024 21:17:16 -0800 Message-ID: References: <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> <86jzcafcj6.fsf@gnu.org> <867c8af514.fsf@gnu.org> <86ldwpedud.fsf@gnu.org> <86r05z67gm.fsf@gnu.org> <86wmfp3gh4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000016d1820629fd3a8e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27936"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, yantar92@posteo.net, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 24 06:19:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPxK5-00075R-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Dec 2024 06:19:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPxJx-0001kl-8Y; Tue, 24 Dec 2024 00:19:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPxJv-0001kH-DJ for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2024 00:19:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPxJv-0002lR-5S for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2024 00:19:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:Mime-Version:To:Subject; bh=x7NiAhhDbiTrwjgxb4eyVvfRxmLHHreHBbLN3VqCZCM=; b=durUIl5wcCLy6WSiXF1GFi6Pf+nK4icMKRMij55aehsfrcj3p47nX7Kn4ltCYAKZYqMrbJwA0DhoHMKGtUpEPbiqOXSLzXTv/aQU+zI1BXYXL13CiJgMDitK6C20/bDbmmog5P83OEYye9OMjKT8F82cHrBvoyWpvhz3rXjM4PoE+PNv7qjHEbk0Zye2upnPf3pVjLfuKuXMvPrGwCxhjIwm6sK44amDeYBiCc7VR+ynoIX18jwEpsZSTQbZC86V2VJ72HTR9zgTFgY4/e4d/0ppzb+qOvsMUvY65ZzFn7OMp8ILZn0sI3XH/wnKh5jiTmyAyqBqsxZsU3acGDOMjQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPxJu-0001A1-LT for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2024 00:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2024 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.17350175044407 (code B ref 73862); Tue, 24 Dec 2024 05:19:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 24 Dec 2024 05:18:24 +0000 Original-Received: from localhost ([127.0.0.1]:59011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPxJH-000191-Qa for submit@debbugs.gnu.org; Tue, 24 Dec 2024 00:18:24 -0500 Original-Received: from mail-lj1-f178.google.com ([209.85.208.178]:61816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPxJD-00018q-Jr for 73862@debbugs.gnu.org; Tue, 24 Dec 2024 00:18:22 -0500 Original-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-3002c324e7eso52202851fa.3 for <73862@debbugs.gnu.org>; Mon, 23 Dec 2024 21:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735017438; x=1735622238; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x7NiAhhDbiTrwjgxb4eyVvfRxmLHHreHBbLN3VqCZCM=; b=lIxmOwMs34SUbNH0ffvzX2k7CIifZo+jRB6y3GpiEDDNiLgu0RY3Lh3Oi7fwrNfRK7 7eZUdoxjtLNqAoYlkCFr636KSZ+1YWDn2wkO59wmS6/LIKytBb7agsPQrPd5+pisLaRs idrEm1ktqcFLbhTQY5YXeWwKGZSF5dtP7kXNHldZu83I1OkwgoYVooLRJtq/Ow0T5y/Q 1qKn0ouJiu4arqk5NnUW9dYWnhDxXQjnZLHrWl2f2ZEtSHdj/xZJ+lOCKFPNVyP2ak8a Ab7y1VVXRJdqDeqNsEzEvC/uC+wbI2/IB7NLy0DpxZDiKJQr/r5P7CaD4QOiJ96ybyWL CJsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735017438; x=1735622238; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x7NiAhhDbiTrwjgxb4eyVvfRxmLHHreHBbLN3VqCZCM=; b=i/3Ex52gBitsLGaC25etHtjHFIINnPsddeHvJ2jZbQp4Y+8vUJg9IqZhS23OU8J0Bv Uogwbx5jBAl46pCCJYduwqI8yBL1zWGZ1RtdnqkaXl5qVYO7rhZRYifow9UgylTSAYVD iC93/rKAdRu0rF3yTI1qAVhRR0lzswgqGrEuQGlWZSvTu+xAqo/ca3sQxzICtha+ocra u778E9KC3zs75njLaW7JaflRBjuOp9IJBzCJGuA4dP0xIK8vooTttdFF+9BiR0Yd7h4F LE01HqRblhtwKheYDXll5uw3qMkR7itpWZN6JgpAS+1M284avTy8vo7XR4TgZlTCPdaS IaUQ== X-Forwarded-Encrypted: i=1; AJvYcCUc9OoZ6BThmN451bIDMMBd9/BH6Mu8CxseBb6yfipQymbynsFNTFY9roFOCQ7VzGEbKwYeOA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw/GeGev5XUJ8Y9XGR1HvSSDLpd+vZd4tC4amA2BOpriGkge3Ce /ii/risurpqQIwVEgfmr6K6BJ5eGB6VNzSW05EJvNQ28U1R6ooN071Ijmu+BVgc0+DhkzMaE4RC cYJ4TvIbntk60JDBFNRSc0huYmUY= X-Gm-Gg: ASbGncuaoEdlcAWKmIGgRQ5mG6yNOEt0YXRnPwdZsobr5Nn48HBuIrz4d7Q/vqd7RcK EOuKCVb9MaYx5ejP8JupkHOOruKVaxUsK6PtAoxzSpuZshdZaTcYFAn1Mbl+nsQ== X-Google-Smtp-Source: AGHT+IGgqN5MO8uM22xB1FYy+ZX4vjFsV4CBgbBp6JQHXBGWpkqZTb33Dly+qy30n+gU2mnd57EtwMlsXVnHXdrD6vY= X-Received: by 2002:a2e:a7ca:0:b0:300:26bc:4311 with SMTP id 38308e7fff4ca-30468569292mr35463591fa.18.1735017438300; Mon, 23 Dec 2024 21:17:18 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Dec 2024 21:17:16 -0800 X-Mailer: Superhuman Desktop (2024-12-18T20:41:51Z) X-Superhuman-Draft-ID: draft00c6989158efd2a0 X-Superhuman-ID: m520kllb.d0278144-9876-4521-97b4-7565b6870dfb In-Reply-To: <86wmfp3gh4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297682 Archived-At: --00000000000016d1820629fd3a8e Content-Type: text/plain; charset="UTF-8" On Mon, Dec 23, 2024 at 7:30 PM, Eli Zaretskii wrote: > From: Aaron Jensen > Date: Mon, 23 Dec 2024 13:19:32 -0800 > Cc: Eli Zaretskii , trevor.m.murphy@gmail.com, monnier@iro. > umontreal.ca, 73862@debbugs.gnu.org, yantar92@posteo.net > > On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron wrote: > > Eli Zaretskii writes: > > Please try the patch below. If it gives good results, please run with it > for awhile, and tell if you see anything unusual or unexpected. > > Thanks, so far so good. > > Same for me, it's also working so far. > > Are there any tradeoffs with this approach other than additional code > complexity? Any performance concerns? > > I didn't time the code. It is a bit more expensive, but I don't know by > how much. Maybe you could see what happens in a session with lots and lots > of faces and report? > Does the change impact anything more than the infrequent basic face calculation (whatever the thing was we were triggering by changing the default face size) or is it in the standard render path? Aaron --00000000000016d1820629fd3a8e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Dec 23, 2024 at 7:30 PM, Eli Zaretskii <eliz@gnu.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">

From: Aaron Jensen <aaronjensen@gmail.c= om>
Date: Mon, 23 Dec 20= 24 13:19:32 -0800
Cc: Eli Zaretskii <eliz@gnu.org>, trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca,=20 73862@debbugs.gnu.org, yantar92@posteo.net

On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron <me@eshelyaron.com> wrote:

Eli Zaretskii <eliz@gnu.org> writes:=20

Please try the patch below. If it gives good results, please run with it fo= r awhile, and tell if you see anything unusual or unexpected.=20

Thanks, so far so good.

Same for me, it's also working so far.

Are there any tradeoffs with this approach other than additional code compl= exity? Any performance concerns?

I didn't time the code. It is a bit more expensive, but I don't kn= ow by how much. Maybe you could see what happens in a session with lots and lots of faces and report?

<= /div>

Does the change impact anything more th= an the infrequent basic face calculation (whatever the thing was we were tr= iggering by changing the default face size) or is it in the standard render= path?

Aaron
--00000000000016d1820629fd3a8e--