From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sat, 7 Dec 2024 14:06:35 -0500 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000929d340628b2d42c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7265"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 20:08:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tK0A7-0001ko-AX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 20:08:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tK09r-00079A-RD; Sat, 07 Dec 2024 14:08:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tK09q-00078z-TJ for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 14:08:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tK09q-00064b-Km for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 14:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:References:From:In-Reply-To:Mime-Version:To:Subject; bh=DlRriEmite/6LkgYucPdIUKQjzEZxhnrP3SrdWTWAJY=; b=lWfiUKpL/7drk10QcSwaxV9IRGYrcTZloC9f69UxylkhSswZZVtdYosRfVfptqh0ufCbBYi4UTvElhbb2M+HOk85Wknbs47Eg+Ce3Tbb36+z8d0FeyJS1MBQ2rwlj6+j324pASarcXesP8yIHyKTSasuMRfuUWw+Z9/rUqO+DsJASd7zZ1DCo1CIvOBjTgWQkPuMggJwhGH6TJbEvIG7ehAhzBInZla/blJLFobFtv92AuamNvdMlOFUt6nXdf+9Ap2ak4dF6u/+uh1iIa5UmJiRveSpJ7MGCJriX3K7munztVlA9kBivDopNji069RRaqKbruj2PaS+2we4mmAuIA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tK09q-0005k8-FO for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 14:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173359846022040 (code B ref 73862); Sat, 07 Dec 2024 19:08:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 7 Dec 2024 19:07:40 +0000 Original-Received: from localhost ([127.0.0.1]:48533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK09U-0005jP-BE for submit@debbugs.gnu.org; Sat, 07 Dec 2024 14:07:40 -0500 Original-Received: from mail-lj1-f178.google.com ([209.85.208.178]:53723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK09R-0005jG-56 for 73862@debbugs.gnu.org; Sat, 07 Dec 2024 14:07:38 -0500 Original-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ffdbc0c103so28184691fa.3 for <73862@debbugs.gnu.org>; Sat, 07 Dec 2024 11:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733598396; x=1734203196; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DlRriEmite/6LkgYucPdIUKQjzEZxhnrP3SrdWTWAJY=; b=VCww+pkMr3XNZ2MPjO/vVz4MsfEwi4S8U+CIXRPW+tZHzOIz7unh/p62CT+AHJIhCi 1ahowEhM07X5wHDz5fcpVjmiDCTtvIs6hqmHD4+qFbeGfmp+HKNuJX9XqAsoLjh9j7SV fyt1PWnc9qjAXFpCJUu6VLdu7K6S5Qr/HqxTjcdlApOa8r5xoDNAnqz75rTJlyDyqmIT q/HVSyZu7ijp7NwHhhGzIVaSRA2ZcOzYXwpWRIx3EOKabiXsvPB4wawKAye5hVVFJhur mUg/QDSsRuhL6oA8M63oFwv+lCCdPvRIftVXhyO+x+RnKlVC8HV1UIrk6kqsLneNPVN7 g/9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733598396; x=1734203196; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DlRriEmite/6LkgYucPdIUKQjzEZxhnrP3SrdWTWAJY=; b=YaE24TjUqQAVhtPqgEzOkLvP+hNdsX82tCklUDdgzf+c55QcWDyiW0SJVKcYGDioLG 80anvjvMqNhi7eqIT+zDwCYiwP0VHxtdhrXq6pRaX5OuZrOaIk1sAj+ISByiNValc3YF kpR0ermutU7kfDk6HH9956r4jEoTY+p3pP5RjdsgA6JrHOUjzNQDcdBXDklx22VbBuJD F6v44fnS6zICaC7PtiZeLnGi3mGx9XedFi1ETlkMHDj7x5DsFT11hYUbsOkrF0aRZ9Yz EEuSTE6Xmcmir2ivsYwwb/DNyQ774OYYMs7vmq3YayD76++5vNulvv5IsTnwJvme3RS4 KpEw== X-Forwarded-Encrypted: i=1; AJvYcCVfILqcjVgl1Xov+Pl229sPKzDEROEDVFUJcGMJCqz3+gEQc+zEuSpKiJK11oC1jlQ8sNcd/g==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx98PyVgQQoMiHvFN0plwsZsGU+gRhVCRoiGORlVsHZiPlDkjGT Iwd2/JoOxmiJ014aW+Wq6HqxpJmdHFz6bwhaANNXKXxlUsTksSUOTcqm+XtIdHYtCSK/s4hKDHE uOMbd6tt1S5vBM78QjsFkKQ4FfLY= X-Gm-Gg: ASbGnct7NwSGLwCNpitIHEdtUxXrqT+ivhLR4BDReXX9qY3z6501CqfZnlo++HK0FYu boO4IHqrmcJRyB0WR6anrk7o2M00eUeVED/VzPg2oiUgApcNPmvUpGDUc X-Google-Smtp-Source: AGHT+IEpgEDrtSbY1RXQIjva6KkRCzLuO8ZL3DGH/JWeR0+8bmj9IY4fzQR/jhlwGlK66S5Q7MyMAFDNENXrllkWdUc= X-Received: by 2002:a05:651c:888:b0:300:43f9:ad57 with SMTP id 38308e7fff4ca-30043f9ae30mr9693711fa.32.1733598395929; Sat, 07 Dec 2024 11:06:35 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sat, 7 Dec 2024 14:06:35 -0500 X-Mailer: Superhuman Desktop (2024-12-02T20:06:08Z) In-Reply-To: <86ttbfgvyr.fsf@gnu.org> X-Superhuman-ID: m4ejpmil.08cf928d-85fa-4b32-b47a-5b0af4ab70f4 X-Superhuman-Draft-ID: draft007a1c0c4b7ed5ab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296594 Archived-At: --000000000000929d340628b2d42c Content-Type: text/plain; charset="UTF-8" On Sat, Dec 07, 2024 at 10:59 AM, Eli Zaretskii wrote: > I'm sorry you interpret what I wrote as rude, or insulting, or anything of > that kind. If anything, it was supposed to be mildly humorous. And when I > say "you aren't supposed to", I don't mean you personally. > Thank you, it's all good and I'm glad it was only a misinterpretation on my part. For what it's worth, I do appreciate the *massive* amount of user engagement choose to do. Thank you for that and for everything else you do for Emacs. P.S. My personal conclusion from this, and from many past bug reports that > causes us to add explicit remapping in many places, is that face-remapping > was a clever hack that should not have been allowed to happen without a > thorough rewrite of all the basic code which supports faces and their > merging. Hindsight is always 20/20. > That's a very interesting conclusion, and it makes sense. Would it make sense to extend the face doc strings that should not use inheritance to indicate that? That combined with the backwards compatibility fix you suggested may very well be a good compromise for the current circumstance. Alternatively, if there were a path to deprecating header-line and mode-line then the compatibility fix could be skipped. Thanks, Aaron --000000000000929d340628b2d42c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Dec 07, 2024 at 10:59 AM, Eli Zaretskii <eliz@gnu.org> wrote:
<= div class=3D"sh-quoted-content">
=

I'm sorry you interpret what I wrote as rude, or insulting, or anything of that kind. If anything, it was supposed to be mildly humorous. And when I say "you aren't supposed to", I don'= ;t mean you personally.


Thank you, it's all good and I'm glad it was only= a misinterpretation on my part. For what it's worth, I do appreciate t= he *massive* amount of user engagement choose to do. Thank you for that and= for everything else you do for Emacs.

P.S. My personal conclusion from this, and from many past bug reports that causes us to add explicit remapping in many places, is that face-remapping was a clever hack that should not have been allowed to happen without a thorough rewrite of all the basic code which supports faces and their merging. Hindsight is always 20/20.


That's a ver= y interesting conclusion, and it makes sense.

= Would it make sense to extend the face doc strings that should not use inhe= ritance to indicate that? That combined with the backwards compatibility fi= x you suggested may very well be a good compromise for the current circumst= ance.

Alternatively, if there were=C2=A0a path= to deprecating header-line and mode-line then the compatibility=C2=A0fix c= ould be skipped.

Thanks,

<= div>Aaron

--000000000000929d340628b2d42c--