From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist Date: Wed, 20 Nov 2024 13:38:27 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005f938f06275ef8ac" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35094"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59790@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 20 22:40:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDsQw-0008x8-06 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Nov 2024 22:40:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDsQf-00046Q-1o; Wed, 20 Nov 2024 16:40:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDsQc-00046G-MJ for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 16:40:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDsQc-0003Qr-E2 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 16:40:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:References:In-Reply-To:Mime-Version:To:Subject; bh=exX53KOKsiyAZPF7jVJF9Kjysq+HPUMy+AFwt5/bfT4=; b=HtWr673xFipewx9KkzGsQeDIkRKOMjb+O/VY6G514ymjQGtQc7ZMIa5qYvmDflThBVjlW3Ks1Htqw08e+7q2fq+Vhkp3qiBQRbcPqLO4E7jmuMjdPPBJPJLx5jJhnUFTS4QWPXYLCcj2SjttQOQTA7FMK52hY04KERi/pXjjeD+rqy3KWPZfv6NpsYYtpYHTBQQnwIPRAXutAcqkqA9rI7Wgd4s5mxCVMNUaa2j4hryAc2egTssI3PM0saCBU4V/b9h8nKGPsOxWeYc/kLUnmDDmfHWFewUucp9PWrbVyc7QcUeN8YxyIaA9/uVF7mBfjRe7aPWImjGst2UNdcYfJA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDsQc-0001Vu-9k for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 16:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2024 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59790 X-GNU-PR-Package: emacs Original-Received: via spool by 59790-submit@debbugs.gnu.org id=B59790.17321387765780 (code B ref 59790); Wed, 20 Nov 2024 21:40:02 +0000 Original-Received: (at 59790) by debbugs.gnu.org; 20 Nov 2024 21:39:36 +0000 Original-Received: from localhost ([127.0.0.1]:48015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDsQC-0001V9-0q for submit@debbugs.gnu.org; Wed, 20 Nov 2024 16:39:36 -0500 Original-Received: from mail-lj1-f169.google.com ([209.85.208.169]:52370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDsQ9-0001Ux-VZ for 59790@debbugs.gnu.org; Wed, 20 Nov 2024 16:39:34 -0500 Original-Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2fb51e00c05so4165331fa.0 for <59790@debbugs.gnu.org>; Wed, 20 Nov 2024 13:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732138708; x=1732743508; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=exX53KOKsiyAZPF7jVJF9Kjysq+HPUMy+AFwt5/bfT4=; b=fIYGLy5N+/w7JK574MO4C3Qe0OxgChcwyzopbaxABA5e4tAwfSCYhMdtdua+qN4M7c UtaoWwXKMR0g+HKcheVS9cdpK2ylUKIwzCq+rBd336sBX/E7yt+gZ88g40L151ZT0R5B ZmIGhdbr1g3OaZj4QHHlRfJpf82Q/QWrbCjBxps0Pdg/V78G1ScTz0l8yzdANjinZ11V Ckv+B7xG6XNNEA8fLz2VMcMeb3JyB6y0AqniOva/do8qAlfwJ428j2hP1c4Z8RlcM8XX GUkZsm7uOMxug2z8JlZFO707AaMQV7tLwTcFHyKtwZ5gH62jTMSHobc3YoI5x2QwLlKq NroQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732138708; x=1732743508; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=exX53KOKsiyAZPF7jVJF9Kjysq+HPUMy+AFwt5/bfT4=; b=UFBKpNsT3PvgBfcQh0GeOyKFEaHReD10RWqI5quniVF/6JEHc10Cg4/+CP40BnLgGO rVUlvpM5HBNxjfrCmJ4UmLNtwBAdsHxV+PHplYmyzrQyYIkoL9fhy3kXIfuNPrwmkDVK cNjyz8rlbLBJv24pqhGgwnqB5dEQc8TuDuiJSV6xz2FZTc1FI3yLZAXklv5s6OTs8PRM l2cDl0SdAvzm/kuwHMUmne/Q8wrHAGcg1uLy/GvTIHNHIoqfaPjxht3FMnXKcTm2FhZk rryuw267DAeBmGJo3jGANnhzSATBtLF2YtYw/06X45/EaajQg3UWLFhlufUNBZt+vYct 6W9w== X-Gm-Message-State: AOJu0YxP2EysbGa5TMN8sHGGHOcbRoETXCy4TNJ7uiVKVavxfukpeART RH9Fvrf2F8i774cVk+gUWFdh8thcdv9fkMhOmxc53YgELJ5qEWkjGZtbs7vSKnc1CXawbSdGqsO KtallKK/3udgux45u95pYetWn+tM= X-Google-Smtp-Source: AGHT+IHrN9bS9HmOnwC0FzwSYImHa6vR/8LSWt/P+/7ws/gkIiTbcLDs23oBtrYNjAGMXN2A20Q2M+wZjRjFG5ySvas= X-Received: by 2002:a2e:be23:0:b0:2fb:cff:b535 with SMTP id 38308e7fff4ca-2ff8db2d270mr41710091fa.13.1732138707682; Wed, 20 Nov 2024 13:38:27 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Wed, 20 Nov 2024 13:38:27 -0800 X-Mailer: Superhuman Desktop (2024-11-19T20:42:35Z) X-Superhuman-ID: m3qenfwr.a6620e7d-d55a-42c6-8d0a-ddae2d372600 X-Superhuman-Draft-ID: draft00fb63f38a0f8436 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295701 Archived-At: --0000000000005f938f06275ef8ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for trying it out. I saw the error as well both before and after the patch, so I didn't look into it. I think you're right though. I can try that out later. It probably shouldn't impact when/if this patch should be installed. Are you able to install this and the other or do we need someone else to sign off on it and install them? Aaron On Wed, Nov 20, 2024 at 1:27 PM, Alan Third wrote: > On Sun, Nov 17, 2024 at 12:00:07AM -0500, Aaron Jensen wrote: > > =E2=80=8BThe bugged behavior is that `ns-use-native-fullscreen' set to ni= l is not > read when launching emacs. > > The attached patch should fix this. The problem is that when the frame is > made, the current value of ns-use-native-fullscreen is copied to a variab= le > and that's only reset when the frame goes from fullscreen to windowed. I > believe the original intent was to ensure that the mode could not change > while the window was fullscreen already. > > This resets the value of fs_is_native if the frame is not already > fullscreen, which allows it to respect the value at the time of the first > fullscreen. > > Without this, the only way to get the behavior that Sean is expecting is > to set ns-use-native-fullscreen in early-init, which should not be > necessary. > > The patch looks good here. The only thing is I get this printed to the > console: > > 2024-11-20 21:11:36.609 emacs[18867:241457] ERROR: Can't have a toolbar i= n > a window with as it's borderview > > I don't think I've ever seen NextStep explicitly mentioned in macOS code > before, other than the "NS" prefix. > > I'm going to hazard a guess that the first if at the top of createToolbar > needs another test for when we're in non-native fullscreen or something. > > Native fullscreen displays the toolbar, non-native doesn't because it use= s > the borderless stylemask. Perhaps a check on the stylemask would be enoug= h > to cover both this and undecorated. > > -- > Alan Third > --0000000000005f938f06275ef8ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for trying i= t out. I saw the error as well both before and after the patch, so I didn&#= 39;t look into it. I think you're=C2=A0right though. I can try that out= later. It probably shouldn't impact when/if this patch should be insta= lled.

Are you able=C2=A0= to install this and the other or do we need someone else to sign off on it = and install them?

=

Aaron


On = Wed, Nov 20, 2024 at 1:27 PM, Alan Third <alan@idiocy.org> wro= te:

On Sun, Nov 17, 2024 at 12:00:07AM -0500, Aaron Jensen wrote:

=E2=80=8BThe bugged behavior is that `ns-use-native-fullscreen' set to = nil is not read when launching emacs.

The attached patch should fix this. The problem is that when the frame is made, the current value of ns-use-native-fullscreen is copied to a variable and that's only reset when the frame goes from fullscreen to windowed. = I believe the original intent was to ensure that the mode could not change while the window was fullscreen already.

This resets the value of fs_is_native if the frame is not already fullscreen, which allows it to respect the value at the time of the first fullscreen.

Without this, the only way to get the behavior that Sean is expecting is to set ns-use-native-fullscreen in early-init, which should not be necessary.

The patch looks good here. The only thing is I get this printed to the console:

2024-11-20 21:11:36.609 emacs[18867:241457] ERROR: Can't have a toolbar= in a window with <NSNextStepFrame: 0x7f8db350c7e0> as it's borde= rview

I don't think I've ever seen NextStep explicitly mentioned in macOS code before, other than the "NS" prefix.

I'm going to hazard a guess that the first if at the top of createToolbar needs another test for when we're in non-native fullscreen or something.

Native fullscreen displays the toolbar, non-native doesn't because it uses the borderless stylemask. Perhaps a check on the stylemask would be enough to cover both this and undecorated.

--=20
Alan Third


--0000000000005f938f06275ef8ac--