bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

Create a file named 'repro.el' containing:

    (add-to-list 'initial-frame-alist '(top . 22))
    (add-to-list 'initial-frame-alist '(left . 0))
    (add-to-list 'initial-frame-alist '(width . (text-pixels . 800)))
    (add-to-list 'initial-frame-alist '(height . (text-pixels . 800)))
    (add-to-list 'initial-frame-alist undecorated . t)

Run 'emacs -Q -l repro.el'

You should observe this:
https://screenshots-dx37.s3.amazonaws.com/20170919-080719-50kui.png

If you click anywhere in the white area to the right of the scrollbar or
below the modeline the click "passes through" emacs. That is, anything
behind it will receive the click.

On 10.12, this was not a problem. I know that 10.13 isn't officially out
yet, but this is the GM candidate and Emacs 26 is coming out soon with
this being one of the new features. It'd be great if it worked on 10.13.
I'm happy to test patches if anyone has ideas.

Thank you!


In GNU Emacs 26.0.60 (build 1, x86_64-apple-darwin17.0.0, NS appkit-1561.00 Version 10.13 (Build 17A362a))
 of 2017-09-18 built on aaron-mbpt.local
Repository revision: 066efb86660542238854a400c3c20b5cb526a3cd
Windowing system distributor 'Apple', version 10.3.1561
Recent messages:
projectile-project-root: You’re not in a project
Indenting region...done
Mark saved where search started [2 times]
Indenting region...done
Saving file /Users/aaronjensen/repro.el...
Wrote /Users/aaronjensen/repro.el
Saving file /Users/aaronjensen/repro.el...
Wrote /Users/aaronjensen/repro.el
lispy--string-dwim: Args out of range: #<buffer repro.el>, 280, 280
Quit [2 times]

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus/HEAD-066efb8/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus/HEAD-066efb8 --with-xml2
 --without-dbus --with-gnutls --with-imagemagick --with-modules
 --with-rsvg --with-ns --disable-ns-self-contained'

Configured features:
JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS
NS MODULES LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  company-mode: t
  auto-compile-mode: t
  elisp-slime-nav-mode: t
  eros-mode: t
  lispyville-mode: t
  lispy-mode: t
  nameless-mode: t
  goto-address-prog-mode: t
  bug-reference-prog-mode: t
  auto-highlight-symbol-mode: t
  highlight-numbers-mode: t
  highlight-parentheses-mode: t
  rainbow-delimiters-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-git-gutter+-mode: t
  projectile-mode: t
  recentf-mode: t
  evil-mc-mode: t
  hl-todo-mode: t
  global-spacemacs-whitespace-cleanup-mode: t
  spacemacs-whitespace-cleanup-mode: t
  ws-butler-global-mode: t
  ws-butler-mode: t
  winum-mode: t
  winner-mode: t
  volatile-highlights-mode: t
  global-vi-tilde-fringe-mode: t
  vi-tilde-fringe-mode: t
  pupo-mode: t
  purpose-mode: t
  spaceline-info-mode: t
  spaceline-helm-mode: t
  save-place-mode: t
  savehist-mode: t
  persp-mode: t
  magit-auto-revert-mode: t
  global-git-commit-mode: t
  async-bytecomp-package-mode: t
  Info-breadcrumbs-in-mode-line-mode: t
  flycheck-pos-tip-mode: t
  global-flycheck-mode: t
  flx-ido-mode: t
  eyebrowse-mode: t
  global-evil-surround-mode: t
  evil-surround-mode: t
  global-evil-search-highlight-persist: t
  evil-search-highlight-persist: t
  show-smartparens-global-mode: t
  show-smartparens-mode: t
  smartparens-mode: t
  evil-lion-mode: t
  evil-escape-mode: t
  global-anzu-mode: t
  anzu-mode: t
  eval-sexp-fu-flash-mode: t
  editorconfig-mode: t
  global-edit-server-edit-mode: t
  dtrt-indent-mode: t
  diff-auto-refine-mode: t
  counsel-mode: t
  ivy-mode: t
  clean-aindent-mode: t
  aggressive-fill-paragraph-mode: t
  hybrid-mode: t
  which-key-mode: t
  override-global-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  evil-mode: t
  evil-local-mode: t
  spacemacs-leader-override-mode: t
  global-spacemacs-leader-override-mode: t
  global-hl-line-mode: t
  xterm-mouse-mode: t
  global-auto-revert-mode: t
  shell-dirtrack-mode: t
  ido-vertical-mode: t
  global-page-break-lines-mode: t
  page-break-lines-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t
  hs-minor-mode: t

Load-path shadows:
/Users/aaronjensen/.emacs.d/elpa/26.0/org-mac-link-20170105.1723/org-mac-link hides /Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-mac-link
/Users/aaronjensen/.emacs.d/elpa/26.0/ht-20161015.1945/ht hides /Users/aaronjensen/.emacs.d/core/libs/ht
/Users/aaronjensen/.emacs.d/elpa/26.0/less-css-mode-20160930.2153/less-css-mode hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/textmodes/less-css-mode
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-stan hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-stan
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-exp hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-exp
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-J hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-J
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-eshell hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-eshell
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-emacs-lisp hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-emacs-lisp
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-gnus hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-gnus
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-css hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-css
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-lob hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-lob
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-forth hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-forth
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-macs hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-macs
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-version hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-version
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-scheme hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-scheme
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-abc hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-abc
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-C hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-C
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-capture hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-capture
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-ref hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-ref
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-clojure hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-clojure
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-mouse hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-mouse
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-ledger hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-ledger
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-ctags hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-ctags
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-entities hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-entities
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-archive hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-archive
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-screen hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-screen
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-haskell hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-haskell
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-asymptote hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-asymptote
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-mhe hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-mhe
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-table hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-table
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-keys hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-keys
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-org hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-org
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-plot hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-plot
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-awk hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-awk
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-groovy hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-groovy
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-octave hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-octave
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-faces hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-faces
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-colview hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-colview
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-R hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-R
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-timer hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-timer
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-ebnf hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-ebnf
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-mobile hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-mobile
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-fortran hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-fortran
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-shell hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-shell
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-perl hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-perl
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-sqlite hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-sqlite
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-sed hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-sed
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-list hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-list
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-ruby hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-ruby
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-eval hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-eval
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-habit hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-habit
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-clock hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-clock
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-html hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-html
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-src hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-src
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-lisp hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-lisp
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-ditaa hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-ditaa
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-pcomplete hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-pcomplete
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-lint hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-lint
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-rmail hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-rmail
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-latex hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-latex
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-sass hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-sass
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-io hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-io
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-tangle hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-tangle
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-calc hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-calc
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-java hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-java
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-icalendar hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-icalendar
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-eww hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-eww
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-md hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-md
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-beamer hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-beamer
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-element hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-element
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-protocol hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-protocol
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-mscgen hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-mscgen
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-gnuplot hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-gnuplot
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-latex hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-latex
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-id hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-id
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-man hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-man
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-feed hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-feed
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-lua hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-lua
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-table hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-table
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-ocaml hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-ocaml
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-coq hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-coq
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-picolisp hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-picolisp
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-indent hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-indent
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-lilypond hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-lilypond
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-matlab hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-matlab
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-datetree hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-datetree
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-python hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-python
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-bbdb hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-bbdb
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-makefile hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-makefile
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-agenda hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-agenda
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-dot hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-dot
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-js hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-js
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-publish hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-publish
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-inlinetask hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-inlinetask
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-org hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-org
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-core hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-core
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-compat hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-compat
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-docview hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-docview
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-odt hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-odt
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-plantuml hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-plantuml
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-ascii hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-ascii
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-loaddefs hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-loaddefs
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-w3m hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-w3m
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-bibtex hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-bibtex
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-info hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-info
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-maxima hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-maxima
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-macro hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-macro
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-sql hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-sql
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-attach hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-attach
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-processing hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-processing
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ox-texinfo hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ox-texinfo
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-irc hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-irc
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-crypt hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-crypt
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-footnote hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-footnote
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/org-install hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/org-install
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-comint hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-comint
/Users/aaronjensen/.emacs.d/elpa/26.0/org-plus-contrib-20170917/ob-shen hides /usr/local/Cellar/emacs-plus/HEAD-066efb8/share/emacs/26.0.60/lisp/org/ob-shen

Features:
(shadow sort mail-extr emacsbug sendmail smex executable misearch
multi-isearch vc-git counsel-projectile open-junk-file company-files
company-keywords company-etags company-gtags company-template
company-dabbrev-code company-dabbrev company-capf
company-insert-selected php-extras company auto-compile packed
elisp-slime-nav eros flycheck-package package-lint finder lispyville
lispy iedit iedit-lib lispy-inline avy semantic/db semantic/util-modes
semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local
cedet evil-ediff ediff-merg ediff-wind ediff-diff ediff-mult ediff-help
ediff-init ediff-util ediff edebug lispy-tags nameless goto-addr
bug-reference auto-highlight-symbol highlight-numbers parent-mode
highlight-parentheses hideshow rainbow-delimiters clojure-snippets
yasnippet elec-pair editorconfig-core editorconfig-core-handle
editorconfig-fnmatch colir git-gutter-fringe+ fringe-helper git-gutter+
projectile grep compile recentf tree-widget quiet-emacs fill-or-unfill
restore-frame-position contextual-menubar init-xclip init-flyspell
init-terminal-cursor evil-terminal-cursor-changer init-org
org-inlinetask init-magit evil-mc evil-mc-command-execute
evil-mc-command-record evil-mc-cursor-make evil-mc-region
evil-mc-cursor-state evil-mc-undo evil-mc-vars evil-mc-known-commands
evil-mc-common hl-todo ucs-utils persistent-soft list-utils font-utils
zone xterm-color spacemacs-whitespace-cleanup ws-butler winum winner
window-purpose-x imenu-list imenu ibuf-ext ibuffer ibuffer-loaddefs
volatile-highlights vi-tilde-fringe unicode-fonts tmux string-inflection
spacemacs-purpose-popwin window-purpose window-purpose-fixes
window-purpose-prefix-overload window-purpose-switch let-alist
window-purpose-layout window-purpose-core window-purpose-configuration
window-purpose-utils spaceline-config spaceline-segments spaceline
powerline powerline-separators color powerline-themes smartparens-config
smartparens-text smartparens-ruby saveplace savehist ruby-test-mode
pcre2el rxt re-builder ruby-mode smie popwin persp-mode osx-trash orgit
git-rebase magit-gh-pulls gh gh-users gh-issues gh-pulls gh-repos
gh-comments gh-gist gh-oauth gh-api logito gh-cache pcache eieio-base
gh-auth gh-url url-http tls gnutls url-auth url-gw nsm evil-magit
magit-obsolete magit-blame magit-stash magit-bisect magit-remote
magit-commit magit-sequence magit-notes magit-worktree magit-branch
magit-files magit-refs magit-status magit magit-repos magit-apply
magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert
magit-process magit-margin magit-mode magit-git magit-section
magit-popup git-commit magit-utils crm log-edit message puny dired
dired-loaddefs rfc822 mml mml-sec epa epg gnus-util rmail rmail-loaddefs
mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor
async-bytecomp async server ob-elixir ob-http ob-http-mode ob-restclient
restclient url url-proxy url-privacy url-expand url-methods url-history
url-cookie url-domsuf url-util mailcap linum ivy-hydra info+ image-mode
gh-common gh-profile s marshal flycheck-pos-tip pos-tip flycheck-flow
flycheck flx-ido eyebrowse evil-surround evil-search-highlight-persist
evil-numbers evil-lisp-state smartparens evil-lion evil-indent-plus
evil-exchange evil-escape evil-args evil-anzu anzu cider-eval-sexp-fu
eval-sexp-fu highlight editorconfig edit-server dtrt-indent
drupal/pcomplete rx docker-tramp tramp-cache diff-hl vc-dir ewoc vc
vc-dispatcher diff-mode counsel jka-compr esh-util etags xref project
swiper ivy flx delsel ivy-overlay ffap clean-aindent-mode
aggressive-fill-paragraph org-element avl-tree generator org org-macro
org-footnote org-pcomplete org-list org-faces org-entities noutline
outline org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob
ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs
org-loaddefs find-func cal-menu calendar cal-loaddefs dash adaptive-wrap
hybrid-mode exec-path-from-shell evil-evilified-state which-key
use-package diminish bind-key hydra lv cus-edit evil evil-integration
undo-tree diff evil-maps evil-commands flyspell ispell evil-jumps
evil-command-window evil-types evil-search evil-ex evil-macros
evil-repeat evil-states evil-core evil-common windmove thingatpt rect
evil-digraphs evil-vars info bind-map quelpa help-fns radix-tree
package-build mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047
rfc2045 mm-util ietf-drums mail-prsvr json map lisp-mnt hl-line xt-mouse
autorevert filenotify cl-extra disp-table wid-edit monokai-theme
finder-inf tramp tramp-compat tramp-loaddefs trampver shell pcomplete
comint ansi-color ring parse-time format-spec cus-start cus-load
init-sass init-php init-html init-evil core-configuration-layer
eieio-compat ht cl help-mode warnings package epg-config url-handlers
url-parse auth-source cl-seq password-cache url-vars eieio eieio-core
eieio-loaddefs ido-vertical-mode ido seq byte-opt bytecomp byte-compile
cconv core-spacemacs core-use-package-ext core-transient-state
core-micro-state core-toggle core-keybindings core-fonts-support
core-spacemacs-buffer core-funcs cl-macs gv core-themes-support
core-display-init core-jump core-release-management core-custom-settings
core-dotspacemacs core-command-line pcase core-debug edmacro kmacro
derived advice profiler easymenu cl-loaddefs cl-lib page-break-lines
easy-mmode subr-x time-date tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote kqueue cocoa ns lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 1265068 734696)
 (symbols 48 81888 6)
 (miscs 40 1216 1831)
 (strings 32 344691 120030)
 (string-bytes 1 9473902)
 (vectors 16 109218)
 (vector-slots 8 2592917 597953)
 (floats 8 556 2371)
 (intervals 56 6390 1671)
 (buffers 992 18))

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

It is quite possible that this is a build issue. I’m missing cocoa
specific features. I’ll try and get those going and test this again.


Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Tue, Sep 19, 2017 at 08:10:08AM -0700, Aaron Jensen wrote:
> 
> Create a file named 'repro.el' containing:
> 
>     (add-to-list 'initial-frame-alist '(top . 22))
>     (add-to-list 'initial-frame-alist '(left . 0))
>     (add-to-list 'initial-frame-alist '(width . (text-pixels . 800)))
>     (add-to-list 'initial-frame-alist '(height . (text-pixels . 800)))
>     (add-to-list 'initial-frame-alist undecorated . t)
> 
> Run 'emacs -Q -l repro.el'
> 
> You should observe this:
> https://screenshots-dx37.s3.amazonaws.com/20170919-080719-50kui.png
> 
> If you click anywhere in the white area to the right of the scrollbar or
> below the modeline the click "passes through" emacs. That is, anything
> behind it will receive the click.
> 
> On 10.12, this was not a problem. I know that 10.13 isn't officially out
> yet, but this is the GM candidate and Emacs 26 is coming out soon with
> this being one of the new features. It'd be great if it worked on 10.13.
> I'm happy to test patches if anyone has ideas.

I can actually reproduce on 10.12. The last line should be:

   (add-to-list ’initial-frame-alist ’(undecorated . t))
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On September 19, 2017 at 2:34:18 PM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> On Tue, Sep 19, 2017 at 08:10:08AM -0700, Aaron Jensen wrote:
> >
> > Create a file named 'repro.el' containing:
> >
> > (add-to-list 'initial-frame-alist '(top . 22))
> > (add-to-list 'initial-frame-alist '(left . 0))
> > (add-to-list 'initial-frame-alist '(width . (text-pixels . 800)))
> > (add-to-list 'initial-frame-alist '(height . (text-pixels . 800)))
> > (add-to-list 'initial-frame-alist undecorated . t)
> >
> > Run 'emacs -Q -l repro.el'
> >
> > You should observe this:
> > https://screenshots-dx37.s3.amazonaws.com/20170919-080719-50kui.png
> >
> > If you click anywhere in the white area to the right of the scrollbar or
> > below the modeline the click "passes through" emacs. That is, anything
> > behind it will receive the click.
> >
> > On 10.12, this was not a problem. I know that 10.13 isn't officially out
> > yet, but this is the GM candidate and Emacs 26 is coming out soon with
> > this being one of the new features. It'd be great if it worked on 10.13.
> > I'm happy to test patches if anyone has ideas.
>
> I can actually reproduce on 10.12. The last line should be:
>
> (add-to-list ’initial-frame-alist ’(undecorated . t))


Oops, yeah, the repro was wrong, I typed that line by hand instead of
copy/pasting. Sorry about that. On 10.12, with the correct line, do
you reproduce it still? Or was the bad line causing the issue for you?

If you can reproduce on 10.12, it may be a recent regression because I
hadn’t ever noticed it and I’ve been using it on 10.12 for a month or
two now at least.

Aaron

>
> --
> Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On Tue, Sep 19, 2017 at 2:44 PM, Aaron Jensen <aaronjensen@gmail.com> wrote:
> Oops, yeah, the repro was wrong, I typed that line by hand instead of copy/pasting. Sorry about that. On 10.12, with the correct line, do you reproduce it still? Or was the bad line causing the issue for you?
>
> If you can reproduce on 10.12, it may be a recent regression because I hadn’t ever noticed it and I’ve been using it on 10.12 for a month or two now at least.

Some additional information:

A bug does reproduce on 10.12 for me as well, but not exactly the
same. On 10.12, it does look like the screenshot I originally
included, but does not have the mouse clicking issue. I'm not sure
why. It only does this if on the initial frame with that repro file.

The difference between the behavior on 10.12 and 10.13, however, is
that on 10.13, the area outside of the scrollbar/modeline does not
receive mouse events. If you click on that area of the window, the
click passes through to the window behind Emacs. On 10.12, it properly
receives events. This does seem to work fine on frames created anew
with undecorated as long as the below patch is applied.

Also, there looks like there was an issue with creating a new
undecorated frame, it was not resizable but should be:

---------------

diff --git a/src/nsterm.m b/src/nsterm.m
index a41d6be204..b433092d24 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7207,9 +7207,9 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f

   win = [[EmacsWindow alloc]
             initWithContentRect: r
-                      styleMask: (FRAME_UNDECORATED (f)
+                      styleMask: ((FRAME_UNDECORATED (f)
                                   ? FRAME_UNDECORATED_FLAGS
-                                  : FRAME_DECORATED_FLAGS
+                                  : FRAME_DECORATED_FLAGS)
 #ifdef NS_IMPL_COCOA
                                   | NSWindowStyleMaskResizable
                                   | NSWindowStyleMaskMiniaturizable

----------------


Also, I'm getting occasional build failures on my 10.12 machine on
emacs-26. Any idea what would cause this:

ln -f emacs bootstrap-emacs

make -C ../nextstep all

rm -rf /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

rm -rf /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

../build-aux/install-sh -c -d
/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

make -C ../src emacs

../build-aux/install-sh -c -d
/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app

mkdir: /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app:
File exists

( cd ./Cocoa/Emacs.base ; tar cfh - . ) | \

          ( cd /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app
; umask 022; tar xf - )

( cd ./Cocoa/Emacs.base ; tar cfh - . ) | \

          ( cd /private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app
; umask 022; tar xf - )

./Contents/PkgInfo: Can't create 'Contents/PkgInfo'

./Contents/Resources/Credits.html: Can't create
'Contents/Resources/Credits.html'

./Contents/Resources/Emacs.icns: Can't create 'Contents/Resources/Emacs.icns'

./Contents/Resources/English.lproj/InfoPlist.strings: Can't create
'Contents/Resources/English.lproj/InfoPlist.strings'

tar: Error exit delayed from previous errors.

tar: Error exit delayed from previous errors.

make[2]: *** [/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app/Contents/Info.plist]
Error 1

make[2]: *** Waiting for unfinished jobs....

make[2]: *** [/private/tmp/emacs-plus-20170923-30180-1jee6x3/nextstep/Emacs.app]
Error 1

make[3]: Circular bootstrap-emacs <- temacs dependency dropped.

make -C ../admin/unidata all EMACS="../../src/bootstrap-emacs"

make -C ../admin/charsets all

make -C ../admin/unidata charscript.el

make -C ../admin/unidata all EMACS="../../src/bootstrap-emacs"

make[4]: Nothing to be done for `charscript.el'.

make -C ../admin/charsets cp51932.el

make[4]: Nothing to be done for `all'.

make[4]: Nothing to be done for `all'.

make -C ../admin/charsets eucjp-ms.el

make[4]: Nothing to be done for `cp51932.el'.

make[4]: Nothing to be done for `eucjp-ms.el'.

make[4]: Nothing to be done for `all'.

make[1]: *** [ns-app] Error 2

make: *** [src] Error 2

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Sat, Sep 23, 2017 at 07:31:50AM -0700, Aaron Jensen wrote:
> On Tue, Sep 19, 2017 at 2:44 PM, Aaron Jensen <aaronjensen@gmail.com> wrote:
> > If you can reproduce on 10.12, it may be a recent regression
> > because I hadn’t ever noticed it and I’ve been using it on 10.12
> > for a month or two now at least.

I’ve fixed it, and I doubt it’s a regression because I can’t see how
it could have ever worked.

When creating a frame, sometimes the toolbar takes a while to draw and
we have to wait for it before we can do things like resize windows (or
else we get an annoying series of window resizes).

(It’s just occurred to me, while typing this out, that the whole way
we’re handling this is just broken. It should probably be completely
redone.)

Undecorated frames, like fullscreen windows, don’t have toolbars, so
the code always sees it as zero size and therefore never stops waiting
for it to draw.

This means it will never resize.

Of course, the actual NSWindow *does* resize, it’s just Emacs that
doesn’t. This is clearly broken.

I’ve added a check for whether the window is undecorated, the same as
we check if it’s fullscreen.

> Also, there looks like there was an issue with creating a new
> undecorated frame, it was not resizable but should be:

Although this maybe isn’t actually a bug (and undecorated windows
being resizable is), I’ve made it consistent by doing what you
suggest.

> Also, I'm getting occasional build failures on my 10.12 machine on
> emacs-26. Any idea what would cause this:
> 
<snip>
> ./Contents/PkgInfo: Can't create 'Contents/PkgInfo'
> 
> ./Contents/Resources/Credits.html: Can't create
> 'Contents/Resources/Credits.html'
> 
> ./Contents/Resources/Emacs.icns: Can't create 'Contents/Resources/Emacs.icns'
> 
> ./Contents/Resources/English.lproj/InfoPlist.strings: Can't create
> 'Contents/Resources/English.lproj/InfoPlist.strings'

Is it a permissions issue on your Emacs.app directory?
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On September 23, 2017 at 12:11:48 PM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> On Sat, Sep 23, 2017 at 07:31:50AM -0700, Aaron Jensen wrote:
> > On Tue, Sep 19, 2017 at 2:44 PM, Aaron Jensen wrote:
> > > If you can reproduce on 10.12, it may be a recent regression
> > > because I hadn’t ever noticed it and I’ve been using it on 10.12
> > > for a month or two now at least.
>
> I’ve fixed it, and I doubt it’s a regression because I can’t see how
> it could have ever worked.

I can confirm that this fixed the visual issue, but, unfortunately, it
did not fix the mouse event issue on macOS 10.13. Mouse clicks still
pass right through the frame. In order to get mouse events to work, I
have to:

1. Turn undecorated off
2. Resize
3. Turn undecorated on

Any resize after undecorated is turned on leaves the clickable area “constant”.

I don’t know if it’s any help, but https://github.com/gnachman/iTerm2
(GPL) implements a no-title-bar mode that seems to work perfectly.
It’s resizable, respects mouse events, starts w/o a title bar/borders,
etc.

> > Also, there looks like there was an issue with creating a new
> > undecorated frame, it was not resizable but should be:
>
> Although this maybe isn’t actually a bug (and undecorated windows
> being resizable is), I’ve made it consistent by doing what you
> suggest.

For my usage I’d prefer they were resizable. Thanks!

> > Also, I'm getting occasional build failures on my 10.12 machine on
> > emacs-26. Any idea what would cause this:
> >
>
> > ./Contents/PkgInfo: Can't create 'Contents/PkgInfo'
> >
> > ./Contents/Resources/Credits.html: Can't create
> > 'Contents/Resources/Credits.html'
> >
> > ./Contents/Resources/Emacs.icns: Can't create 'Contents/Resources/Emacs.icns'
> >
> > ./Contents/Resources/English.lproj/InfoPlist.strings: Can't create
> > 'Contents/Resources/English.lproj/InfoPlist.strings'
>
> Is it a permissions issue on your Emacs.app directory?

I’m not sure. I cleaned up a few build folders and rebooted and it
built again. I was building with homebrew on that machine, so I’m not
sure if it was doing something strange. I hadn’t ever seen that until
today.

Thanks,

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Sat, Sep 23, 2017 at 02:35:53PM -0700, Aaron Jensen wrote:
> 
> I can confirm that this fixed the visual issue, but, unfortunately, it
> did not fix the mouse event issue on macOS 10.13. Mouse clicks still
> pass right through the frame. In order to get mouse events to work, I
> have to:
> 
> 1. Turn undecorated off
> 2. Resize
> 3. Turn undecorated on
> 
> Any resize after undecorated is turned on leaves the clickable area “constant”.

If you resize using lisp does it work?

eg. (set-frame-parameter nil ’width 100)

(I’m assuming not, but thought it best to check.)

I’ve had a look through the 10.13 release notes and the only thing
that looks like it could be related is in the use of ’layers’, but I
don’t think we’re using them...

-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On September 24, 2017 at 4:27:27 AM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> If you resize using lisp does it work?
>
> eg. (set-frame-parameter nil ’width 100)
>
> (I’m assuming not, but thought it best to check.)

No, it doesn’t. This does is the only thing that does:

(progn
  (set-frame-parameter nil 'undecorated nil)
  (set-frame-parameter nil 'width 100)
  (set-frame-parameter nil 'undecorated t))


>
> I’ve had a look through the 10.13 release notes and the only thing
> that looks like it could be related is in the use of ’layers’, but I
> don’t think we’re using them…

Yeah, I glanced it over too and didn’t see anything. I don’t know
enough about the macOS SDK to even know how a part of the window
wouldn’t be clickable. If it weren’t for iTerm2, I’d think that they
somehow broke borderless windows entirely, but iTerm2 seems to resize
properly…

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Sun, Sep 24, 2017 at 08:43:52AM -0700, Aaron Jensen wrote:
> On September 24, 2017 at 4:27:27 AM, Alan Third
> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> 
> > I’ve had a look through the 10.13 release notes and the only thing
> > that looks like it could be related is in the use of ’layers’, but I
> > don’t think we’re using them…
> 
> Yeah, I glanced it over too and didn’t see anything. I don’t know
> enough about the macOS SDK to even know how a part of the window
> wouldn’t be clickable. 

Normally a window with transparent sections will ignore mouse events
in the transparent sections. Setting ignoresMouseEvents to NO should
stop that from happening. This shouldn’t be our problem since the
window isn’t transparent, but it’s the only thing I’ve come across
that sounds like it.

So, can you try putting

    [win setIgnoresMouseEvents:NO];

in initFrameFromEmacs in nsterm.m, somewhere around line 7222. It
should be after ‘win’ is set, but doesn’t really matter too much
where.

> If it weren’t for iTerm2, I’d think that they somehow broke
> borderless windows entirely, but iTerm2 seems to resize properly…

Yeah, and similarly I’d expect to see some discussion online about it
if it was an apple bug. It’s probably the way we’re doing something,
our code can be a bit unusual at times.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On September 24, 2017 at 2:05:52 PM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> On Sun, Sep 24, 2017 at 08:43:52AM -0700, Aaron Jensen wrote:
> So, can you try putting
>
> [win setIgnoresMouseEvents:NO];
>
> in initFrameFromEmacs in nsterm.m, somewhere around line 7222. It
> should be after ‘win’ is set, but doesn’t really matter too much
> where.

That didn’t help.

> > If it weren’t for iTerm2, I’d think that they somehow broke
> > borderless windows entirely, but iTerm2 seems to resize properly…
>
> Yeah, and similarly I’d expect to see some discussion online about it
> if it was an apple bug. It’s probably the way we’re doing something,
> our code can be a bit unusual at times.

I may have something. If the initial frame is created with undecorated
set from the beginning, it works. Likewise if you create a new frame
after:

(add-to-list 'default-frame-alist '(undecorated . t))

So, the problem may have something to do with transitioning from a
decorated frame to an undecorated frame. I remember seeing something
in the iterm2 code about recreating windows in certain instances, but
I don’t remember where I saw that.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Sun, Sep 24, 2017 at 05:39:05PM -0700, Aaron Jensen wrote:
> 
> I may have something. If the initial frame is created with undecorated
> set from the beginning, it works. Likewise if you create a new frame
> after:
> 
> (add-to-list 'default-frame-alist '(undecorated . t))
> 
> So, the problem may have something to do with transitioning from a
> decorated frame to an undecorated frame. I remember seeing something
> in the iterm2 code about recreating windows in certain instances, but
> I don’t remember where I saw that.

I’m beginning to lean towards this being a bug in the 10.13
pre‐release, given the lack of evidence that this is intentional. Up
to 10.6 you couldn’t change a window’s styleMask, but they now provide
a function to do it, setStyleMask, and I don’t see any sign that
they’re getting rid of this capability.

I suppose the sensible thing to do would be to raise a bug report with
Apple and see if they say anything, or wait for the next release and
see if it’s still a problem.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On September 25, 2017 at 3:13:23 AM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> On Sun, Sep 24, 2017 at 05:39:05PM -0700, Aaron Jensen wrote:
> >
> > I may have something. If the initial frame is created with undecorated
> > set from the beginning, it works. Likewise if you create a new frame
> > after:
> >
> > (add-to-list 'default-frame-alist '(undecorated . t))
> >
> > So, the problem may have something to do with transitioning from a
> > decorated frame to an undecorated frame. I remember seeing something
> > in the iterm2 code about recreating windows in certain instances, but
> > I don’t remember where I saw that.
>
> I’m beginning to lean towards this being a bug in the 10.13
> pre‐release, given the lack of evidence that this is intentional.

Looks like it reproduces easily:
https://github.com/aaronjensen/macOS-10.13-borderless-bug-repro

> I suppose the sensible thing to do would be to raise a bug report with
> Apple and see if they say anything, or wait for the next release and
> see if it’s still a problem.

Ok, I’ll do this.

Thanks,

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Mon, Sep 25, 2017 at 08:18:34AM -0700, Aaron Jensen wrote:
> On September 25, 2017 at 3:13:23 AM, Alan Third
> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> 
> > On Sun, Sep 24, 2017 at 05:39:05PM -0700, Aaron Jensen wrote:
> > >
> > > I may have something. If the initial frame is created with undecorated
> > > set from the beginning, it works. Likewise if you create a new frame
> > > after:
> > >
> > > (add-to-list 'default-frame-alist '(undecorated . t))
> > >
> > > So, the problem may have something to do with transitioning from a
> > > decorated frame to an undecorated frame. I remember seeing something
> > > in the iterm2 code about recreating windows in certain instances, but
> > > I don’t remember where I saw that.
> >
> > I’m beginning to lean towards this being a bug in the 10.13
> > pre‐release, given the lack of evidence that this is intentional.
> 
> Looks like it reproduces easily:
> https://github.com/aaronjensen/macOS-10.13-borderless-bug-repro

Given I don’t have Xcode installed, is there a way for me to build
this to confirm its behaviour on 10.12? (or have you already done
that?)

> > I suppose the sensible thing to do would be to raise a bug report with
> > Apple and see if they say anything, or wait for the next release and
> > see if it’s still a problem.
> 
> Ok, I’ll do this.

Thank you.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On Mon, Sep 25, 2017 at 9:33 AM, Alan Third <alan@idiocy.org> wrote:
> On Mon, Sep 25, 2017 at 08:18:34AM -0700, Aaron Jensen wrote:
>> Looks like it reproduces easily:
>> https://github.com/aaronjensen/macOS-10.13-borderless-bug-repro
>
> Given I don’t have Xcode installed, is there a way for me to build
> this to confirm its behaviour on 10.12? (or have you already done
> that?)

I was able to build on 10.12 and it does not repro there. I'm not sure
how to build w/o xcode, I've not done much macOS dev work.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

Hi Alan,

I was able to get some information from the author of iTerm2. The
problem is definitely that Emacs changes the window style to
resizable. If the NSWindow is recreated as resizable then it works
fine.

So that leaves a couple of questions:

1. Is it possible to create the first frame with undecorated set?
2. Would it be difficult to recreate the NSWindow housing the frame
when that frame parameter is changed?

Thanks,

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Sat, Oct 14, 2017 at 02:47:41PM -0700, Aaron Jensen wrote:
> I was able to get some information from the author of iTerm2. The
> problem is definitely that Emacs changes the window style to
> resizable. If the NSWindow is recreated as resizable then it works
> fine.

I don’t understand, we’re not changing the resizable attribute.

> So that leaves a couple of questions:
> 
> 1. Is it possible to create the first frame with undecorated set?

So create the window undecorated, then immediately switch it to
decorated?

> 2. Would it be difficult to recreate the NSWindow housing the frame
> when that frame parameter is changed?

I’m not sure. I’ll have to go and have a look.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On October 16, 2017 at 3:01:14 AM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> On Sat, Oct 14, 2017 at 02:47:41PM -0700, Aaron Jensen wrote:
> > I was able to get some information from the author of iTerm2. The
> > problem is definitely that Emacs changes the window style to
> > resizable. If the NSWindow is recreated as resizable then it works
> > fine.
>
> I don’t understand, we’re not changing the resizable attribute.

I’m sorry, I miswrote. I meant that the borderless attribute is changed.

> > So that leaves a couple of questions:
> >
> > 1. Is it possible to create the first frame with undecorated set?
>
> So create the window undecorated, then immediately switch it to
> decorated?

What I meant was how do I start emacs while telling it to create its
initial frame undecorated if that’s my desire. Setting
`initial-display-alist` to include `(undecorated . t)` in `init.el`
seems to be insufficient, because the frame appears to be created
prior to `init.el` being eval’d.

> > 2. Would it be difficult to recreate the NSWindow housing the frame
> > when that frame parameter is changed?
>
> I’m not sure. I’ll have to go and have a look.

Thanks.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

On Mon, Oct 16, 2017 at 08:49:07AM -0400, Aaron Jensen wrote:
> On October 16, 2017 at 3:01:14 AM, Alan Third
> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> 
> > > 1. Is it possible to create the first frame with undecorated set?
> >
> > So create the window undecorated, then immediately switch it to
> > decorated?
> 
> What I meant was how do I start emacs while telling it to create its
> initial frame undecorated if that’s my desire. Setting
> `initial-display-alist` to include `(undecorated . t)` in `init.el`
> seems to be insufficient, because the frame appears to be created
> prior to `init.el` being eval’d.

I don’t know for sure, but suspect the answer is that you can’t do
that.

> > > 2. Would it be difficult to recreate the NSWindow housing the frame
> > > when that frame parameter is changed?
> >
> > I’m not sure. I’ll have to go and have a look.

Before I try coding this up, can you try a couple of things for me?

It could be that changing individual bits of styleMask is the wrong
way to do things, so can you please try the attached patch?

If it doesn’t work can you change FRAME_UNDECORATED_FLAGS back to:

    #define FRAME_UNDECORATED_FLAGS NSWindowStyleMaskBorderless

and see if you can resize the frame using lisp?

-- 
Alan Third

[-- Attachment #2: undecorated.patch --]
[-- Type: text/plain, Size: 1824 bytes --]

diff --git a/src/nsterm.m b/src/nsterm.m
index 0b43c04c0b..e6f650467d 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -429,15 +429,13 @@ - (NSColor *)colorUsingDefaultColorSpace
 
    These flags will be OR'd or XOR'd with the NSWindow's styleMask
    property depending on what we're doing. */
-#ifdef NS_IMPL_COCOA
-#define FRAME_DECORATED_FLAGS NSWindowStyleMaskTitled
-#else
 #define FRAME_DECORATED_FLAGS (NSWindowStyleMaskTitled              \
                                | NSWindowStyleMaskResizable         \
                                | NSWindowStyleMaskMiniaturizable    \
                                | NSWindowStyleMaskClosable)
-#endif
-#define FRAME_UNDECORATED_FLAGS NSWindowStyleMaskBorderless
+#define FRAME_UNDECORATED_FLAGS (NSWindowStyleMaskResizable         \
+                               | NSWindowStyleMaskMiniaturizable    \
+                               | NSWindowStyleMaskClosable)
 
 /* TODO: get rid of need for these forward declarations */
 static void ns_condemn_scroll_bars (struct frame *f);
@@ -1883,8 +1881,7 @@ -(void)remove
       if (NILP (new_value))
         {
           FRAME_UNDECORATED (f) = false;
-          [window setStyleMask: ((window.styleMask | FRAME_DECORATED_FLAGS)
-                                  ^ FRAME_UNDECORATED_FLAGS)];
+          [window setStyleMask: FRAME_DECORATED_FLAGS];
 
           [view createToolbar: f];
         }
@@ -1894,8 +1891,7 @@ -(void)remove
           /* Do I need to release the toolbar here? */
 
           FRAME_UNDECORATED (f) = true;
-          [window setStyleMask: ((window.styleMask | FRAME_UNDECORATED_FLAGS)
-                                 ^ FRAME_DECORATED_FLAGS)];
+          [window setStyleMask: FRAME_UNDECORATED_FLAGS];
         }
 
       /* At this point it seems we don't have an active NSResponder,

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On October 16, 2017 at 1:46:36 PM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> I don’t know for sure, but suspect the answer is that you can’t do
> that.

Ok, too bad.

> > > > 2. Would it be difficult to recreate the NSWindow housing the frame
> > > > when that frame parameter is changed?
> > >
> > > I’m not sure. I’ll have to go and have a look.
>
> Before I try coding this up, can you try a couple of things for me?
>
> It could be that changing individual bits of styleMask is the wrong
> way to do things, so can you please try the attached patch?

For some reason the patch didn’t apply, but I applied it manually. It
did not change the problem.

> If it doesn’t work can you change FRAME_UNDECORATED_FLAGS back to:
>
> #define FRAME_UNDECORATED_FLAGS NSWindowStyleMaskBorderless
>
> and see if you can resize the frame using lisp?

I can resize the frame with set-frame-size when using only borderless
and it does not break the mouse events. I can’t resize with the mouse
in this case, however and adding the resizable style back puts me
right back in the broken situation.

According to George Nachman (author of iTerm2):

> I'd say to file a radar but borderless windows are deprecated so I’d
> only expect them to get worse. I guess Apple would prefer that you
> use NSFullSizeContentViewWindowMask. Plus then you get a shadow and
> rounded corners.

Unfortunately, it behaves the same as borderless when there’s no title
(bug included). As far as I can tell, the only way to get a resizable
borderless window is to create it as such from the beginning :(

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Mon, Oct 16, 2017 at 07:50:50PM -0700, Aaron Jensen wrote:
> On October 16, 2017 at 1:46:36 PM, Alan Third
> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> 
> > If it doesn’t work can you change FRAME_UNDECORATED_FLAGS back to:
> >
> > #define FRAME_UNDECORATED_FLAGS NSWindowStyleMaskBorderless
> >
> > and see if you can resize the frame using lisp?
> 
> I can resize the frame with set-frame-size when using only borderless
> and it does not break the mouse events. I can’t resize with the mouse
> in this case, however and adding the resizable style back puts me
> right back in the broken situation.

This is fine, we can live with this.

When you create an undecorated frame you’ll just have to also set the
frame parameter drag-internal-border to t. Resizing is a bit flickery,
but it should work as it’s being done through emacs lisp.

I didn’t realise that resizing through lisp worked when the resize
mask was off, I thought it was completely broken.

> According to George Nachman (author of iTerm2):
> 
> > I'd say to file a radar but borderless windows are deprecated so I’d
> > only expect them to get worse. I guess Apple would prefer that you
> > use NSFullSizeContentViewWindowMask. Plus then you get a shadow and
> > rounded corners.
> 
> Unfortunately, it behaves the same as borderless when there’s no title
> (bug included). As far as I can tell, the only way to get a resizable
> borderless window is to create it as such from the beginning :(

There are other things you can do, like making the title invisible and
turning off the buttons. I’ve not done much experimenting with it
since it doesn’t work on older macOS versions. It might be worth my
while putting in the effort, though.

I didn’t know that borderless windows were deprecated either. I don’t
remember seeing that mentioned in the documentation. Good to know
though.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On October 17, 2017 at 1:59:03 AM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> > I can resize the frame with set-frame-size when using only borderless
> > and it does not break the mouse events. I can’t resize with the mouse
> > in this case, however and adding the resizable style back puts me
> > right back in the broken situation.
>
> This is fine, we can live with this.
>
> When you create an undecorated frame you’ll just have to also set the
> frame parameter drag-internal-border to t. Resizing is a bit flickery,
> but it should work as it’s being done through emacs lisp.

I didn’t know about this. That said, it’s not ideal. I don’t think I’d
actually use it because it prevents other applications (like
divvy/hammerspoon/etc) from resizing the frame. I do this w/ keyboard
shortcuts all the time and losing that is a non-starter. It also
doesn’t seem to allow diagonal resizing, which isn’t a huge deal, but
is unfortunate.

If you’re up for coding it, I’d definitely be happy to test out the
recreate-the-frame option.

> There are other things you can do, like making the title invisible and
> turning off the buttons. I’ve not done much experimenting with it
> since it doesn’t work on older macOS versions. It might be worth my
> while putting in the effort, though.

He linked me to this article, which may help:
http://robin.github.io/cocoa/mac/2016/03/28/title-bar-and-toolbar-showcase/

> I didn’t know that borderless windows were deprecated either. I don’t
> remember seeing that mentioned in the documentation. Good to know
> though.

Yeah, I don’t know where he saw that.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

By the way, I just saw dc8812829b81540d385eaa5577fa31397a8181d3. Is
that missing changes to x_set_undecorated?

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Wed, Oct 18, 2017 at 09:12:07AM -0700, Aaron Jensen wrote:
> By the way, I just saw dc8812829b81540d385eaa5577fa31397a8181d3. Is
> that missing changes to x_set_undecorated?

No, since it seemed to make no difference whether we were XORing out
the bits we didn’t want or just replacing them completely, I decided
to leave it as is.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Wed, Oct 18, 2017 at 09:08:52AM -0700, Aaron Jensen wrote:
> On October 17, 2017 at 1:59:03 AM, Alan Third
> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> 
> > When you create an undecorated frame you’ll just have to also set the
> > frame parameter drag-internal-border to t. Resizing is a bit flickery,
> > but it should work as it’s being done through emacs lisp.
> 
> I didn’t know about this. That said, it’s not ideal. I don’t think I’d
> actually use it because it prevents other applications (like
> divvy/hammerspoon/etc) from resizing the frame. I do this w/ keyboard
> shortcuts all the time and losing that is a non-starter. It also
> doesn’t seem to allow diagonal resizing, which isn’t a huge deal, but
> is unfortunate.

Hmm, I take it these are not part of Emacs? The diagonal resizing
should work, we just don’t have diagonal arrows because the ones macOS
uses are undocumented.

> If you’re up for coding it, I’d definitely be happy to test out the
> recreate-the-frame option.

I’d rather not, to be honest. The below option seems better where it’s
supported, especially if borderless windows are deprecated.

> > There are other things you can do, like making the title invisible and
> > turning off the buttons. I’ve not done much experimenting with it
> > since it doesn’t work on older macOS versions. It might be worth my
> > while putting in the effort, though.
> 
> He linked me to this article, which may help:
> http://robin.github.io/cocoa/mac/2016/03/28/title-bar-and-toolbar-showcase/

I’ve seen this, and actually gave NSWindowStyleMaskFullSizeContentView
a go, but I get a pile of errors and input breaks. I think it’s maybe
something to do with layers, which I’ve yet to read up on.

-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On October 18, 2017 at 12:50:38 PM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> Hmm, I take it these are not part of Emacs?

No, they’re 3rd party applications. I use them more or less as
lightweight window managers.

> The diagonal resizing
> should work, we just don’t have diagonal arrows because the ones macOS
> uses are undocumented.

I couldn’t get it to work on any corner if I remember correctly.

> > If you’re up for coding it, I’d definitely be happy to test out the
> > recreate-the-frame option.
>
> I’d rather not, to be honest. The below option seems better where it’s
> supported, especially if borderless windows are deprecated.

Yeah, I’m yet to corroborate the deprecation, but I hear you. It
probably just boils down to undecorated windows not being useful for
me in the case I was using them for before. The transparent title bar
isn’t so bad—I have a large enough monitor and I’m not going to throw
a fit just to get rid of the titlebar :)

That said, it is also too bad that this represents a behavioral
regression for frames created after the first one as those worked
fine. It was only the first that had the issue. Would it be a crazy
thing to create borderless frames as resizable but remove that flag if
they become borderless after creation?

This actually has me wondering if it would be a “reasonable” thing to
simply open a new frame immediately on startup and close the original
frame if I really wanted the borderless.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

Alan Third <alan@idiocy.org> writes:

> On Wed, Oct 18, 2017 at 09:08:52AM -0700, Aaron Jensen wrote:
>> On October 17, 2017 at 1:59:03 AM, Alan Third
>> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
>> 
>> > When you create an undecorated frame you’ll just have to also set the
>> > frame parameter drag-internal-border to t. Resizing is a bit flickery,
>> > but it should work as it’s being done through emacs lisp.
>> 
>> I didn’t know about this. That said, it’s not ideal. I don’t think I’d
>> actually use it because it prevents other applications (like
>> divvy/hammerspoon/etc) from resizing the frame. I do this w/ keyboard
>> shortcuts all the time and losing that is a non-starter. It also
>> doesn’t seem to allow diagonal resizing, which isn’t a huge deal, but
>> is unfortunate.
>
> Hmm, I take it these are not part of Emacs? The diagonal resizing
> should work, we just don’t have diagonal arrows because the ones macOS
> uses are undocumented.
>
>> If you’re up for coding it, I’d definitely be happy to test out the
>> recreate-the-frame option.
>
> I’d rather not, to be honest. The below option seems better where it’s
> supported, especially if borderless windows are deprecated.

Hi Aaron,

if you're still interested in this I've got a preliminary implementation
of the recreate-the-frame setup in the scratch/ns/refactor branch.

I've not changed the flags to make borderless frames resizable, but it
should be a simple change.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On Sun, Jul 25, 2021 at 7:17 AM Alan Third <alan@idiocy.org> wrote:
>
> Hi Aaron,
>
> if you're still interested in this I've got a preliminary implementation
> of the recreate-the-frame setup in the scratch/ns/refactor branch.
>
> I've not changed the flags to make borderless frames resizable, but it
> should be a simple change.

Thanks, I'm sticking with a title bar for now, but maybe I'll give it
a shot some time.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

Aaron Jensen <aaronjensen@gmail.com> writes:

> On Sun, Jul 25, 2021 at 7:17 AM Alan Third <alan@idiocy.org> wrote:
>>
>> Hi Aaron,
>>
>> if you're still interested in this I've got a preliminary implementation
>> of the recreate-the-frame setup in the scratch/ns/refactor branch.
>>
>> I've not changed the flags to make borderless frames resizable, but it
>> should be a simple change.
>
> Thanks, I'm sticking with a title bar for now, but maybe I'll give it
> a shot some time.

I've pushed this change now and will mark this as done.
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On Wed, Dec 22, 2021 at 3:52 PM Alan Third <alan@idiocy.org> wrote:
>
> Aaron Jensen <aaronjensen@gmail.com> writes:
>
> > On Sun, Jul 25, 2021 at 7:17 AM Alan Third <alan@idiocy.org> wrote:
> >>
> >> Hi Aaron,
> >>
> >> if you're still interested in this I've got a preliminary implementation
> >> of the recreate-the-frame setup in the scratch/ns/refactor branch.
> >>
> >> I've not changed the flags to make borderless frames resizable, but it
> >> should be a simple change.
> >
> > Thanks, I'm sticking with a title bar for now, but maybe I'll give it
> > a shot some time.
>
> I've pushed this change now and will mark this as done.

Thanks. I'm out of context on this change now, but it looks like now
that this change has merged all undecorated frames have a shadow,
which I guess is what macOS gives resizable frames. I don't know if I
mind it yet, but is there a frame-parameter that would turn that off?

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Thu, Dec 23, 2021 at 10:20:40AM -0500, Aaron Jensen wrote:
> On Wed, Dec 22, 2021 at 3:52 PM Alan Third <alan@idiocy.org> wrote:
> >
> > Aaron Jensen <aaronjensen@gmail.com> writes:
> >
> > > On Sun, Jul 25, 2021 at 7:17 AM Alan Third <alan@idiocy.org> wrote:
> > >>
> > >> Hi Aaron,
> > >>
> > >> if you're still interested in this I've got a preliminary implementation
> > >> of the recreate-the-frame setup in the scratch/ns/refactor branch.
> > >>
> > >> I've not changed the flags to make borderless frames resizable, but it
> > >> should be a simple change.
> > >
> > > Thanks, I'm sticking with a title bar for now, but maybe I'll give it
> > > a shot some time.
> >
> > I've pushed this change now and will mark this as done.
> 
> Thanks. I'm out of context on this change now, but it looks like now
> that this change has merged all undecorated frames have a shadow,
> which I guess is what macOS gives resizable frames. I don't know if I
> mind it yet, but is there a frame-parameter that would turn that off?

Looks like we can set hasShadow to NO. Maybe we want to do that to
undecorated child frames, or something?
-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On Thu, Dec 23, 2021 at 11:09 AM Alan Third <alan@idiocy.org> wrote:
>
> On Thu, Dec 23, 2021 at 10:20:40AM -0500, Aaron Jensen wrote:
> > On Wed, Dec 22, 2021 at 3:52 PM Alan Third <alan@idiocy.org> wrote:
> > >
> > > Aaron Jensen <aaronjensen@gmail.com> writes:
> > >
> > > > On Sun, Jul 25, 2021 at 7:17 AM Alan Third <alan@idiocy.org> wrote:
> > > >>
> > > >> Hi Aaron,
> > > >>
> > > >> if you're still interested in this I've got a preliminary implementation
> > > >> of the recreate-the-frame setup in the scratch/ns/refactor branch.
> > > >>
> > > >> I've not changed the flags to make borderless frames resizable, but it
> > > >> should be a simple change.
> > > >
> > > > Thanks, I'm sticking with a title bar for now, but maybe I'll give it
> > > > a shot some time.
> > >
> > > I've pushed this change now and will mark this as done.
> >
> > Thanks. I'm out of context on this change now, but it looks like now
> > that this change has merged all undecorated frames have a shadow,
> > which I guess is what macOS gives resizable frames. I don't know if I
> > mind it yet, but is there a frame-parameter that would turn that off?
>
> Looks like we can set hasShadow to NO. Maybe we want to do that to
> undecorated child frames, or something?

That's probably reasonable. I like it for emacs-mini-frame, but having
the shadows on company posframe is silly, so I'm fine not having it
for anything.

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Thu, Dec 23, 2021 at 01:19:34PM -0500, Aaron Jensen wrote:
> On Thu, Dec 23, 2021 at 11:09 AM Alan Third <alan@idiocy.org> wrote:
> > Looks like we can set hasShadow to NO. Maybe we want to do that to
> > undecorated child frames, or something?
> 
> That's probably reasonable. I like it for emacs-mini-frame, but having
> the shadows on company posframe is silly, so I'm fine not having it
> for anything.

Please try the attached, it's completely untested.
-- 
Alan Third

[-- Attachment #2: 0001-Remove-macOS-drop-shadows-on-some-frames-bug-28512.patch --]
[-- Type: text/x-diff, Size: 1019 bytes --]

From 0b9c068ae1186b0831495d82f5a7199da5f8401a Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Tue, 28 Dec 2021 11:36:46 +0000
Subject: [PATCH] Remove macOS drop-shadows on some frames (bug#28512)

* src/nsterm.m ([EmacsWindow setParentChildRelationships]): Remove
shadows on undecorated child frames.
---
 src/nsterm.m | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/nsterm.m b/src/nsterm.m
index f79e271a98..6178dd80bb 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8435,6 +8435,15 @@ - (void)setParentChildRelationships
 #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1070
   [ourView updateCollectionBehavior];
 #endif
+
+  /* Child frames are often used in ways that may mean they should
+     "disappear" into the contents of the parent frame.  macOs's
+     drop-shadows break this effect, so remove them on undecorated
+     child frames.  */
+  if (parentFrame && FRAME_UNDECORATED (ourFrame))
+    [self setHasShadow:NO];
+  else
+    [self setHasShadow:YES];
 #endif
 
 
-- 
2.33.0

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On Tue, Dec 28, 2021 at 6:43 AM Alan Third <alan@idiocy.org> wrote:
>
> On Thu, Dec 23, 2021 at 01:19:34PM -0500, Aaron Jensen wrote:
> > On Thu, Dec 23, 2021 at 11:09 AM Alan Third <alan@idiocy.org> wrote:
> > > Looks like we can set hasShadow to NO. Maybe we want to do that to
> > > undecorated child frames, or something?
> >
> > That's probably reasonable. I like it for emacs-mini-frame, but having
> > the shadows on company posframe is silly, so I'm fine not having it
> > for anything.
>
> Please try the attached, it's completely untested.

Seems to work with my initial testing. Undecorated frames that are not
children have a shadow, as do decorated frames. Undecorated children
do not have a shadow.

Thanks,

Aaron

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Alan Third]

On Tue, Dec 28, 2021 at 11:18:07AM -0500, Aaron Jensen wrote:
> On Tue, Dec 28, 2021 at 6:43 AM Alan Third <alan@idiocy.org> wrote:
> >
> > On Thu, Dec 23, 2021 at 01:19:34PM -0500, Aaron Jensen wrote:
> > > On Thu, Dec 23, 2021 at 11:09 AM Alan Third <alan@idiocy.org> wrote:
> > > > Looks like we can set hasShadow to NO. Maybe we want to do that to
> > > > undecorated child frames, or something?
> > >
> > > That's probably reasonable. I like it for emacs-mini-frame, but having
> > > the shadows on company posframe is silly, so I'm fine not having it
> > > for anything.
> >
> > Please try the attached, it's completely untested.
> 
> Seems to work with my initial testing. Undecorated frames that are not
> children have a shadow, as do decorated frames. Undecorated children
> do not have a shadow.

Thanks, I've pushed this to master now.

-- 
Alan Third

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[martin rudalics]

 >> `initial-display-alist` to include `(undecorated . t)` in `init.el`
 >> seems to be insufficient, because the frame appears to be created
 >> prior to `init.el` being eval’d.
 >
 > I don’t know for sure, but suspect the answer is that you can’t do
 > that.

Does calling Emacs with

--eval "(setq initial-frame-alist '((undecorated . t)))"

work?

martin

bug#28512: 26.0.60; undecorated frames on macOS 10.13 do not resize properly

[Aaron Jensen]

On October 17, 2017 at 1:59:15 AM, martin rudalics
(rudalics@gmx.at(mailto:rudalics@gmx.at)) wrote:

> >> `initial-display-alist` to include `(undecorated . t)` in `init.el`
> >> seems to be insufficient, because the frame appears to be created
> >> prior to `init.el` being eval’d.
> >
> > I don’t know for sure, but suspect the answer is that you can’t do
> > that.
>
> Does calling Emacs with
>
> --eval "(setq initial-frame-alist '((undecorated . t)))”

No, same issue.

Aaron