From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30364: 26.0.91; thread crash on macos Date: Sun, 18 Feb 2018 11:49:45 -0800 Message-ID: References: <87bmgs9y8y.fsf@users.sourceforge.net> <871shj7k0n.fsf@gmail.com> <83k1vbbhvv.fsf@gnu.org> <83inavbg3p.fsf@gnu.org> <83eflic32p.fsf@gnu.org> <83zi469rge.fsf@gnu.org> <83vaeu9mtn.fsf@gnu.org> <83o9km9jr5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="94eb2c1457482a91d7056581e1e1" X-Trace: blaine.gmane.org 1518983300 29635 195.159.176.226 (18 Feb 2018 19:48:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Feb 2018 19:48:20 +0000 (UTC) Cc: 30364@debbugs.gnu.org, Alan Third , Noam Postavsky , Noam Postavsky To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 18 20:48:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enUwT-0006zt-5y for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Feb 2018 20:48:09 +0100 Original-Received: from localhost ([::1]:46347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enUyV-000540-3F for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Feb 2018 14:50:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enUyM-00052V-V8 for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2018 14:50:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enUyI-0000hl-3y for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2018 14:50:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1enUyH-0000hN-Va for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2018 14:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1enUyH-0002nE-NY for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2018 14:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Feb 2018 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30364 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30364-submit@debbugs.gnu.org id=B30364.151898339310719 (code B ref 30364); Sun, 18 Feb 2018 19:50:01 +0000 Original-Received: (at 30364) by debbugs.gnu.org; 18 Feb 2018 19:49:53 +0000 Original-Received: from localhost ([127.0.0.1]:50168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enUy9-0002mp-K1 for submit@debbugs.gnu.org; Sun, 18 Feb 2018 14:49:53 -0500 Original-Received: from mail-qt0-f172.google.com ([209.85.216.172]:45678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enUy7-0002mZ-S5 for 30364@debbugs.gnu.org; Sun, 18 Feb 2018 14:49:52 -0500 Original-Received: by mail-qt0-f172.google.com with SMTP id v90so7130610qte.12 for <30364@debbugs.gnu.org>; Sun, 18 Feb 2018 11:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TKwtuVPzeWiLmQatXPpFIMs5Ii6S/3LLTEFJlyfQc4k=; b=MmQE+eaGJN95Md/PfWPiVvc3QLKzpDGm/oSbGxdDW/chTD8Fe67/PpYQEbb86rG5gR cs1RXZrYqRd9denzX8YDBQBWWV0eOLuPJf8IG/xgdVyxWUNjk1+5pkcM++GnMzsr0t5u J45nu0J6SH55FAA8C369AMpcbnsLt24D92DOJgYdZ6kQDpzphIGAw8Vc1xicA9Vacfcc salH6+fElXsYxnk2x/WNCGSJ0oTI3GnbSYH18XKKh08kZCD2q6wHDCH4wTkuoajbmq3G ufNxLfXkuQfdRer1WfcpqIWYLnDNPJgIzkxM17MmWPnPQskS8z8AT00k9oYiS6uWPPxM 8Wpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TKwtuVPzeWiLmQatXPpFIMs5Ii6S/3LLTEFJlyfQc4k=; b=LSLHQibh2WHdHSfzMJfZF4u5p0VltbWVXrB06M2uXHqJsBRG8wM+Fl9qviD3deutQG VwPHnXQWAJceCYV/ho6ulrCLk2TTZJc/nfU3e8jolHMW1dbNvqvcsszFFrozKcdG81yy UarXh65py4kPhQ1r7rTV1lb2Qi/TxZxIH08vOyDF/JoYdqXDMVkTeyNPrJBBS9ZVgrH7 aNQTPToBAyxIlp14XnIvknLnSGJM1At9O6dx5sB3DlYW+kjgNsZFM7GtqZ/r13WEUmkt kbDJBqfpezvJS5Ct6l7NxGY9sVAiOajGxb1qM6qDQZOARGCDBanIDa5RMT7Y2Ys5UwKK BnSQ== X-Gm-Message-State: APf1xPBE2h57Y4lFGqJbD4I8W0J8QXwyR75voe9AJuuwzcBvKWUQQHIY Pp6cmM/y7ICPghxhrr+/WoT9lRnHaCu1vj878g4= X-Google-Smtp-Source: AH8x225JvlYA4kuHTF2tq0Il8uECZAUw5H1LvphAQQg7KB6M56AIDvVuuOCrpujn82VX675CdiSPmngBgQOESGmUCoc= X-Received: by 10.200.15.148 with SMTP id b20mr19752654qtk.301.1518983386394; Sun, 18 Feb 2018 11:49:46 -0800 (PST) Original-Received: by 10.237.54.65 with HTTP; Sun, 18 Feb 2018 11:49:45 -0800 (PST) In-Reply-To: <83o9km9jr5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143435 Archived-At: --94eb2c1457482a91d7056581e1e1 Content-Type: text/plain; charset="UTF-8" On Sun, Feb 18, 2018 at 11:32 AM, Eli Zaretskii wrote: > A thread that runs Lisp can continue running Lisp for a long time, and > will generate a lot of garbage. If GC is prevented, we will risk > running out of memory. > > IOW, leaving GC for the main thread only makes sense if we can be sure > the main thread will run shortly. But that cannot be guaranteed with > the current thread model, where a thread must exit or yield before > another thread can run. I was actually imagining that when a thread needed a GC it would request that the GC be done on the main thread (blocking while it waits). I have no idea how difficult that would be to implement. > If threads get only 512KB of stack, it's a small wonder that they > crash in GC. IME, you need at least 3MB to endure a full GC in Emacs. I upped the required stack size to 5MB and it fixed the crash for me. I don't know what the right size should bed, I could go w/ the 3MB you call out here, but I went a little higher to be safe. See attached patch. I'm assuming that pthread_attr_setstacksize is available everywhere pthread is. I don't know if that's an ok assumption or not. > What do you mean by "one thread at a time"? How was your program > changed for this run? I just meant that I C-x C-e on (company-dabbrev-thread "e" (lambda (words) (message "%S" words))), waited, did it again, etc, until crash. Aaron --94eb2c1457482a91d7056581e1e1 Content-Type: application/octet-stream; name="0001-Require-at-least-5MB-stack-size-for-a-thread-bug-303.patch" Content-Disposition: attachment; filename="0001-Require-at-least-5MB-stack-size-for-a-thread-bug-303.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jdt7de6i0 RnJvbSA2YzU2MDc4MTk3ZTk3ZTNlMzNiMDI2NGM5N2M5ODA3YzdhOTI4OWU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAxOCBGZWIgMjAxOCAxMTo0Mzo0NyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJl cXVpcmUgYXQgbGVhc3QgNU1CIHN0YWNrIHNpemUgZm9yIGEgdGhyZWFkIChidWcjMzAzNjQpCgoq IHNyYy9zeXN0aHJlYWQuYyAoc3lzX3RocmVhZF9jcmVhdGUpOiBSZXF1aXJlIGF0IGxlYXN0IDVN QiBzdGFjayBzaXplCi0tLQogc3JjL3N5c3RocmVhZC5jIHwgMTEgKysrKysrKysrKysKIDEgZmls ZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL3N5c3RocmVhZC5j IGIvc3JjL3N5c3RocmVhZC5jCmluZGV4IDRmZmI3ZGIxNDMuLjcwZmVmZjI5YzEgMTAwNjQ0Ci0t LSBhL3NyYy9zeXN0aHJlYWQuYworKysgYi9zcmMvc3lzdGhyZWFkLmMKQEAgLTk0LDYgKzk0LDgg QEAgc3lzX3RocmVhZF95aWVsZCAodm9pZCkKICNpbmNsdWRlIDxzeXMvcHJjdGwuaD4KICNlbmRp ZgogCisjZGVmaW5lIFJFUVVJUkVEX1NUQUNLX1NJWkUgNSoxMDI0KjEwMjQKKwogdm9pZAogc3lz X211dGV4X2luaXQgKHN5c19tdXRleF90ICptdXRleCkKIHsKQEAgLTE2MSwxMCArMTYzLDE5IEBA IHN5c190aHJlYWRfY3JlYXRlIChzeXNfdGhyZWFkX3QgKnRocmVhZF9wdHIsIGNvbnN0IGNoYXIg Km5hbWUsCiB7CiAgIHB0aHJlYWRfYXR0cl90IGF0dHI7CiAgIGludCByZXN1bHQgPSAwOworICBz aXplX3Qgc3RhY2tTaXplID0gMDsKIAogICBpZiAocHRocmVhZF9hdHRyX2luaXQgKCZhdHRyKSkK ICAgICByZXR1cm4gMDsKIAorICBpZiAocHRocmVhZF9hdHRyX2dldHN0YWNrc2l6ZSAoJmF0dHIs ICZzdGFja1NpemUpKQorICAgIHJldHVybiAwOworCisgIGlmIChzdGFja1NpemUgPCBSRVFVSVJF RF9TVEFDS19TSVpFKSB7CisgICAgaWYgKHB0aHJlYWRfYXR0cl9zZXRzdGFja3NpemUgKCZhdHRy LCBSRVFVSVJFRF9TVEFDS19TSVpFKSkKKyAgICAgIHJldHVybiAwOworICB9CisKICAgaWYgKCFw dGhyZWFkX2F0dHJfc2V0ZGV0YWNoc3RhdGUgKCZhdHRyLCBQVEhSRUFEX0NSRUFURV9ERVRBQ0hF RCkpCiAgICAgewogICAgICAgcmVzdWx0ID0gcHRocmVhZF9jcmVhdGUgKHRocmVhZF9wdHIsICZh dHRyLCBmdW5jLCBhcmcpID09IDA7Ci0tIAoyLjE1LjEKCg== --94eb2c1457482a91d7056581e1e1--