From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#30800: 26.0.91; unknown crash on macos Date: Wed, 21 Mar 2018 22:35:23 -0700 Message-ID: References: <83muz1jrdv.fsf@gnu.org> <83k1u5jqxm.fsf@gnu.org> <83in9pjnkc.fsf@gnu.org> <83fu4tjmdv.fsf@gnu.org> <20180321191903.GA38993@breton.holly.idiocy.org> <83d0zxjk5p.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a114030a49f965f0567f9ac01" X-Trace: blaine.gmane.org 1521696854 17109 195.159.176.226 (22 Mar 2018 05:34:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2018 05:34:14 +0000 (UTC) Cc: Alan Third , 30800@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 22 06:34:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eysrX-0004Id-7z for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 06:34:07 +0100 Original-Received: from localhost ([::1]:58927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eystZ-0002SV-ER for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 01:36:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eystT-0002SK-3e for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 01:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eystO-00054G-5d for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 01:36:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eystO-00054B-0q for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 01:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eystN-0002qm-Nn for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 01:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2018 05:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30800-submit@debbugs.gnu.org id=B30800.152169693110913 (code B ref 30800); Thu, 22 Mar 2018 05:36:01 +0000 Original-Received: (at 30800) by debbugs.gnu.org; 22 Mar 2018 05:35:31 +0000 Original-Received: from localhost ([127.0.0.1]:46556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eysss-0002pw-Jt for submit@debbugs.gnu.org; Thu, 22 Mar 2018 01:35:30 -0400 Original-Received: from mail-qt0-f178.google.com ([209.85.216.178]:38655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyssr-0002pj-Kx for 30800@debbugs.gnu.org; Thu, 22 Mar 2018 01:35:29 -0400 Original-Received: by mail-qt0-f178.google.com with SMTP id n12so7757799qtl.5 for <30800@debbugs.gnu.org>; Wed, 21 Mar 2018 22:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lZ0d3csuQuwWHcJNFriHx8+9+YQdeu/u14vS/PKbi9c=; b=aDV9oY0jcBRUn3Qsho64/JcizYB0/durDouDY0GZ/mr81PG82C+ojQrdh5MZCOKajq hqV/YD70wRGngLdyN5BKhjeuHver0O9RaHNyBTE2DWs7+c7h2veQps+jQtYe5+xzoAZU XPOqYiUA9uMeg4OSLXanFcER6iZT8zjXwFhOfFBZPrxD6fpZ4rMDLkYV9qSH/+mSQWZq dF9RcTrAba0xBfm7VtsozJzHokSPlvPA9cajDqmgu5T8AGpvhgY52s8n/Ac0PC5BuaNT 7yKdprSCnvQ+OyZzLE8fyTiqiXDST65wTGiEOoAN761PECpQLAK7WIacHa2quc4x44Da bkSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lZ0d3csuQuwWHcJNFriHx8+9+YQdeu/u14vS/PKbi9c=; b=HI8Q2ApZhtsS4dWgdX+h4pMx1vMQbn4UyE0XHqmkARzxb24NHubORKhee6GFgD5DnJ Sn5hUpXlYF33T73wfuCKTwz2KksGUJGK77QAgD2s81jempWXHNcmfW1c8OXsmY/wPPab lpi+9aU1/RmVOf655u7aeVuoaZYtAHbFaMH6Fmno0twPCVEFb44bwpXtXvaiQU8nQclt hScr+3lccEqIODRwURj8M3Tastm9U9kNPr0F3s6MOq+PwA0sAWITZ43sN0ojLKBsRlBx 08V/bju2PaRfo209uvzp+PqzfTAHLqrxRMtgXc0I4VIhWBAZjk6nq2JQ5WwvuHBU5/J0 +HBg== X-Gm-Message-State: AElRT7HcXZMMQZHjK/ob2IjvP923+afJvywU3P8RxdDyICK8krDSqyHK wUuF2xYMNeUL2fiGvbjofPpCfDJ22sCdmOzsC/k= X-Google-Smtp-Source: AG47ELuDvBMBSI2Lea975r6nASkuAPP9+QfMWi0YVdglUeNTa+CMFLY9U3QKXhwfIpXQUGR4/8URwJ4MNBT0Fqb/k84= X-Received: by 10.237.37.50 with SMTP id v47mr33681736qtc.66.1521696924200; Wed, 21 Mar 2018 22:35:24 -0700 (PDT) Original-Received: by 10.237.60.76 with HTTP; Wed, 21 Mar 2018 22:35:23 -0700 (PDT) In-Reply-To: <83d0zxjk5p.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144515 Archived-At: --001a114030a49f965f0567f9ac01 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 21, 2018 at 12:36 PM, Eli Zaretskii wrote: >> or just add >> >> if (represented_frame == f) >> represented_frame = NULL; >> >> to x_destroy_frame as you say. > > If that fixes the problem, it's the safest change I can think of, so > perhaps Aaron could try running Emacs 26.0.91 with it. It seems to fix it. I'm unable to reproduce the crash with this patch applied. I tried to represent what was going on in my comments/commit messages but I'm happy to change them if anyone has a better way to describe it. That is if you want to apply this instead of fixing it in another way. Thanks. --001a114030a49f965f0567f9ac01 Content-Type: application/octet-stream; name="0001-Fix-crash-after-frame-is-freed-on-macOS-bug-30800.patch" Content-Disposition: attachment; filename="0001-Fix-crash-after-frame-is-freed-on-macOS-bug-30800.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jf22zmb20 RnJvbSAzMjM3NDBiZjBkNTU0ZmJmYzZhZmM5MGVkODFjNjg4NzljZDQ2ZWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogV2VkLCAyMSBNYXIgMjAxOCAyMjozMDowOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBjcmFzaCBhZnRlciBmcmFtZSBpcyBmcmVlZCBvbiBtYWNPUyAoYnVnIzMwODAwKQoKKiBzcmMv bnN0ZXJtLm0gKHhfZnJlZV9mcmFtZV9yZXNvdXJjZXMpOiBDbGVhciByZXByZXNlbnRlZF9mcmFt ZS4KKGJ1ZyMzMDgwMCkKLS0tCiBzcmMvbnN0ZXJtLm0gfCA0ICsrKysKIDEgZmlsZSBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvbnN0ZXJtLm0gYi9zcmMvbnN0ZXJt Lm0KaW5kZXggM2Q1OGNkNWVjNi4uYzhhZTMxYWJjMCAxMDA2NDQKLS0tIGEvc3JjL25zdGVybS5t CisrKyBiL3NyYy9uc3Rlcm0ubQpAQCAtMTY5Miw2ICsxNjkyLDEwIEBAIC0odm9pZClyZW1vdmUK ICAgICBkcHlpbmZvLT54X2hpZ2hsaWdodF9mcmFtZSA9IDA7CiAgIGlmIChmID09IGhsaW5mby0+ bW91c2VfZmFjZV9tb3VzZV9mcmFtZSkKICAgICByZXNldF9tb3VzZV9oaWdobGlnaHQgKGhsaW5m byk7CisgIC8qIEVuc3VyZSB0aGF0IHNlbmRFdmVudCBkb2VzIG5vdCBhdHRlbXB0IHRvIGRlcmVm ZXJlbmNlIGEgZnJlZWQKKyAgICAgZnJhbWUuIChidWcjMzA4MDApICovCisgIGlmIChyZXByZXNl bnRlZF9mcmFtZSA9PSBmKQorICAgIHJlcHJlc2VudGVkX2ZyYW1lID0gTlVMTDsKIAogICBpZiAo Zi0+b3V0cHV0X2RhdGEubnMtPm1pbmlpbWFnZSAhPSBuaWwpCiAgICAgW2YtPm91dHB1dF9kYXRh Lm5zLT5taW5paW1hZ2UgcmVsZWFzZV07Ci0tIAoyLjE2LjIKCg== --001a114030a49f965f0567f9ac01--