From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Mon, 23 Dec 2024 13:19:32 -0800 Message-ID: References: <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> <86jzcafcj6.fsf@gnu.org> <867c8af514.fsf@gnu.org> <86ldwpedud.fsf@gnu.org> <86r05z67gm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008909ed0629f68d97" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, Eli Zaretskii , yantar92@posteo.net, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 23 22:21:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPprh-0009da-NU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Dec 2024 22:21:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPprR-00026L-Qk; Mon, 23 Dec 2024 16:21:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPprL-00025n-Bp for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 16:21:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPprK-0000Ld-1h for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 16:21:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:References:In-Reply-To:Mime-Version:To:Subject; bh=tB5NfLxHNWVUWdM3FLzwjEQwK/k/tHFDcKHlKXWKSqY=; b=eNbSIJX/Xcd8DOL2Ly5g77JUtZarW4RBtZLJ5OD+SP0jcAOnJ+Z/n92JOJ9cko0eJW9klGq8zyiCykxbLUhxBbSgr6cUP9so5UAtxI8EyERzQZjtnZDhEpoQnrASco9zqq9ZsgDurrzoK7uENLv2vo0vTJZAXrvKZEdSk94qd1Hn5nAEunA+Fu8N8+4DhpTDu98UDIDWMj8F0HM4l3Vsx29NspCraM17qtuL0dnMg0av0JnXx7WCqZCkzes9JF62S0tjDnj+jOcB7f9j+s9z24YqKE0z6Qw6vKTAFcQsNO2fUHtAxCebV+D3WdHDeSeOecbZWEZ2JwoGXQtUtPo7Zg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPprJ-0004Me-S9 for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 16:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Dec 2024 21:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173498883716729 (code B ref 73862); Mon, 23 Dec 2024 21:21:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 23 Dec 2024 21:20:37 +0000 Original-Received: from localhost ([127.0.0.1]:58271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPpqv-0004Ll-D9 for submit@debbugs.gnu.org; Mon, 23 Dec 2024 16:20:37 -0500 Original-Received: from mail-lj1-f172.google.com ([209.85.208.172]:48422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPpqs-0004La-LN for 73862@debbugs.gnu.org; Mon, 23 Dec 2024 16:20:35 -0500 Original-Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-3003e203acaso46561861fa.1 for <73862@debbugs.gnu.org>; Mon, 23 Dec 2024 13:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734988774; x=1735593574; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tB5NfLxHNWVUWdM3FLzwjEQwK/k/tHFDcKHlKXWKSqY=; b=AgYOnOsONz/Pt/YXV+73T0NXBZ/DCvwaoYAqPJg2dWLBhZJIWnVLob//2DYsUwxSac ANnTdRXUP5Q+r1ZEYvkdAreshqE03cuuIA2QLAs6CuwUv7TaXOEQV1ETdOQrFZ+un5zF m1abshULcUQdCPJ1EGkUCpR08zWommaGa/GN+LuE8Iwq39JrOJgzTD79ddOihC2GKrkm cu4lxw6wEptoLAtfRuSWkEHQZyuJNCcWNMMeTQgW2QlQohNu1ZP9rUPORh+UlGPaGbG2 2YcBokbl0t7/3rLfDtcHDT9Hn1IecmjLRF86VS2iRqpU+Y7my5E6ttKkufmBS80VtKbe a91A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734988774; x=1735593574; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tB5NfLxHNWVUWdM3FLzwjEQwK/k/tHFDcKHlKXWKSqY=; b=WM6/Dgn6H0i/nxCd0KAWnSwVaIX3RSXpZbmDWwTn01GN+klS4P/1sFNjLyCbDvfEBM jQUx2BdBuolOjPfcup4vYSLTjYAonfsTlU/pUMCq0Ig9Rbx2mQXcW+/TGaOKMrn7uP6l gjOGuYFD4pDMRW8ROHUzNUDbQBt0jKDau9aGkWQBkzYNxkAqs8btNG54Bh+EUfJdHSWs sIgcmq2N2xRwnFQ6ZI3BvzdTBJ0V2aeOyk0DOJ9UV562Edr5mvaMEn6UvpiLtAUxsq4B lGVu4KIrQ/Z3TeGp2y3Fm3GBu+X4K7fm/OZIFBTH2Kuhfipio4KsmXnE9BLcseyBiDbI OljQ== X-Forwarded-Encrypted: i=1; AJvYcCUUmgDuR+zs2/JGoV4sEjckzECoN7KjWHCrQBc3c3clcDlRiI4g2cVYe+5/9o8zTgGQxt9Gpg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxObF3MLUx1EheS0qEyHNwRGvgNj8TBbWZv8a6M5JHRdPy8T+9a NNFo6Oo3dXZ6ltblJtEInmoOVhdcy5/BZfz92JxckMVCbYvtGbS8R9u0gRdcQFgBAOFfQYP6xmh fJRK4MVtIvgFtFQtRzq0ADAKR4So= X-Gm-Gg: ASbGncuATfTxkEFNGQUZM8YlF8mzAkzuPZYPUQDBax3hQblkx1xUr2f+SXeuIGJ5EgP HhJZmM81XwXurhOw9e/jRHh9wQWChMPSVs037fPTGyDsJCeasOfzSS63kGy8l+g== X-Google-Smtp-Source: AGHT+IFH/zlfhCtuV0EXzLtzokFN7yISyK2YLq9IXfZXPmwkPZIx8r0MwnnWR2cpS23AFg7mF/UVS631KnHPYavRYHE= X-Received: by 2002:a05:651c:4ca:b0:302:3355:f756 with SMTP id 38308e7fff4ca-304685de7e4mr39257001fa.35.1734988773523; Mon, 23 Dec 2024 13:19:33 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Dec 2024 13:19:32 -0800 X-Superhuman-Draft-ID: draft00f51776a2728fc5 X-Superhuman-ID: m51ji90b.db49fa28-b4b4-4ae1-85ef-f9e9685bad64 In-Reply-To: X-Mailer: Superhuman Desktop (2024-12-18T20:41:51Z) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297664 Archived-At: --0000000000008909ed0629f68d97 Content-Type: text/plain; charset="UTF-8" On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron wrote: > Eli Zaretskii writes: > > Please try the patch below. If it gives good results, please run with it > for awhile, and tell if you see anything unusual or unexpected. > > Thanks, so far so good. > Same for me, it's also working so far. Are there any tradeoffs with this approach other than additional code complexity? Any performance concerns? Thanks, Aaron --0000000000008909ed0629f68d97 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron <me@eshelyaron.com> wrote:
=

Eli Zaretskii <eliz@= gnu.org> writes:

Please try the patch below. If it gives good results, please run with it for awhile, and tell if you see anything unusual or unexpected.

Thanks, so far so good.

<= /div>

Same for me, it's also working so far.

Are there any tradeoffs with this=C2=A0approach = other than additional code complexity? Any performance concerns?
<= div>
Thanks,

Aaron

--0000000000008909ed0629f68d97--