unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Aaron Jensen <aaronjensen@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 61017@debbugs.gnu.org
Subject: bug#61017: 29.0.60; ruby-ts-mode indents class between two lines incorrectly
Date: Tue, 24 Jan 2023 09:17:53 -0500	[thread overview]
Message-ID: <CAHyO48wqcqt5Ozhaitw7PWuxmeJYH7sDW1GHN6sbD+eYN=6UBQ@mail.gmail.com> (raw)
In-Reply-To: <1a2436ef-ff4d-827c-f22f-33b0737d9b1f@yandex.ru>

On Mon, Jan 23, 2023 at 4:28 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> Hi!
>
> On 23/01/2023 06:33, Aaron Jensen wrote:
> >
> > Start with a buffer in ruby-ts-mode like:
> >
> > a
> >
> > b
> >
> > Between the two lines, type "class Foo", then press enter
> >
> > You should get this:
> >
> > a
> >
> >    class Foo
> >
> > b
> >
> > But this is expected:
> >
> > a
> >
> > class Foo
> >
> > b
> >
> > Note that reindenting after adding the "end" will indent correctly, so
> > it's only an issue with electric indent
>
> Thanks for the report, the problem here is that such examples parse into
> a malformed syntax tree:
>
>    (program (identifier)
>     (ERROR class (constant) (identifier)))
>
> Another example would be:
>
>    class C
>      def foo
>
> which parses as
>
>    (ERROR class (constant) def (identifier))
>
> We can try to anticipate such cases and infer the implied structure
> somehow, or just disable indentation for specific cases. See the
> attached patch for the latter.
>
> Is it enough of an improvement?

That seems to make indentation after an open def not happen:

def foo
bar
end

I applied the patch manually though, so maybe you can confirm that you
see the same thing?





  reply	other threads:[~2023-01-24 14:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23  4:33 bug#61017: 29.0.60; ruby-ts-mode indents class between two lines incorrectly Aaron Jensen
2023-01-23 21:28 ` Dmitry Gutov
2023-01-24 14:17   ` Aaron Jensen [this message]
2023-01-24 18:53     ` Dmitry Gutov
2023-01-25  0:45       ` Aaron Jensen
2023-01-25  4:00         ` Dmitry Gutov
2023-01-25 14:22           ` Aaron Jensen
2023-01-25 15:23             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHyO48wqcqt5Ozhaitw7PWuxmeJYH7sDW1GHN6sbD+eYN=6UBQ@mail.gmail.com' \
    --to=aaronjensen@gmail.com \
    --cc=61017@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).