From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions Date: Fri, 30 Dec 2022 13:16:35 -0500 Message-ID: References: <902440c7-706a-20e1-55af-4e12e8cdda2c@yandex.ru> <688159e9-f6bc-f233-08c4-9834bc00c455@yandex.ru> <74f977f6-d9ba-04bd-fba0-0dce4729cf0d@yandex.ru> <8d554fc2-7da5-cfe1-c865-023d56d222e3@yandex.ru> <95adedfa-7644-c78b-8853-fde8ec38f621@yandex.ru> <44ccf2d5-789f-f122-34f9-25871fdf1283@yandex.ru> <118143a7-0703-2538-9853-7009064e7bca@yandex.ru> <4540a3e6-f736-9050-0aac-0a9be1459248@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60186@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 30 19:17:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBJx2-0001wK-2B for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Dec 2022 19:17:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBJwM-0000aP-Cm; Fri, 30 Dec 2022 13:17:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBJwE-0000ZI-RU for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 13:17:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBJwE-00037v-Je for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 13:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBJwE-0006ua-4r for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 13:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2022 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60186 X-GNU-PR-Package: emacs Original-Received: via spool by 60186-submit@debbugs.gnu.org id=B60186.167242421426549 (code B ref 60186); Fri, 30 Dec 2022 18:17:02 +0000 Original-Received: (at 60186) by debbugs.gnu.org; 30 Dec 2022 18:16:54 +0000 Original-Received: from localhost ([127.0.0.1]:36108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJw5-0006u9-Qb for submit@debbugs.gnu.org; Fri, 30 Dec 2022 13:16:54 -0500 Original-Received: from mail-pf1-f169.google.com ([209.85.210.169]:42840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJw4-0006ts-26 for 60186@debbugs.gnu.org; Fri, 30 Dec 2022 13:16:52 -0500 Original-Received: by mail-pf1-f169.google.com with SMTP id a184so4129176pfa.9 for <60186@debbugs.gnu.org>; Fri, 30 Dec 2022 10:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yHCA/KTKwp7B7Kwu2uVf7j6pG80nczXvqIWwVgNqGkM=; b=VSM6+90wXzpmwFDUA2Dx65nGb6lvtNa8cCBiw9qCkJjXgXG+eJYFi5YBWE0CRV800M 1TXG+SYs3CS2WviPWJbqOA6Jg7pOy5vZNjo+REpYe231o+W5oLQ150X5aa0EzR/Ne9SZ YU3Hi0K/kKJwop9sa1OudVAqHL+EqRHYY5LJGnDJZV8yw8y0Zi8oGlYkKBzkxhALmJZD ky/uL/WQc2J4dSzn0lP2qk2tJteJY9TIj8Ks5ysk8kSGgWP4CqKvZTZVmSe4gq1+EZFk BnhR6jki94zV+iF4PLTQErXskpkCUJnpH/mQxUVgfEHJYmIKw7Iu3QOfS5ibdE7d0n19 hpSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yHCA/KTKwp7B7Kwu2uVf7j6pG80nczXvqIWwVgNqGkM=; b=Ybp2N3fRPRb/NvGTp5UPKf31wKYyl+ssUNxkpIPzJx5uMAfTDMwBVOlFaTH9vcJ36F OQxKkNrj+ynI+o7dyxytPrfY1PrrgqB+JbGPK0usqZL6kheEna0futdlwnLUDB6wci0A 73NJ8urQb3qfPrWsLqN62ixXXDQE47b3lzpOTy+m5Pe7cEbyuJr131Ko4p2QM/WgJoOI 609pae22NiEFNCNjyLVhaybMTKfIcGKr0RCfw6wx35qWChH7CTrlhnPWH3Spe+gptmIc iBhRyBmtgX2IOoy66/G9JVG7K+uvwa0POO1JiODB94p/iydDSl8BWDfaiFMsGkS2YT9D cPbw== X-Gm-Message-State: AFqh2kpwttq622npMXEuE5SruATDI8LMk2nstNJpy6pO437hQ5kR6w5A xDhA1eIyaIuY7TFqMpehY+/Khd0WeFYUHsqL94M= X-Google-Smtp-Source: AMrXdXtcUNQw2fgo8eqqY7FoQbWahEZs76zjjc8V82tkXbwp/tAp02I1NN0F0KPOsD80iOIVi5klgj27oHlt+1+7YYw= X-Received: by 2002:a62:388d:0:b0:576:9786:94c2 with SMTP id f135-20020a62388d000000b00576978694c2mr2087787pfa.26.1672424206044; Fri, 30 Dec 2022 10:16:46 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252149 Archived-At: On Fri, Dec 30, 2022 at 1:00 PM Aaron Jensen wrote: > > On Fri, Dec 30, 2022 at 10:02 AM Dmitry Gutov wrote: > > > > Hi Aaron, > > > > On 30/12/2022 00:59, Aaron Jensen wrote: > > > On Wed, Dec 28, 2022 at 4:24 PM Dmitry Gutov wrote: > > >> On 28/12/2022 14:47, Dmitry Gutov wrote: > > >>> I guess that particular trend started with ruby-method-params-indent, > > >>> where I haven't managed to choose better names for the var, or the values. > > >> Semantics aside (I suppose we could go back and revise the naming a > > >> little later), could you test this new revision of the patch? > > >> > > >> I think I got the implementation simple enough now. > > >> > > >> The number of options has grown, though: > > >> > > >> (setq ruby-after-operator-indent nil > > >> ruby-block-indent nil > > >> ruby-method-call-indent nil > > >> ruby-parenless-call-arguments-indent nil) > > > I'll give it a shot some more, but these appear problematic: > > > > > > fixture( > > > EntityProjection::Fixtures::Projection, > > > projection, > > > deleted > > > ) do|projection| > > > projection.assert_attributes_copied([ > > > { :document_id => :id } > > > ]) > > > end > > > > > > Should be: > > > > > > fixture( > > > EntityProjection::Fixtures::Projection, > > > projection, > > > deleted > > > ) do|projection| > > > projection.assert_attributes_copied([ > > > { :document_id => :id } > > > ]) > > > end > > > > This example is for https://debbugs.gnu.org/60321, I think. Which we > > split off and postponed a little. > > > > The last patch was the latest revision of the changes for > > https://debbugs.gnu.org/60186. > > My mistake, it seems to work for these things aside from the method > params in the example below. I can't reproduce that in emacs -Q, only > with my own config, so I will have to see if I can figure out what the > difference is. I can't reproduce this anymore, I think it had to do w/ dtrt-indent doing something odd. I had things in a state where some buffers did it and not others and I restarted Emacs before checking the settings. In any case, I think it's fine. I don't have any concerns with the patch as-is. Thanks, Aaron