From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Tue, 3 Dec 2024 22:30:58 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000be91d306286bec4a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38017"; mail-complaints-to="usenet@ciao.gmane.io" To: eliz@gnu.org, 73862@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 04 07:33:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIiwz-0009j6-Hw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Dec 2024 07:33:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIiwr-00075X-ES; Wed, 04 Dec 2024 01:33:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIiwY-00074o-8n for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 01:33:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIiwX-0005Jg-Vd for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 01:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:References:In-Reply-To:Mime-Version:To:Subject; bh=zS/VcYqSdMW/hXy/ry7scfDmQK34E7Dqqi2cvBT6fpE=; b=E7wj0BVXC3rJUWTrzusTwI6bTUqo3DGxp2KjF161eXGjqkGbBU+/9R4KCcEphir6FGIMXFIRgScNDbU42WXtXMAKo/E3r/aBbIHzbce6hn7rCojiFrfndnBBA3i18pjVoU97EqNttOdp0qtuzahYP/hKbdNA9Yp5UiFIHqzCrAfq7X2mm8iBh7FhzFOkN5iIomqr4pFQ0n3bH+zVUpUHWB4U4x4gR1bSMpLZGs2mE1xiOpLN+m4f/CQ4bfrlbXT/WmdEyJiC5emmqP1mF5eqnZIsSxCerr2S4YThetUmyPtT7zmdgiqq9nadHPE6naGN+QTW3K2L37X+BBraPWgsVw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIiwX-0006EM-Pk for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 01:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Dec 2024 06:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173329392723864 (code B ref 73862); Wed, 04 Dec 2024 06:33:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 4 Dec 2024 06:32:07 +0000 Original-Received: from localhost ([127.0.0.1]:33834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIivf-0006Cp-57 for submit@debbugs.gnu.org; Wed, 04 Dec 2024 01:32:07 -0500 Original-Received: from mail-lj1-f182.google.com ([209.85.208.182]:55666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIivd-0006CJ-91 for 73862@debbugs.gnu.org; Wed, 04 Dec 2024 01:32:06 -0500 Original-Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2ffdd9fc913so67353831fa.3 for <73862@debbugs.gnu.org>; Tue, 03 Dec 2024 22:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733293859; x=1733898659; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=zS/VcYqSdMW/hXy/ry7scfDmQK34E7Dqqi2cvBT6fpE=; b=h5LWbfb2Uzue98GmiG1v3SntO2Mn1KRZqJsHeNFSV4CYNKcm6aTbbmUa9HpnJGBXij 8JQyDCSiZq0n964znI1Xmw7whj54YZSNTNuaGRekYp6LuwCtoLhO5O0ZzFs5I8j6Dp1A Mwi2WFkyykUm7ZgIaPCeB+PwOh+tnIa3KN/JGAWsxbzItcbeVC8QXJqZZbVYnvJtbvg+ rKDqM8UoTQUxRVlngfbxofrXRqBNPmBtxHOJ+UfGmDDw6MtVkMZVjkmqUQfA5tAiRMbs GYAevYYG6UBfYOxgGQSIFlcgjqXM99b1kZJXWpDnnAcEwjRJi60mWrCPSlqsBbgRt90F 64JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733293859; x=1733898659; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zS/VcYqSdMW/hXy/ry7scfDmQK34E7Dqqi2cvBT6fpE=; b=jMJrMe7czsNkANPDb6jc9W29G+rAMAfWoaedRTDmQAQRlpd2ofQ434lq2si8MCqkLP euxX98O0UsvijdIKib4AmmwbDczm/cSD3Y2MaMyjGAHPRKvOmi5+CCLIWa3raRDQyU69 z/xY/ez+xcRb5jzu/YViV3i1dArGYHL3icMyQCEqZQjpQkGM5vBTEttIT/G2h1GwtWpC HVgVJqp1pH2K2GJpQEDS9lfP3FQ63wy5VL3WQ7XTrKlRX/+j4yxvdk2oRbfZLt7AtNht 9ynWLP2JD8+AHoLIHYkLfcfCEnIzNuRPcvHnBEon43bvA9fbrbWIfdKbBlQcwcJVQzSk 0odQ== X-Forwarded-Encrypted: i=1; AJvYcCX3Efoxt+usmMDFYPKXSqDu+x4U7F3nemvnlu/ISmkc/u26q6u4OcBm7Oba2zoj8rAzKBDDfw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yws1jXO11y2YujpeyVDR1yeeoIREjbd7VxB6CSwa+UrEfoJQ2eT mpNqBbypg6mbYw3K28LEy4DGdmnr797zVe2JauIcc6/CjQ79Z9Gwr/8kFjabR0AW4J6XntJddVj iJo34B7XI8E0IZ6Gch7F5Ony0zxA= X-Gm-Gg: ASbGncszOkdfIOix1mo01AuSkF9sKO5azXId+SxGEIgl+jPgxlhbmYoK3KRdR9YONVS t1+PuGC/pvvVWv50/etHeRTBkCa2Iorj0sSYcJxr6OUnrSRC1bY1PwDo= X-Google-Smtp-Source: AGHT+IGokMa1EgTm9TNij3iec1v5S3xLYYyGR6KhE3OmmmFFj7J5BpAx6r5wDnw2Wz2BJki5FrQWKBibXzP0+JKfD/s= X-Received: by 2002:a2e:bc22:0:b0:2ff:c2e2:cca7 with SMTP id 38308e7fff4ca-30009c3555fmr31192401fa.16.1733293858785; Tue, 03 Dec 2024 22:30:58 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Tue, 3 Dec 2024 22:30:58 -0800 In-Reply-To: X-Mailer: Superhuman Desktop (2024-12-02T20:06:08Z) X-Superhuman-ID: m49iec7v.3ce32e5b-8c62-465d-b7a0-3bdaf5fe756c X-Superhuman-Draft-ID: draft0094775185bc5b0d X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296396 Archived-At: --000000000000be91d306286bec4a Content-Type: text/plain; charset="UTF-8" I'm able to reproduce this with the mode-line as well, so it appears that there may be a bug there too in the code that was copied to implement the active/inactive faces in the header line. It's entirely possible that there's a bug in nano-modeline, but it seems suspect that code was added to consider windows and now this issue triggers when new windows are created (and possibly when selection changes, I haven't eliminated whether or not that's a factor yet). Aaron On Tue, Dec 03, 2024 at 9:06 PM, Aaron Jensen wrote: > I bisected and found that this patch caused a regression in header-line > formatting. I don't have the exact reproduction steps yet, but the gist is > that I use a header-line with multiple faces in one window, then open a new > popup window that has no header-line. The original window's header-line > will get its faces changed slightly, but it's hard to tell how. > > Here's a video demonstrating it: https://share.cleanshot.com/CD9PtVv3 > > You can see that the padding on the left of the header line goes away and > the line numbers change to a variable pitch font. If I adjust my font size, > the header line redraws with the proper faces. This will happen randomly, > but I can force it with the font size change reliably. > > I'll see if I can narrow reproduction steps, but it may be worth > considering a revert for now. > > Thanks, > > > Aaron > --000000000000be91d306286bec4a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm able to rep= roduce this with the mode-line as well, so it appears that there may be a b= ug there too in the code that was copied to implement the active/inactive f= aces in the header line. It's entirely possible that there's a bug = in nano-modeline, but it seems suspect that code was added to consider wind= ows and now this issue triggers when new windows are created (and possibly = when selection changes, I haven't eliminated whether or not that's = a factor yet).


Aaron


On= Tue, Dec 03, 2024 at 9:06 PM, Aaron Jensen <aaronjensen@gmail.com> wrote:
I bisected and found that this patch caused a regr= ession in header-line formatting. I don't have the exact reproduction s= teps yet, but the gist is that I use a header-line with multiple=C2=A0faces= in one window, then open a new popup window that has no header-line. The o= riginal window's header-line will get its faces changed slightly, but i= t's hard to tell how.
<= br>
Here's a video demonstr= ating it:=C2=A0https:/= /share.cleanshot.com/CD9PtVv3

You can see that the padding on the left of the header line goes away= and the line numbers change to a variable pitch font. If I adjust my font = size, the header line redraws with the proper faces. This will happen rando= mly, but I can force it with the font size change reliably.

I'll see if I can narrow reproduction steps, but it may be worth= considering a revert for now.

Thanks,


Aaron<= /div>

--000000000000be91d306286bec4a--