From: Aaron Jensen <aaronjensen@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31546@debbugs.gnu.org, Alan Third <alan@idiocy.org>
Subject: bug#31546: 27.0.50; macOS child frames with no mode-line mouse click problem
Date: Sun, 27 May 2018 10:52:39 -0700 [thread overview]
Message-ID: <CAHyO48wbywys6SONDdptOU=1SfSGq8q6unCViiSALJb8J_xcXA@mail.gmail.com> (raw)
In-Reply-To: <8336yd80cy.fsf@gnu.org>
On Sun, May 27, 2018 at 10:39 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Aaron Jensen <aaronjensen@gmail.com>
> > Date: Sun, 27 May 2018 10:13:55 -0700
> > Cc: martin rudalics <rudalics@gmx.at>, Alan Third <alan@idiocy.org>,
31546@debbugs.gnu.org
> >
> > On Sun, May 27, 2018 at 8:58 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > > Based on the description, I think it's redisplay that's scrolling,
> > > because the mouse click sets point in a line that is visible only
> > > partially.
> >
> > To be clear, this is only true if my patch is applied. If my patch is
not
> > applied, clicking on the last line of a frame that has no minibuffer
and no
> > mode-line also triggers the scroll as well because the fact that it has
no
> > mode-line is not taken into account.
> Not sure I understand the connection between not having a mode line
> and the scroll. Can you elaborate? Apologies if this was already
> explained up-thread.
I'm not sure I can explain the actual mechanism as to why it matters, but
I'll explain what I can see.
In mouse-drag-track, the bottom of the window is calculated:
(bottom (if (window-minibuffer-p start-window)
(nth 3 bounds)
;; Don't count the mode line.
(1- (nth 3 bounds))))
I'm guessing this is somehow used to determine whether or not to scroll the
clicked location into view. The calculation is wrong if there is no
mode-line because it subtracts 1 unnecessarily. My patch adds to the
condition a check for the mode line format and does not subtract 1 if that
is nil.
Actually, looking at the code that's exactly what's happening:
(cond
((null mouse-row))
((< mouse-row top)
(mouse-scroll-subr start-window (- mouse-row top)
nil start-point))
((>= mouse-row bottom)
(mouse-scroll-subr start-window (1+ (- mouse-row bottom))
nil start-point)))
If the location clicked is >= to the bottom (which is miscalculated without
my patch when there is no mode-line and it is >= in the case of a partial
line visibility) then the window is scrolled, explicitly. So, that's the
problem afaict.
next prev parent reply other threads:[~2018-05-27 17:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 5:23 bug#31546: 27.0.50; macOS child frames with no mode-line mouse click problem Aaron Jensen
2018-05-22 7:25 ` martin rudalics
2018-05-22 7:33 ` Aaron Jensen
2018-05-22 8:40 ` martin rudalics
2018-05-22 12:51 ` Aaron Jensen
2018-05-22 19:33 ` Alan Third
2018-05-22 19:36 ` Aaron Jensen
2018-05-22 19:44 ` Alan Third
2018-05-22 19:51 ` Aaron Jensen
2018-05-23 6:36 ` martin rudalics
2018-05-23 11:14 ` Aaron Jensen
2018-05-23 21:31 ` Alan Third
2018-05-23 22:21 ` Aaron Jensen
2018-05-24 7:19 ` martin rudalics
2018-05-24 10:53 ` Aaron Jensen
2018-05-24 11:06 ` Aaron Jensen
2018-05-24 15:28 ` Eli Zaretskii
2018-05-24 15:58 ` Aaron Jensen
2018-05-25 6:34 ` martin rudalics
2018-05-26 16:38 ` Alan Third
2018-05-26 17:02 ` Aaron Jensen
2018-05-26 18:22 ` Alan Third
2018-05-26 20:15 ` Aaron Jensen
2018-05-27 6:22 ` martin rudalics
2018-05-27 15:57 ` Eli Zaretskii
2018-05-27 17:13 ` Aaron Jensen
2018-05-27 17:38 ` Eli Zaretskii
2018-05-27 17:52 ` Aaron Jensen [this message]
2018-05-27 18:52 ` Aaron Jensen
2018-05-27 21:24 ` Alan Third
2018-05-27 21:53 ` Aaron Jensen
2018-06-02 6:35 ` Aaron Jensen
2018-06-02 8:00 ` Eli Zaretskii
2018-06-02 15:41 ` Aaron Jensen
2018-06-14 16:37 ` Aaron Jensen
2018-06-14 20:40 ` Alan Third
2018-06-14 21:21 ` Aaron Jensen
2018-06-15 7:02 ` Eli Zaretskii
2018-06-17 11:08 ` Alan Third
2018-06-17 12:03 ` Aaron Jensen
2018-05-24 15:27 ` Eli Zaretskii
2018-05-24 7:19 ` martin rudalics
2018-05-23 6:36 ` martin rudalics
2018-05-23 6:36 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyO48wbywys6SONDdptOU=1SfSGq8q6unCViiSALJb8J_xcXA@mail.gmail.com' \
--to=aaronjensen@gmail.com \
--cc=31546@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).