From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Tue, 3 Dec 2024 21:06:50 -0800 Message-ID: References: <87y12lo9hb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ef498d06286abfcd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38608"; mail-complaints-to="usenet@ciao.gmane.io" To: eliz@gnu.org, 73862@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 04 06:08:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIhce-0009mR-TJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Dec 2024 06:08:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIhcL-0000Ke-Ek; Wed, 04 Dec 2024 00:08:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIhcJ-0000KB-NN for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 00:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIhcJ-0004h3-6S for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 00:08:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:Mime-Version:To:In-Reply-To:References:Subject; bh=eviPXI93ILVls7p5u00SonJU7LV7qFhms9yXXVSJkTk=; b=sBNxt7nisVM90jgm/DkJsrRMNUboSgeHFqlKdx0su13AgMooPBw4gwPRWlsf5eGSzgaWH/nxcgv1YaC8FQN32zVftRNwIkZtHPgTw+SfMbOMeWsy4b8MI3l08GsSQENMTXXLF3zsGUkpkhAY+Y5m2sKP8EXR7iiUG36sINFLj9WO8eSuO7MxZ/Nm4cfstZJWzsGiyASNczKXihrqGTgSkPNdxrVfabrijFG+WB+JJVCKIwQCtwU/0/57EYw3HUzV4L0gJsDz6oeHOzD8EUlCfKl2Dbv3og1V76hesWLe0f7QOnkPSMJKNNhjYMcxtTQH3p2Dsr59LAyTBcZ6yOIPkA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIhcI-0001kH-Gz for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 00:08:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87y12lo9hb.fsf@gmail.com> Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Dec 2024 05:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.17332888786696 (code B ref 73862); Wed, 04 Dec 2024 05:08:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 4 Dec 2024 05:07:58 +0000 Original-Received: from localhost ([127.0.0.1]:33724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIhcE-0001jv-4e for submit@debbugs.gnu.org; Wed, 04 Dec 2024 00:07:58 -0500 Original-Received: from mail-lj1-f171.google.com ([209.85.208.171]:53637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIhc9-0001jj-Mj for 73862@debbugs.gnu.org; Wed, 04 Dec 2024 00:07:57 -0500 Original-Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ffdbc0c103so90152891fa.3 for <73862@debbugs.gnu.org>; Tue, 03 Dec 2024 21:07:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733288812; x=1733893612; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=eviPXI93ILVls7p5u00SonJU7LV7qFhms9yXXVSJkTk=; b=S7o1qgleCoYJK7l6kEdyk9jUr0QrUeHhKUsv51ggGmys2xdw1zs9fuUsiDo+2p1o3w xnayibP6DRh6Hhk0k3sgMXmXWQw6WUJM235o8hLnZnBHuJs0ev15dTO/MmeGANxK1km5 O+AgY7o2iWlsYpduz7bbUXNQZNuz+vTGiNyOVWLc61p/snoaRAp0QsVr4EvXnyHgmWw6 tuV2bP6Y5sT6Grg2hTsPQfV7xN66GIQopBbz123I7XZAeg1RcKxP/h2I4cE2alppCYOx gnbcVJuyNUPNRG/2TCB/K66Gyn6ap6nVELu8IXAQFl0ZLk/ZPhSjjxSL2JE6CokG8Fv6 q2CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733288812; x=1733893612; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eviPXI93ILVls7p5u00SonJU7LV7qFhms9yXXVSJkTk=; b=pxC0J2OmWGWFxLfH9CSLL5WzlvPYd3XeTMis/P5LSkm8gCOJukhnahODUH6sNHlMRx rHPElbs8XXyW1Jp2waKiF3ofa1179wm07naf4RjgY0sMAb+6gtBJTiBWKTj4SFc9LWDB 1lwtemTHPtLSlb887Rt6TDa7hnRgXWHIbI2WaPAi/904wKayumjiM5vA54Th7pGNc/7d 9PuOY/y0l/INKS39hXTokB5v+6gvFANmLMM3+W4E7Su0+ttEfQlQ7grMG/coG2Oauela +4QZUagX733fMDs4Cgbqp/bgL6/uerNOb+RJML+OyluKUpUR80m781WGoCZ9QfMA3edP fmvQ== X-Forwarded-Encrypted: i=1; AJvYcCXeu+z9ZUeGkhbSMXRgNPjB6NvcUJgCLORpJFQNiKO7N36YA6W0sauCs82yS1a+otBg9VQxHQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy4niJlzo2Xv3kc6OZtToexA+5TJ1ls3Fg8VMIyw+iAcFAarD+j 49JWlUphrEbr1nxlyzToybzeSXZghO8L1WAnJPUoJT9tN4OsApqHJ7n3Q6d/QkRyIwnZ91knJAh BEIejeuBAS/RfSn2cWSRdGssxisc= X-Gm-Gg: ASbGncuQ/HBQZtFvNgr1/sJwJnQaZP11ctcRIzpCGdTeMnQUGDQt1QKjY132Fi53oos EgcKLM8sM9NjEWvtD7ARilJsoGl9uFDB3aNZO2Eh7vy3tWp6qtxFfbkg= X-Google-Smtp-Source: AGHT+IHSVDxOz8jsHIJCN9bMgy4Y90xQvxTkC8iIK3oeJXyE91rs99nS371dtyxalK0/kb2K1tIMnVmD2pkXDe2MmTM= X-Received: by 2002:a2e:a9a6:0:b0:2f7:5a41:b0b with SMTP id 38308e7fff4ca-30009ced6cdmr45213131fa.26.1733288812035; Tue, 03 Dec 2024 21:06:52 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Tue, 3 Dec 2024 21:06:50 -0800 X-Mailer: Superhuman Desktop (2024-12-02T20:06:08Z) X-Superhuman-ID: m49fe5m9.8737f723-baf0-4f46-9cdc-545f54d9a7af X-Superhuman-Draft-ID: draft00eed603e6fd921c X-Entity-Ref-ID: m49fe5m9.8737f723-baf0-4f46-9cdc-545f54d9a7af X-Superhuman-Thread-ID: draft002bce3a0e3fe324 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296390 Archived-At: --000000000000ef498d06286abfcd Content-Type: text/plain; charset="UTF-8" I bisected and found that this patch caused a regression in header-line formatting. I don't have the exact reproduction steps yet, but the gist is that I use a header-line with multiple faces in one window, then open a new popup window that has no header-line. The original window's header-line will get its faces changed slightly, but it's hard to tell how. Here's a video demonstrating it: https://share.cleanshot.com/CD9PtVv3 You can see that the padding on the left of the header line goes away and the line numbers change to a variable pitch font. If I adjust my font size, the header line redraws with the proper faces. This will happen randomly, but I can force it with the font size change reliably. I'll see if I can narrow reproduction steps, but it may be worth considering a revert for now. Thanks, Aaron --000000000000ef498d06286abfcd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I bisected and found tha= t this patch caused a regression in header-line formatting. I don't hav= e the exact reproduction steps yet, but the gist is that I use a header-lin= e with multiple=C2=A0faces in one window, then open a new popup window that= has no header-line. The original window's header-line will get its fac= es changed slightly, but it's hard to tell how.

Here's a video demonstrating it:=C2=A0https://share.cleanshot.com/CD9= PtVv3

You can see th= at the padding on the left of the header line goes away and the line number= s change to a variable pitch font. If I adjust my font size, the header lin= e redraws with the proper faces. This will happen randomly, but I can force= it with the font size change reliably.

=
I'll see if I can narrow reproduction steps, but it may= be worth considering a revert for now.

=
Thanks,


Aaron

--000000000000ef498d06286abfcd--