From: Aaron Jensen <aaronjensen@gmail.com>
To: 28483@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#28483: [PATCH] Fix copy-directory creating missing directory
Date: Sun, 17 Sep 2017 13:19:55 -0700 [thread overview]
Message-ID: <CAHyO48wW_sZLZkm9kdtaO7KmzFtYx_6Y7BgKu8tmCroO+quEEw@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkSkoZGzH5L-62Xc=svkffiqdXwovDgZLcT4EgiXSLVuMw@mail.gmail.com>
On September 17, 2017 at 12:48:54 PM, Philipp Stephani
(p.stephani2@gmail.com(mailto:p.stephani2@gmail.com)) wrote:
> This would reintroduce the security hole that e22794867d878d53675fcc91d2ef1ad2494a2ff2 fixed.
Indeed, sorry about that. I’m attempting to patch the downstream
library that led me to this issue:
https://github.com/syl20bnr/spacemacs/pull/9600
> Paul, maybe you want to add some comments to the places where you introduced `directory-name-p' so that people don't attempt to revert these changes?
I’m not sure what Emac’s principles are on it, but perhaps an error
pointing to this change when attempting to copy to a non-existing
directory would help people in the future as well since this is a
change in behavior to an existing function w/o a deprecation.
Thanks,
Aaron
next prev parent reply other threads:[~2017-09-17 20:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 19:10 bug#28483: 26.0.50; copy-directory does not create directories Aaron Jensen
2017-09-17 19:15 ` bug#28483: [PATCH] Fix copy-directory creating missing directory Aaron Jensen
2017-09-17 19:48 ` Philipp Stephani
2017-09-17 20:19 ` Aaron Jensen [this message]
2017-09-18 17:40 ` Philipp Stephani
2017-09-17 19:20 ` bug#28483: 26.0.50; copy-directory does not create directories Aaron Jensen
2017-09-17 20:40 ` Paul Eggert
2017-09-17 23:12 ` Aaron Jensen
2017-09-17 23:52 ` Paul Eggert
2017-09-20 11:26 ` Eli Zaretskii
2017-09-20 18:59 ` bug#28520: " Paul Eggert
2017-09-20 19:54 ` Eli Zaretskii
2017-09-20 23:04 ` Adam Plaice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHyO48wW_sZLZkm9kdtaO7KmzFtYx_6Y7BgKu8tmCroO+quEEw@mail.gmail.com \
--to=aaronjensen@gmail.com \
--cc=28483@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).