From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#46155: 28.0.50; Regression: buffer contents flicker on macOS frames when Date: Tue, 9 Feb 2021 19:11:58 -0600 Message-ID: References: <14839969-6402-9be5-3af3-9ad05f956c84@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18483"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Andrii Kolomoiets , 46155@debbugs.gnu.org, Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 02:13:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9e47-0004cu-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 02:13:11 +0100 Original-Received: from localhost ([::1]:39148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9e45-0006jM-Q3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 20:13:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9e3y-0006iZ-AH for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 20:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9e3y-0007Yu-2n for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 20:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9e3x-0002ou-Rh for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 20:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 01:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46155 X-GNU-PR-Package: emacs Original-Received: via spool by 46155-submit@debbugs.gnu.org id=B46155.161291953710778 (code B ref 46155); Wed, 10 Feb 2021 01:13:01 +0000 Original-Received: (at 46155) by debbugs.gnu.org; 10 Feb 2021 01:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:55160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9e3E-0002nm-Pm for submit@debbugs.gnu.org; Tue, 09 Feb 2021 20:12:17 -0500 Original-Received: from mail-yb1-f172.google.com ([209.85.219.172]:40165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9e3D-0002nZ-3A for 46155@debbugs.gnu.org; Tue, 09 Feb 2021 20:12:15 -0500 Original-Received: by mail-yb1-f172.google.com with SMTP id i71so360058ybg.7 for <46155@debbugs.gnu.org>; Tue, 09 Feb 2021 17:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=18KAtIZQJEUiu+pum0IajiYC0ra8y2q3q52nlrypFmg=; b=dWl9OIUljdSv6mhK/SXR6ObFMxLKC/RB7O71Ae+ZVepditzHv7R4ypCyldpmFicNa3 6z1ivydrRZzMt75aBXnIp1YX1Vf7Zlh1GZzEGoXKk3INd/9kg/jzw/wmcayQ4+afkId3 Lef7gVMb2lRXlAaF5F/HBQ6kIxF/l30T4FiTOH2kIraa0ihoXVDAUQ7O4ay8s+OsS+Bt uxrxdsWwbh1kxASw8PSdizBRKOca0z5RxsUutK06mcMxLCyHU+xoKO6XASjTpozSixMJ BvF5DAKcRDB6gR1N2JUUw+JL/8YzJw3yBFNxO0avzHHMSwO8ZYt/TxZHjlvTIsGXaKc7 2C5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=18KAtIZQJEUiu+pum0IajiYC0ra8y2q3q52nlrypFmg=; b=awMXGGw4eFyCXyjtwVF0Ac8gDQgKUct5LPMtOLFVOPSws4oQ27F8zKpaa5Q7Qrj9b1 3T9Xb3BnQSxeNCGU7YTSAvVLiXekLn4khi7jMDZLZJN1KA6POLhnYaNjgIPwLbhFNunU e/zq7vquxOpgdt4Y4JL9g/Tiimmm10SCSi7t/C29CqjnESDSO+Lcu9RBG6rUZUN6Q08f rBA4jriDEoU363/eisXGujsHKLwjTMV6fc89hrSr9w/5aNmm5b/8VM+tVubIO4fcdELN nIRc7q6WlR2un6iIEO8ITtzCaluhqCTyhmwaF+/txyC2FHDUsRcprZl+LqKLZ7jHFIxs 0j2Q== X-Gm-Message-State: AOAM53200PLAOI8j6ota4CbEe822clwDbXdkdiHC2g9B/VSTavREaXne jDAvHTMc/5Kfk8crDkVc0ubXSvh9Yqfvsg/7qdk= X-Google-Smtp-Source: ABdhPJxV0OgwIYOyS1b8yCXgQ9OC8k9V4h4LZ+xcm9Kr8QZr1S8s1/+XL8jcBsnrT6vEBW3RsPqhbBSmqFWuS0GrcXU= X-Received: by 2002:a25:b8ca:: with SMTP id g10mr743514ybm.517.1612919529553; Tue, 09 Feb 2021 17:12:09 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199747 Archived-At: On Tue, Feb 9, 2021 at 2:08 PM Alan Third wrote: > > On Tue, Feb 09, 2021 at 06:29:22PM +0200, Andrii Kolomoiets wrote: > > Alan Third writes: > > > > > On Tue, Feb 09, 2021 at 11:05:08AM +0000, Alan Third wrote: > > >> > > >> The patch Aaron and Andrii are using calls redisplay() just before the > > >> frame is drawn, but only if it is garbaged. > > > > > > I see from a subsequent email that Andrii isn't using the NS port, so > > > that bit of my message is wrong. > > > > Sorry for kind of misleading you. I indeed use NS port. The receipt for > > minibuffer-only frame flickering was made on nearly recent master > > version with your patch applied. (I must say resizing and fullscreen > > transition looks awesome now, thanks!) > > > > I used GTK port under X in the VirtualBox to test the issue with the > > minibuffer-only frame resized more than once even if the text is not > > changed. > > Ah, OK. I guess it probably is exclusive to NS then. > > The obvious solution IMO is to retain a copy of the old frame contents > and draw them in after resizing, before we try calling redisplay(). > > On the other hand, it would be nice to know why redisplay() isn't > drawing anything... inhibit-redisplay appears to be t when miniframes are asked to resize. Could that be related? I tried letting it to nil and that didn't help. It also happens that setting the resize to happen via run-with-timer fixes the flicker: https://github.com/muffinmad/emacs-mini-frame/pull/32/files#diff-8289c4c5300044ca6d7f9f6f60067a1b5e0d61b6ad0b58720a7c694662ea13abR207 Unfortunately, that prevents resizing when displaying a prompt like `yes-or-no-p`. The other different thing about the minibuffer resizing is it all happens within `read-from-minibuffer`