From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Sun, 23 Jul 2023 09:01:24 -0400 Message-ID: References: <047EC69F-EAC7-458F-A288-13DDC77DE187@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10719"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Aaron Jensen , Kai Ma , 63187@debbugs.gnu.org, Eli Zaretskii , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 15:02:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNYjC-0002cU-3h for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 15:02:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNYit-0002eb-Sv; Sun, 23 Jul 2023 09:02:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNYio-0002eM-DM for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:02:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNYio-0000YF-4u for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNYin-0002Ua-W4 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 09:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 13:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.16901173079559 (code B ref 63187); Sun, 23 Jul 2023 13:02:01 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 23 Jul 2023 13:01:47 +0000 Original-Received: from localhost ([127.0.0.1]:39005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNYiY-0002U7-SM for submit@debbugs.gnu.org; Sun, 23 Jul 2023 09:01:47 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:47420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNYiU-0002Tr-8G for 63187@debbugs.gnu.org; Sun, 23 Jul 2023 09:01:45 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-51e619bcbf9so4497302a12.3 for <63187@debbugs.gnu.org>; Sun, 23 Jul 2023 06:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690117296; x=1690722096; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4JL8Iuroljx2u6Bl581DhOWlfNC54B//SxtpcwtU1Qc=; b=QkXyObg6CJkH1K93qkDHWwSHkgCJmyd1IcaHDJbEVY/P7XUfIhSexMlCth7wBaNmfF R1Il95HhASlpHLco5Euor5lVjWhQvtxPzQd/SRlFvNNrNGIX3OB4ThgFFxq56m+sEyJn PpjAFI79RWwYzYAzr7IgvkRb7DLYq5zHoDDdaN9XSUKnpHkqL5KieIk2CujEe9jxyvXZ dxyKiqcRzeI4SJjposulw/6y8EkBlvq68DMPWdt+EOpY1IMQYrgq+WNoHM5C5YdV4GbB rSt4GloIfV1MYSPX45gr7r/gbHhoU/xGG7ZyggIGrAJ9pMGj4DRet8MafnmMKPqiGG3S KZgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690117296; x=1690722096; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4JL8Iuroljx2u6Bl581DhOWlfNC54B//SxtpcwtU1Qc=; b=Kd5I32ySR3u4tr/oxNN9uH/SUfXZ6HkySghdxSd3jhSiTBO+b58BP/M5EmCz5REjKU Zz8kzJkRrOh3VH+wq1ACGwMOKVO8zv6Sobpg6S8LtFCcpsX7j0eOZZD6hd/9KSn6CZ6t bL/Oo/yeqRhvBf/9p5essl85bKd4lZfA1UaffuDIDnkQtyfDAdG8mQ6WbOoPG+1EyXC5 txvw8tfVgi+7WhjTNfq31fkAK2iLRbKjl45HNtYCpl2ahvcUjbF3S6BgxJqOum3DUlni r+XS9a207F6elnayJiNkf5fnjS01vfpeNxF4BPaNrOEfMkmIHRR6l6e7Nu9A2XuoLi98 GTuQ== X-Gm-Message-State: ABy/qLaKkUjTnsxvbFhyzniaLxfH/NedifmEUJ5+acUKGyiK0Kp4oVVx +7Tzh3u5zfZ+M2hXN33W7z8Eil2tISk/r1mXsoI= X-Google-Smtp-Source: APBJJlHOoimeF4UPAvF0WB0ipae8safHEFRzUv1vypt/ldTrOCpIn9UD1UqQs8Ujs9zqxTCiqpp19UajRLEXG65/tc0= X-Received: by 2002:a05:6402:1214:b0:522:2061:bc84 with SMTP id c20-20020a056402121400b005222061bc84mr2252417edw.24.1690117296141; Sun, 23 Jul 2023 06:01:36 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265898 Archived-At: On Sun, Jul 23, 2023 at 7:20=E2=80=AFAM Alan Third wrote: > > On Thu, Jul 20, 2023 at 10:02:53PM -0400, Aaron Jensen wrote: > > > > I've been using this for about a month now and have seen no artifacts: > > > > diff --git a/src/nsterm.m b/src/nsterm.m > > index 78089906752..d23fb650ab8 100644 > > --- a/src/nsterm.m > > +++ b/src/nsterm.m > > @@ -2708,9 +2708,6 @@ Hide the window (X11 semantics) > > EmacsView *view =3D FRAME_NS_VIEW (f); > > > > [view copyRect:srcRect to:dest]; > > -#ifdef NS_IMPL_COCOA > > - [view setNeedsDisplayInRect:destRect]; > > -#endif > > } > > > > unblock_input (); > > @@ -10435,7 +10432,7 @@ @implementation EmacsLayer > > cache. If no free surfaces are found in the cache then a new one > > is created. */ > > > > -#define CACHE_MAX_SIZE 2 > > +#define CACHE_MAX_SIZE 1 > > > > - (id) initWithColorSpace: (CGColorSpaceRef)cs > > { > > @@ -10621,7 +10618,7 @@ - (void) display > > { > > NSTRACE_WHEN (NSTRACE_GROUP_FOCUS, "[EmacsLayer display]"); > > > > - if (context) > > + if (context && context !=3D [NSGraphicsContext currentContext]) > > { > > [self releaseContext]; > > > > > > I'm not sure what the ramifications are for CACHE_MAX_SIZE 1 on slower > > machines, but I don't notice any performance issues on my M1. > > > > Alan, what do you think we should do? Is there anything else you think > > I should test for the next bit of time? > > I dug out my mac and built this and it still flickers with animated > gifs. It's pretty easy to make happen, so it must be some hardware > performance thing. > > Anyway, I've tried simplifying the double buffering code and put in > all the wee changes I've thought about. Who knows if this will work > any better... > > (It may be worth making the single/double buffering a run-time option > as theoretically the single buffering will perform better, although > always at the increased risk of tearing effects etc.) Thanks, I'll try this one out. FYI there was a typo in a comment: doible Aaron