From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#46617: 28.0.50; nativecomp: native compile cache is not invalidated when file is re-byte compiled and changes Date: Sun, 28 Mar 2021 13:24:49 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrew Whatson , 46617@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 20:26:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQa7n-00010w-OS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 20:26:59 +0200 Original-Received: from localhost ([::1]:41254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQa7m-0005Ml-Q0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 14:26:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQa6s-0004n4-Gl for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 14:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQa6s-0000sO-6Q for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 14:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQa6s-0005wu-27 for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 14:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46617 X-GNU-PR-Package: emacs Original-Received: via spool by 46617-submit@debbugs.gnu.org id=B46617.161695590922791 (code B ref 46617); Sun, 28 Mar 2021 18:26:02 +0000 Original-Received: (at 46617) by debbugs.gnu.org; 28 Mar 2021 18:25:09 +0000 Original-Received: from localhost ([127.0.0.1]:47020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQa60-0005vX-Pp for submit@debbugs.gnu.org; Sun, 28 Mar 2021 14:25:09 -0400 Original-Received: from mail-yb1-f169.google.com ([209.85.219.169]:42753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQa5y-0005ux-Az for 46617@debbugs.gnu.org; Sun, 28 Mar 2021 14:25:07 -0400 Original-Received: by mail-yb1-f169.google.com with SMTP id v107so6448697ybi.9 for <46617@debbugs.gnu.org>; Sun, 28 Mar 2021 11:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RxjY4U6Cv6ehCI5u0rPLqmizAv8oYFhCoJZA4K95u/k=; b=PaVtFzFHSO//izXKlWVSAXnMFu2Gt/sojPjGSUYyibbTO+Qul/j+sK+jVJvYROnUqO TlMvZp6Xy0uY5nENQ4fsdZPI5ZumAI6S/Oek87iWoD45r15OTSGklXbUEDxJJ40M52EG xoTP7mif6bEdF4vXUy7m4EKuxgP59ZZcp9v2i2MVKmSBYGv0dIG6HfmF3L9yTCR6pvTV oxzJm6H6CuZSOfE24l9aGMaTnmGfn+ec2n/Rpp5WuScmHZrQg66XtVwujQpvDLRZaKBO OhQfuLMC3+Bkm5t5kIOpLlxwJ1OhlHsWHHNfdep9sunN+r3JVunnBgMSwFI7uDP7RHGE srIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RxjY4U6Cv6ehCI5u0rPLqmizAv8oYFhCoJZA4K95u/k=; b=cWJT3zKLTVitqa9qJ5V53ZrajMCgBwi6wDBHUMs5gOjzOS9KscvoMZXFtwOyIDYjhJ NinleaKaewvDPwV4mb1V2n7/fbie7uzJBvHv6ESMB6fuLZynpETFgaONIa0R1t3Yk3Qh EHHCzVPRFCvlm86x6cKKgyJ+mmLVuGICt58Ov/Y4/02KV7DfYmIvrT848+L6EAeUC0Sy eA9IyPt2h/j/Lbd3iLLJoYC9jt1FBHnHs/6DOLotCzCrAyvpIgoPH/saIp8TC2RcEHLH 5I7tE/KSieyxk5YvPeHt115X34gVz1JVy/wixD8LNpGeCMTkCfN5I7YTcKJes2+neaKh dTdQ== X-Gm-Message-State: AOAM531VraZ3pMxL613AMzlg0ORaxnwh5oHlhYjtn66pqdnYhSUSB1kp Q42SdtAFcUpKbIQIWvbUDkoh1zDegT30CL2mSkY= X-Google-Smtp-Source: ABdhPJwZWikxhUPKGw/1zLH/+JJTvj5+rq/5A2zZoyy8pW1HLBYpqMkZCs4W1o4RWsEYKWQKYDn5IuDmix/mrpj0Hq4= X-Received: by 2002:a25:afca:: with SMTP id d10mr31092436ybj.517.1616955900138; Sun, 28 Mar 2021 11:25:00 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203199 Archived-At: On Fri, Mar 26, 2021 at 2:54 AM Andrea Corallo wrote: > > Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > Aaron Jensen writes: > > > >> On Sun, Mar 21, 2021 at 3:54 PM Andrea Corallo wrote: > >>> > >>> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of > >>> text editors" writes: > >>> > >>> > >>> Okay I've added `comp-lookup-eln' son now the user can search if a > >>> certain .eln is in reach in `comp-eln-load-path' for a given .el. > >>> > >>> So now one can use the following to force a native load. > >>> > >>> (load (comp-lookup-eln ".../foo.el")) > >> > >> Okay, and that would return nil if it's not native compiled, which > >> would be their cue to native compile it, yes? > > > > Yes `comp-lookup-eln' will return nil if the eln is not found. > > > >> That's nice to be able > >> to force load it. > >> > >> Without doing the modification date stuff you mentioned or purge > >> before byte compile, native compilation ends up having to be a concern > >> of anything that's doing byte compiling, which is unfortunate. > > > > Say anything that's doing byte compiling deliberately capturing > > environment values yes. > > > > Andrea > > I've reintroduced the file timestamp check on the eln files being loaded > with 79b8b6ca45. This should protect us from loading stale eln that > captured some stale env during compilation. What does it compare the timestamp of the eln to? It doesn't appear that it's the elc, which I believe is the only thing that would help with the issue we're seeing in straight.el. Is it the el or something else? A related issue I've found is that now when you load an elc explicitly, it triggers a native compile for that file regardless of whether or not one has already been done. One general question is, is the eln a compilation of the elc or the el? Thanks, Aaron