From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#32932: [PATCH v2] Fix more drawing bugs in NS port (bug#32932) Date: Fri, 9 Nov 2018 05:45:34 -0800 Message-ID: References: <20181109090855.GA31723@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541771073 25963 195.159.176.226 (9 Nov 2018 13:44:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2018 13:44:33 +0000 (UTC) Cc: 32932@debbugs.gnu.org, boris@d12frosted.io To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 09 14:44:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL75I-0006cX-H3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 14:44:28 +0100 Original-Received: from localhost ([::1]:34185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL77O-0007xS-Q5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 08:46:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL779-0007x9-BT for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 08:46:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gL76z-0005nf-BO for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 08:46:17 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gL76o-0005j2-Eq for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 08:46:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gL76o-0005Hv-8A for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 08:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Nov 2018 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154177114220298 (code B ref 32932); Fri, 09 Nov 2018 13:46:02 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 9 Nov 2018 13:45:42 +0000 Original-Received: from localhost ([127.0.0.1]:42324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL76T-0005HK-OL for submit@debbugs.gnu.org; Fri, 09 Nov 2018 08:45:41 -0500 Original-Received: from mail-yw1-f65.google.com ([209.85.161.65]:41883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL76S-0005H7-CN for 32932@debbugs.gnu.org; Fri, 09 Nov 2018 08:45:40 -0500 Original-Received: by mail-yw1-f65.google.com with SMTP id c126-v6so1619326ywd.8 for <32932@debbugs.gnu.org>; Fri, 09 Nov 2018 05:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=eAjReWs3KDYptUw8ssFqSxiVPD3tGnozRvlVyJ3VEwo=; b=BatT1+eeQk8FRtWEi6j99CyZWjZgfOXPlWoIjbumwk0YSZ/K8cFCsbuI77FNurv5pQ XLB7mLvY7MuojJXLNzZv0ND+SMHAOxZBSJ9YoLalXxi6huXZxRkHbNF4K9evZWeo8Q9K UlFvC7tMiKiHgV9bkGpr2Qt/LuC191u39cIyED74VLNQsXs79DZQi/DjuqAbXGWbSjIO QDC1jD6x94mKJjtZkWlWORoHtsIWw8PTLUFoEMHY/iuz6tOBiWs5fr0hKq9NZb+b2WDi dPuvQPcBPgYP5Bip4BxcNoolc2EiApMmzT7NC2FCftkNOThFdr+pG9E4ZY7ZeefOlY89 RoCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=eAjReWs3KDYptUw8ssFqSxiVPD3tGnozRvlVyJ3VEwo=; b=VZXI+Ol8DRADJ8a3E2bkWY1Wbw2uKqRNGpUyRZ5aWdu44rO8gOfx+aBK2Y7Ge/xy47 gRxAMSK24DU7imcwdLHZy8tVsGuEQh9C34kwRdEDS5ajL9VDfjR1vIJ2RY1S0fcuz0u6 ljdjaOEjul+9dOumJQ8JZQkdqFjVqiKYTmTQvrHdWh3iQM2iRtr2rEMLUOIsqFtvyrxK xw9nS7DWWQGr1YFa12Cb3mx78drnlC5SgBbsFV+ricCjc3btTsYjX3qafbzoTvdYNpT+ iR97bp0ExDNMaQgUecGPegoB2IQzjhqf3exptcepNFciwleNNNjTnW8FH4LeHwc2VZhy J2fA== X-Gm-Message-State: AGRZ1gJgiciBdfrGj+g/FHpIzQl3n/zMYdBuCk2rxJzU15TRFU5wyc+I 4j5I9wk34lLqRvgN7I9fEeRtwmoXpvuWHyhjriE= X-Google-Smtp-Source: AJdET5f7a4bu8ItNMbaaT3KuBRxIN5Lvj2zF2nY31pUliYnR1SrMp4PcKE/nAFaZ5PfWH1Nfpzd76U9/Rmho6rpVBLM= X-Received: by 2002:a0d:ce47:: with SMTP id q68-v6mr8286041ywd.63.1541771134820; Fri, 09 Nov 2018 05:45:34 -0800 (PST) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Nov 2018 05:45:34 -0800 In-Reply-To: <20181109090855.GA31723@breton.holly.idiocy.org> X-Mailer: Airmail (528) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152218 Archived-At: On November 9, 2018 at 1:09:00 AM, Alan Third (alan@idiocy.org(mailto:alan@idiocy.org)) wrote: > * src/nsterm.m (ns_row_rect): New function. > (ns_clip_to_row): Remove function. > (ns_copy_bits): Fix mistake. > (ns_draw_fringe_bitmap): Stop using ns_clip_to_row. > (ns_draw_window_cursor): Stop using ns_clip_to_row and perform a > display when not in redisplay. > (ns_update_window_begin): Remove redundant code that never executes. > ([EmacsView drawRect:]): Show the rectangle being exposed in NSTRACE. > * src/xdisp.c (expose_window_tree) [HAVE_NS]: > (expose_frame) [HAVE_NS]: Redraw even if the frame is garbaged. > --- > I realised about 4AM that I'd screwed this up. This one should replace th= e > previous patch. Sorry for the hassle. Thanks, this applied. I can=E2=80=99t reproduce the issue w/ my repro. I=E2= =80=99ll try it out for a bit and report back. Cheers, Aaron