From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#32932: [PATCH v2] Fix more drawing bugs in NS port (bug#32932) Date: Fri, 9 Nov 2018 06:15:24 -0800 Message-ID: References: <20181109090855.GA31723@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541772855 18077 195.159.176.226 (9 Nov 2018 14:14:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2018 14:14:15 +0000 (UTC) Cc: boris@d12frosted.io, 32932@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 09 15:14:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL7Y1-0004XL-W0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 15:14:10 +0100 Original-Received: from localhost ([::1]:34376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL7a8-0001n3-EC for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 09:16:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gL7Zw-0001ls-5U for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:16:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gL7Zq-0000ZQ-1I for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:16:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gL7Zp-0000ZM-Se for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:16:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gL7Zp-0005yv-Me for bug-gnu-emacs@gnu.org; Fri, 09 Nov 2018 09:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Nov 2018 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154177293222955 (code B ref 32932); Fri, 09 Nov 2018 14:16:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 9 Nov 2018 14:15:32 +0000 Original-Received: from localhost ([127.0.0.1]:42339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL7ZM-0005yB-Bf for submit@debbugs.gnu.org; Fri, 09 Nov 2018 09:15:32 -0500 Original-Received: from mail-yw1-f68.google.com ([209.85.161.68]:41976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL7ZK-0005xx-H5 for 32932@debbugs.gnu.org; Fri, 09 Nov 2018 09:15:30 -0500 Original-Received: by mail-yw1-f68.google.com with SMTP id c126-v6so1656372ywd.8 for <32932@debbugs.gnu.org>; Fri, 09 Nov 2018 06:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=FGqGAF1oEWMLT4+A10JjITLBuFaZO0Mk4UI/PCOoZOA=; b=t83EfE7IzdS6IJW88izPollHWqTKCHf7IYzjElK4FQgf9654TjPxEDRau/NvHxPcF9 JojabyG29PSt+t06xWbmmuFpJ/PKTe3+FJWdVYhMQyRc/baUXK79Ldj7iZBmDYr8F+sN Xg/EQhcQUIgynRgix+ruZ4eD88evqFg4OzRbXJyZEljx66IYcz//Y+Seuqhw63PxLr99 ECIr4LgKOQFoNPAFZZ6AOYz4QlOdsx+Gf1JP+T7Epaqw3UIRnYv63VrMgKqTv0qWqjyX ZLanzMj+8PfXIV065e6Ydq5gXsNQd7roaiv6Bh/O9BXg+d4DfhU+5XI4X4xNYSdmRLiV hgKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=FGqGAF1oEWMLT4+A10JjITLBuFaZO0Mk4UI/PCOoZOA=; b=L3lVqN9UPN14LyzfwGzMWDFshWk8xzhNDX6vS31xBGyqjarn+FcTF/uPfM+rGMiXHb OCEBJofFVghM9k5PKrNPl5jPG6Z8De12kDL2xzs9Orys+l88GEizJK0yOHuZhLkouit6 gDSe7g0OM8gFwZZCr2AruLT7rjteEm0zWzOSwerrr/auE4s6S4AuvWDlntAzxhRoQNCa JExCkVg3vuirnx4+OuUN+uHygg6FI2rbni86a7LGDxa5i8k9uF/UBEX9VFVUkYy13ZYy SjHxhdf8iPoGgD7YGTdXEInK39LDwtkMGihZ/B37c6SIR7hye3kUclMW2gMtAtp+4jFD NPRw== X-Gm-Message-State: AGRZ1gJLkb1IqwNvgLS/qkdFPUPmwscXjp8s2gpGyUBPKrlUcl5bu5do duMN9AyaButYB5AZ8oaMDcEFcQLJSh6hDjzDlAI= X-Google-Smtp-Source: AJdET5e9LdH9KAQMQ9BdSYhf9H1OrPG/L4EHGnkzFXvEH6buK1hVlNzgPSkRfoLoFKwMQuF7nRZfvGqBFbjT/4ypAtA= X-Received: by 2002:a81:256:: with SMTP id 83-v6mr8590649ywc.344.1541772924976; Fri, 09 Nov 2018 06:15:24 -0800 (PST) Original-Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Nov 2018 06:15:24 -0800 In-Reply-To: X-Mailer: Airmail (528) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152220 Archived-At: On November 9, 2018 at 5:45:34 AM, Aaron Jensen (aaronjensen@gmail.com(mailto:aaronjensen@gmail.com)) wrote: > On November 9, 2018 at 1:09:00 AM, Alan Third (alan@idiocy.org(mailto:ala= n@idiocy.org)) wrote: > > > * src/nsterm.m (ns_row_rect): New function. > > (ns_clip_to_row): Remove function. > > (ns_copy_bits): Fix mistake. > > (ns_draw_fringe_bitmap): Stop using ns_clip_to_row. > > (ns_draw_window_cursor): Stop using ns_clip_to_row and perform a > > display when not in redisplay. > > (ns_update_window_begin): Remove redundant code that never executes. > > ([EmacsView drawRect:]): Show the rectangle being exposed in NSTRACE. > > * src/xdisp.c (expose_window_tree) [HAVE_NS]: > > (expose_frame) [HAVE_NS]: Redraw even if the frame is garbaged. > > --- > > I realised about 4AM that I'd screwed this up. This one should replace = the > > previous patch. Sorry for the hassle. > > Thanks, this applied. I can=E2=80=99t reproduce the issue w/ my repro. I= =E2=80=99ll try it out for a bit and report back. I=E2=80=99ve twice seen a full frame blank. The first time was when pasting something using cmd+v (it only happened the once) and the second time, I don=E2=80=99t recall what I was doing. The first time it repainted the entire frame with its two windows fine. The second time it repainted the cursor on the inactive window and a seemingly random rectangle on the active window that spanned several lines down below the cursor and half the window=E2=80=99s width to the right. I=E2=80=99ll keep using it and see if I can come up with any repros. Aaron