From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Date: Mon, 1 May 2023 09:55:58 -0400 Message-ID: References: <87ilddec31.fsf@yahoo.com> <87edo0exct.fsf@yahoo.com> <83wn1sns1n.fsf@gnu.org> <87pm7kchqw.fsf@yahoo.com> <83pm7knpzi.fsf@gnu.org> <83o7n4noql.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, alan@idiocy.org, 63187@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 15:57:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptU25-0009hB-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 15:57:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptU1g-0001z0-0J; Mon, 01 May 2023 09:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptU1X-0001xx-U4 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:57:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptU1W-0005Gj-PA for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptU1W-0002Tg-I8 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 09:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63187 X-GNU-PR-Package: emacs Original-Received: via spool by 63187-submit@debbugs.gnu.org id=B63187.16829493789467 (code B ref 63187); Mon, 01 May 2023 13:57:02 +0000 Original-Received: (at 63187) by debbugs.gnu.org; 1 May 2023 13:56:18 +0000 Original-Received: from localhost ([127.0.0.1]:40778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptU0o-0002Sd-GT for submit@debbugs.gnu.org; Mon, 01 May 2023 09:56:18 -0400 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:52248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptU0l-0002SX-6R for 63187@debbugs.gnu.org; Mon, 01 May 2023 09:56:17 -0400 Original-Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-24decf5cc03so1076892a91.0 for <63187@debbugs.gnu.org>; Mon, 01 May 2023 06:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682949369; x=1685541369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UbMMrEAFqjhlvN4adfNcKsxbIyFEb47gKH5cnmTeW+s=; b=EjJld8v3MyjoRW9wO2XZrMQiEFuofvtJRRquxQENl87KvNvEPRYjNxmX+7oLLbQLsP 6OlRn5xy17vdZM0cCuMN++8dSpLHzwb234I95siHD2xexE7XvA5dhT9nZQqe3J/M96UD 2LiLUSxUFdIoj+BcLwm8e+FbOtMC0i7rPZRUeQNYhhAwx+3/WbxaBLFtxmZgaVydfxnk 9ZlmVt4+kiLlgvDfFvn+ERZJTjdaGX8cAmVoJJn/r8V8EWqvnH888nUt3LR4Up5kLhFe 29hFiMaKKo2jFaS6Q1viPw5FifU2iMYfKnssrl7tCBbEX+QVVO2GfKB74XrxRtlMq+Pu FEsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682949369; x=1685541369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UbMMrEAFqjhlvN4adfNcKsxbIyFEb47gKH5cnmTeW+s=; b=UIBOycRQMmB8X/LRAXgRzIAu+wKmpDD/WLCb85uEXy7BLA7ivGR2XWwnA44rJXG8uZ pLpWbChtL6VLA3Ohv/8EkQiVo6ebhxHpBbU+5LFzMoMJydqag6M2/FpyEnnhv2EpfwE6 ffNZkG4u/s7sh8yiluIUrWEyxXveVaU45pxF0rA13RZ31djbw/k+IE+k+nElxMrzwNrt b3e6ti5lLYujbO8ZBvkcL5hoo3bHw8uPjYN24CJqWfsG8xrAhodHvF/o806t+cDmlkio We0uz7uuczHJAehqg2vgLKBOI7ElSMVrvPhs+HK5WMP1DIkMNbe9o+zrV76fJdz7uZ0A fDVw== X-Gm-Message-State: AC+VfDwZ7RMOGI+hOq/YecsliAiTg9MmuWISk1FyPwfOQU+KVZyXErlk JPjS69lRzFLtdeByTs+zj8koJRMmwR9VWbwWCsQ= X-Google-Smtp-Source: ACHHUZ4VMmYJV6H99CxSHl2WBig/77GV6l/hlTQoe6LnWrmQxkMxmp1ifKOwZa29lYfl9p1r+OzzZ1234prpFiTFTrM= X-Received: by 2002:a17:90a:7601:b0:24e:993:115c with SMTP id s1-20020a17090a760100b0024e0993115cmr2286417pjk.43.1682949369183; Mon, 01 May 2023 06:56:09 -0700 (PDT) In-Reply-To: <83o7n4noql.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260871 Archived-At: On Mon, May 1, 2023 at 9:51=E2=80=AFAM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Mon, 1 May 2023 09:47:50 -0400 > > Cc: Po Lu , Alan Third , 63187@deb= bugs.gnu.org > > > > { > > NSRect srcRect =3D NSMakeRect (x, from_y, width, height); > > NSPoint dest =3D NSMakePoint (x, to_y); > > EmacsView *view =3D FRAME_NS_VIEW (f); > > > > [view copyRect:srcRect to:dest]; > > #ifdef NS_IMPL_COCOA > > [view setNeedsDisplayInRect:srcRect]; > > #endif > > } > > > > Why is the source being marked for redisplay? I would expect the > > destination to be marked as such, or am I missing something? > > IMO, both should be marked for redisplay. Or maybe I don't understand > the significance of marking a rectangle for redisplay. For reference, this is in `ns_scroll_run'. Only the destination is changed, right? I imagine the source would be effectively marked when it's copied into, so marking the source in this code would be redundant, unless I'm missing something?