From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Wed, 4 Dec 2024 19:06:26 -0800 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002508bc06287d2fb1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1965"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Trevor Murphy , Eshel Yaron , 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 04:08:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ2E3-0000PO-Bw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 04:08:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ2Dj-0003gR-C1; Wed, 04 Dec 2024 22:08:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ2Di-0003gD-Gu for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 22:08:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ2Dh-0005Ac-UL for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 22:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:References:From:In-Reply-To:Mime-Version:To:Subject; bh=fO76f3TsnQ5Nh3R6g49Nm8e0kT0GPCXqsFxc1YTfz04=; b=rNWQ8baD6Yt+6iC+L9hW1Lv/rJI+UyblTRr9qjCnJso/J1oVnmH9Fbz46cEtJKZn0yvqY3LP5lck3hVS7Oiwi6MY6m13qT3zdbE72QK325aWHdEr2cpyvDZF1WyR9gfU0Fw4XNUerqImOLzoUPkHgubrVz+HQ31md3TvnJBuShbW6Q318Z4KOhwPtvNQP/y88/HtjwP4+Kakm8eVT4/xKBf/yoMRSVMLZoXlp7DjtTwXpVLmcxHQH+IBYJOZYJXbJWQkrOjoXBJv6GqCfb1pdcUOeGXSdxfoD1SgAHvzNd0mzsuDtolWrx+y+cP4VwGWFiVhPL9l+CLszgAORcroRw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJ2Dh-0000PY-PF for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2024 22:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 03:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.17333680551542 (code B ref 73862); Thu, 05 Dec 2024 03:08:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 5 Dec 2024 03:07:35 +0000 Original-Received: from localhost ([127.0.0.1]:37607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ2DH-0000Oo-9e for submit@debbugs.gnu.org; Wed, 04 Dec 2024 22:07:35 -0500 Original-Received: from mail-lj1-f180.google.com ([209.85.208.180]:61941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ2DF-0000OY-JD for 73862@debbugs.gnu.org; Wed, 04 Dec 2024 22:07:34 -0500 Original-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ffd796ba0aso3583831fa.3 for <73862@debbugs.gnu.org>; Wed, 04 Dec 2024 19:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733367987; x=1733972787; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fO76f3TsnQ5Nh3R6g49Nm8e0kT0GPCXqsFxc1YTfz04=; b=gL8HbyYCp2+FpphfDEgO00q1tOwHza+f9mboVq7C4SWBS1QeNOO+MIGWvStCLf6r71 JCXbSQVvVfbNojhZRhD7NMRMaueu/3+5Dw7VjjrpKD9wHJKXFWs1STUN+Nz/usN7w3PJ fD0WAfCeC2/mgdM8qxYkuk1sO51S+M/0ExQ4NbVtocJcfsknnSVY2gNMsQ8xrh50Nffo BHRua1Do/bw/cj+wefqIS+u37vTeDBNl3+N8zhvAfCcL9uYirZ5y/7MtEQKK1auvtlGM mfGt5hfmsLn0EZztzjlgOHJ+A/vl6637g2s3Gvk163Lr9ByAkJTVmy35VnPWSnVsbsNa BeKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733367988; x=1733972788; h=cc:to:subject:message-id:date:references:from:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fO76f3TsnQ5Nh3R6g49Nm8e0kT0GPCXqsFxc1YTfz04=; b=do4E4ewj3PcLC38gLKDI4uiwDChLPYSt3qL7gHjF/QzQSJ9rTKDSukRp3k1WmCr8Z6 PSara+SVLKtHtMGle1ZjGacqVxBFZQl0f4IdnZOrBDfwiRzXXMYrUMGdb/fz7MJmfQw5 mP2RdOFQU3zvvzrNNJZTxxuUVhCPWD5RI/18LuVS6rTL4EkjlicsQSlaoL+se2VhCqMQ 5ovEy9dw5fHVR+O8NZM2PK5BxjI4aQOYhlIYsgpGVTDBJB5VtLnenG5SQI78bdzZ8IT4 tfYqAZk7cnGeBcNzKBUqFe4qh/16RuTN7o2IuXLxOn/Kul2RUS+DfxVV/SPIFCvpYfYg t7jQ== X-Forwarded-Encrypted: i=1; AJvYcCVVwYo50/nThYfBm9oElMYOQ+4HTHZ5UjIHuhcyqYL4dwQLrDBJVOvnUQY7R6ohyCqE2CjxJQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywc9XL6chkaAvN1Of2uB2gZb4dM4Qhdm8PyWyoDppeb5aQgE4tE ToiQk1AjhR3DgdEMt0qcyvE5etnqo3qEpshUibTFZ3lvh+fztqG5cKlkVNvVDAEC+ZbCuTJN6UL Sae5LOp1iuaZKnx7EMYD1JxFu7TI= X-Gm-Gg: ASbGncu9Auh9CcPWZgtBqycugnMk1thSPNU8d0CuWXigi98cfR7CbavbFD8vEbp7D3k GVzEIwNLsuFQHOiTmg+kPUVlpnnkD3a+kkJ67FyKQGH5bSPCYKV+/rzs= X-Google-Smtp-Source: AGHT+IHxs/L8AGkHUtp9kfH5+YPHTJhbaKKKxNnYniG58aqArP2fkZrIJRfVgZiWGfHe74UuE0OHlvbPyq1i9pg4peY= X-Received: by 2002:a2e:a5c1:0:b0:2ff:e5af:e67b with SMTP id 38308e7fff4ca-30009cb1899mr58014211fa.35.1733367987239; Wed, 04 Dec 2024 19:06:27 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Wed, 4 Dec 2024 19:06:26 -0800 X-Mailer: Superhuman Desktop (2024-12-02T20:06:08Z) X-Superhuman-Draft-ID: draft0050474ea6c472d9 In-Reply-To: <86wmgfzhgc.fsf@gnu.org> X-Superhuman-ID: m4aqj618.b97eb954-04e7-46a9-bf78-8bf8e57f21c3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296438 Archived-At: --0000000000002508bc06287d2fb1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 04, 2024 at 5:49 AM, Eli Zaretskii wrote: > Aaron, it would have been more useful to CC Trevor, who is the author of > that changeset. I've added him now. > > You're right, I realized that too late. Thank you for the reminder. I'm able to reproduce this with the mode-line as well, so it appears that > there may be a bug there too in the code that was copied to implement the > active/inactive faces in the header line. It's entirely possible that > there's a bug in nano-modeline, but it seems suspect that code was added = to > consider windows and now this issue triggers when new windows are created > (and possibly when selection changes, I haven't eliminated whether or not > that's a factor yet). > > You were able to reproduce what? I don't think you posted a recipe to > reproduce the problem. Please do, if at all possible, preferably starting > from "emacs -Q". > I didn't =E2=80=94 I thought I mentioned that. I had intended to provide on= e as soon as I had a chance to, but it turns out that Eshel encountered the same issue and provided a recipe (thank you, Eshel). The only difference in my case is that face-remap-set-base is used, rather than face-remap-add-relative. As far as I can tell, this same bug occurs in the mode-line as well as the header-line. I.e., there was an existing bug in the mode-line and it was replicated to the header-line after the two new faces were added. Thanks, Aaron --0000000000002508bc06287d2fb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Dec 04, 2024 at 5:49 AM, Eli Zaretskii <eliz@gnu.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">

Aaron, it would have been more useful to CC Trevor, who is the author of that changeset. I've added him now.


You're r= ight, I realized that too late. Thank you for the reminder.

I'm able to reproduce this with the mode-line as well, so it appears th= at there may be a bug there too in the code that was copied to implement the active/inactive faces in the header l= ine. It's entirely possible that there's a bug in nano-modeline, but it seems suspect that code was adde= d to consider windows and now this issue triggers when new windows are created (and possibly when selection ch= anges, I haven't eliminated whether or not that's a factor yet).

You were able to reproduce what? I don't think you posted a recipe to reproduce the problem. Please do, if at all possible, preferably starting from "emacs -Q".

<= /div>

I didn't =E2=80=94 I thought = I mentioned that. I had intended to provide one as soon as I had a chance t= o, but it turns out that Eshel encountered the same issue and provided a re= cipe (thank you, Eshel). The only difference in my case is that face-remap-= set-base is used, rather than face-remap-add-relative.

As far as I can tell, this same bug occurs in the mode-line as wel= l as the header-line. I.e., there was an existing bug in the mode-line and = it was replicated to the header-line after the two new faces were added.

Thanks,

Aaron
=
--0000000000002508bc06287d2fb1--