From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#59790: 30.0.50; ns-use-native-fullscreen is not respected for first use of initial-frame-alist Date: Sun, 17 Nov 2024 00:00:07 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000009c4bd9062714ac93" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7557"; mail-complaints-to="usenet@ciao.gmane.io" To: sean@farley.io, 59790@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 17 06:02:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCXQX-0001rL-6S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Nov 2024 06:02:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCXQC-0003Wo-Gq; Sun, 17 Nov 2024 00:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCXQA-0003Wd-Vp for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 00:02:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCXQA-0007Ni-Mv for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 00:02:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:Mime-Version:To:In-Reply-To:References:Subject; bh=TTW25+iZC6t49trGOQsASkwyyctx759viuZySYqCbIw=; b=bkCZLm78UG9VBzoK3CDUOwnmB/bRXfp0KHAuVuFFWNqXz8bX6gqeP5keAovP5gOO/jo3GYfQvSL7eRQd294RB0l1fTYkahX/9r3cJMvxxy5xKtbNE1Tg1CstbK31Hk9IHfq/c9RRaBO5r0HAKTcvA0Y6aOyMeC/cZ28UZL6RGIH9l8odR41TDH08ID7C/q+zivsC8/NBjoHoGl88jOwju0yLho+1uiB+SE+YwMk892YkpLEVO34+S+wtI9ALILfDueZEw1X254fuTerjIkBD4aVK/xFicQG+ParDzybqYBPrqjQTlVzHCpQzlSQ2fN1RVgPYe+0t8/NdA4+l9AXnfg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCXQA-0003mf-IP for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2024 00:02:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2024 05:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59790 X-GNU-PR-Package: emacs Original-Received: via spool by 59790-submit@debbugs.gnu.org id=B59790.173181967314490 (code B ref 59790); Sun, 17 Nov 2024 05:02:02 +0000 Original-Received: (at 59790) by debbugs.gnu.org; 17 Nov 2024 05:01:13 +0000 Original-Received: from localhost ([127.0.0.1]:55521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCXPM-0003le-Os for submit@debbugs.gnu.org; Sun, 17 Nov 2024 00:01:13 -0500 Original-Received: from mail-lj1-f178.google.com ([209.85.208.178]:54609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCXPK-0003lV-2w for 59790@debbugs.gnu.org; Sun, 17 Nov 2024 00:01:10 -0500 Original-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2fb3110b964so6827181fa.1 for <59790@debbugs.gnu.org>; Sat, 16 Nov 2024 21:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731819609; x=1732424409; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=mA6VJa2IMVWHbwBws5nwtOQx99zWelJ4bKo7QYGShyo=; b=lwPpDFGM1uZs7o9YDuINNvbG4Qa9vzSwLMtcWyIHcFiLM6ZLWQaEqfOrCZb2Nubvo2 tkB8ZsMyTctYnMF3CW3n6q0Yn0YOxzis5Fo5o7knqJJGM5dTroO7ULIbw0JVmiWDivBp yTdwSWvBWI64bkzVbTq/wXTR4STyeneaIuemaNQ0t5ku2JSCaRfy1fOjCIqPj8FsbYGI u6aTuJ88rm7rF2M4VMpQf7p7UE8doM9+Ksiy/gsVcvIC1NiCH2nvWVKg50/IB6aaHC7e LmRb7X4Kf56Vk4m/uMeYz/MCqw/eifzswwS/OGk0ff2DpRj9Gsk1M2zIMqhXQF7EkvKT 8DXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731819609; x=1732424409; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mA6VJa2IMVWHbwBws5nwtOQx99zWelJ4bKo7QYGShyo=; b=l84n73SypHKBJx+DMFqeLBkCVIIjErWXubhjg6fhyasa/mDfIuBe+lK7wuHxlH7cVU u0YTnwy8iHBhGeUenaRaN+ClEblRbKa/SnE/LVDJREtSLx/A7J14m/e86Jgp64uYgQTF u3JgIuu0IJlm3q21Dfg9BtiK1DzRtIP/C0VgSaxr11ie0hQfiJ1MPpMHmCSIJ1wuAExK dY1Jnfgn4R/WdcM1B8c0iEQOcdvc9cthiXHXa+qMwt6UO7FCHUGwjvMx7DrzVF11bLFp 04jFcAp8v7ItCh2odLle8ZZ+lA8yylB++pR2XwxozM5GofWyEadpMVHlfnLq4LD19tFE y+Ng== X-Forwarded-Encrypted: i=1; AJvYcCWhBb37/GscnfJ4f6ipafw0mRIxEMLKaj2oETL/Vl01kBJ+zgK0oAhm0frsna91zS/jLGukCQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzNs0bTBAmw15drAUufi++ERFGUGtTStQFGOT/TKnNdKLwuFCVG ybarxCjVTd2Q8Sm9vX7jIGjyPFeCOEs8n4owhp80yXG184z8wAV5A8ic3VhDwynQQtw55CS079h LPjqMjZf1eDc+STBVWD8d+yHyOVEL+A== X-Google-Smtp-Source: AGHT+IEiGpRdwRd1tQZ7Utta9nX/BYFNTIYskVUg+mmW0p+Ql9tVoC4RCsgxrgmKeiv3rYNulMWaSQ2/X8NK/PtefHI= X-Received: by 2002:a05:651c:1611:b0:2fa:f5f1:2539 with SMTP id 38308e7fff4ca-2ff60690c0dmr38923691fa.24.1731819609007; Sat, 16 Nov 2024 21:00:09 -0800 (PST) Original-Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sun, 17 Nov 2024 00:00:07 -0500 X-Mailer: Superhuman Desktop (2024-11-13T20:05:52Z) X-Superhuman-ID: m3l4o0ha.3ede6a65-5f18-4277-be3f-43ecc81bc550 X-Superhuman-Thread-ID: draft00357cfa3f2b6990 X-Superhuman-Draft-ID: draft0050d702bd8079b3 X-Entity-Ref-ID: m3l4o0ha.3ede6a65-5f18-4277-be3f-43ecc81bc550 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295505 Archived-At: --0000000000009c4bd9062714ac93 Content-Type: multipart/alternative; boundary="0000000000009c4bd7062714ac91" --0000000000009c4bd7062714ac91 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =E2=80=8BThe bugged behavior is that `ns-use-native-fullscreen' set to nil = is not read when launching emacs. The attached patch should fix this. The problem is that when the frame is made, the current value of ns-use-native-fullscreen is copied to a variable and that's only reset when the frame goes from fullscreen to windowed. I believe the original intent was to ensure that the mode could not change while the window was fullscreen already. This resets the value of fs_is_native if the frame is not already fullscreen, which allows it to respect the value at the time of the first fullscreen. Without this, the only way to get the behavior that Sean is expecting is to set ns-use-native-fullscreen in early-init, which should not be necessary. --0000000000009c4bd7062714ac91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= =E2=80=8BThe bugged behavior is that `ns-use-native-fullscreen' set to nil i= s not=C2=A0read when launching emacs.

The attached patch should fix = this. The problem is that when the frame is made, the current=C2=A0value of= ns-use-native-fullscreen is copied to a variable and that's only reset= when the frame goes from fullscreen to windowed. I believe the original in= tent was to ensure that the mode could=C2=A0not change while the window was= fullscreen already.

This resets the value of fs_is_native if the fra= me is not already fullscreen, which allows it to respect the value at the t= ime of the first fullscreen.=C2=A0
=
Without this, the only way to get = the behavior that Sean is expecting is to set ns-use-native-fullscreen in e= arly-init, which should not be necessary.

--0000000000009c4bd7062714ac91-- --0000000000009c4bd9062714ac93 Content-Type: application/octet-stream; name="0001-src-nsterm.m-EmacsView-toggleFullScreen-Reset-fs_is_.patch" Content-Disposition: attachment; filename="0001-src-nsterm.m-EmacsView-toggleFullScreen-Reset-fs_is_.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: d2c5bd8f48729700_0.1 RnJvbSA4ZTYxMzhlYTI2Zjk5Njg5NWQyZTYwZGFkN2VjMTEyZTkxNjczNmE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYXJvbiBKZW5zZW4gPGFhcm9uamVuc2VuQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAxNiBOb3YgMjAyNCAyMDo1NDo1OSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdICog c3JjL25zdGVybS5tIChbRW1hY3NWaWV3IHRvZ2dsZUZ1bGxTY3JlZW46XSk6IFJlc2V0CiBmc19p c19uYXRpdmUKCi0tLQogc3JjL25zdGVybS5tIHwgNSArKysrKwogMSBmaWxlIGNoYW5nZWQsIDUg aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9uc3Rlcm0ubSBiL3NyYy9uc3Rlcm0ubQpp bmRleCBkYWJjMzZjZTAxOC4uZDI2NTA4NDM1NDggMTAwNjQ0Ci0tLSBhL3NyYy9uc3Rlcm0ubQor KysgYi9zcmMvbnN0ZXJtLm0KQEAgLTg1MjQsNiArODUyNCwxMSBAQCAtICh2b2lkKXRvZ2dsZUZ1 bGxTY3JlZW46IChpZClzZW5kZXIKIAogICBOU1RSQUNFICgiW0VtYWNzVmlldyB0b2dnbGVGdWxs U2NyZWVuOl0iKTsKIAorICAvKiBSZXNldCBmc19pc19uYXRpdmUgdG8gdmFsdWUgb2YgbnMtdXNl LW5hdGl2ZS1mdWxsLXNjcmVlbiBpZiBub3QKKyAgICAgZnVsbHNjcmVlbiBhbHJlYWR5ICovCisg IGlmIChmc19zdGF0ZSAhPSBGVUxMU0NSRUVOX0JPVEgpCisgICAgZnNfaXNfbmF0aXZlID0gbnNf dXNlX25hdGl2ZV9mdWxsc2NyZWVuOworCiAgIGlmIChmc19pc19uYXRpdmUpCiAgICAgewogI2lm IGRlZmluZWQgKE5TX0lNUExfQ09DT0EpICYmIE1BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQg Pj0gMTA3MAotLSAKMi40Ny4wCgo= --0000000000009c4bd9062714ac93--