From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions Date: Fri, 30 Dec 2022 13:00:09 -0500 Message-ID: References: <902440c7-706a-20e1-55af-4e12e8cdda2c@yandex.ru> <688159e9-f6bc-f233-08c4-9834bc00c455@yandex.ru> <74f977f6-d9ba-04bd-fba0-0dce4729cf0d@yandex.ru> <8d554fc2-7da5-cfe1-c865-023d56d222e3@yandex.ru> <95adedfa-7644-c78b-8853-fde8ec38f621@yandex.ru> <44ccf2d5-789f-f122-34f9-25871fdf1283@yandex.ru> <118143a7-0703-2538-9853-7009064e7bca@yandex.ru> <4540a3e6-f736-9050-0aac-0a9be1459248@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2826"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60186@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 30 19:01:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBJh1-0000Y7-5u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Dec 2022 19:01:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBJgm-000661-Aa; Fri, 30 Dec 2022 13:01:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBJgk-00065I-Th for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 13:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBJgk-0000DA-LD for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 13:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBJgk-0006Vr-1o for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 13:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2022 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60186 X-GNU-PR-Package: emacs Original-Received: via spool by 60186-submit@debbugs.gnu.org id=B60186.167242322824976 (code B ref 60186); Fri, 30 Dec 2022 18:01:02 +0000 Original-Received: (at 60186) by debbugs.gnu.org; 30 Dec 2022 18:00:28 +0000 Original-Received: from localhost ([127.0.0.1]:36090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJgB-0006Um-Vi for submit@debbugs.gnu.org; Fri, 30 Dec 2022 13:00:28 -0500 Original-Received: from mail-pj1-f53.google.com ([209.85.216.53]:39684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBJgA-0006Ua-BH for 60186@debbugs.gnu.org; Fri, 30 Dec 2022 13:00:26 -0500 Original-Received: by mail-pj1-f53.google.com with SMTP id o8-20020a17090a9f8800b00223de0364beso26468810pjp.4 for <60186@debbugs.gnu.org>; Fri, 30 Dec 2022 10:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=y9eUBH8wHITneUqW6/GOzAhjljyEiEA/5nOznh7mXyk=; b=OpBuCfmfklDr6/KXI0yEMX2O4pyllTCaI7/H4B+62w5hGooSrIxfPXGl1rkGwKIlxG 7hXu5+nP1EVTGNfXDM5yp7ULSok3/X24QJZRttOdbKwF6EJ6DCjoTYuVeikNFdStVHI6 lT4I0WLuj3F4T9agFIKOavwhvM6FJetCeKV18/x0ijkbNhtjzenwXBXUImGYcFn5KXGy NVTQAy+asVmPmZU6i/z8XJVwDng7MTb5Yq6R5aZW084MHAwvvSMkJIb+hRlH5l9Gd430 lq7GH6fDrG/pIpL95NYdgupnNXmO/X5nnDPNIklzTtjT6EiF6qU3cjCODzsgyX/Zmcdh AW3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y9eUBH8wHITneUqW6/GOzAhjljyEiEA/5nOznh7mXyk=; b=I7rTXvrH4ATUtNI+g8XegyvbD8XwvigHPBW+lSQJMssxmeKElYibh3qm5lfNDSmvlB 3LkrY5v9a6ZwUbkCOlbJEILHARoH7z08B33LwCDp4hJDu9TMCKSXZHjfADpvtnXQGu9T KaVVnfjIgw/iTrDmgzxXLcvIp/Mm2MEBCm8dhBSrlsPW4Z8Y6/dMJRbkAz0Oob/nz5X4 xvjnDbEQ3Bz3q3qF/juGW0xNRC5rauH1cl8QSdQi0P2T+91JJOGmLQ4gJTsWkgWMZZgL rnVoE9pk2twP609QfgqoWxnE95pd9Jc1LwZkdQ9ZzOxpUOMnuGS20PM6PhZoVchjHlzB vTAg== X-Gm-Message-State: AFqh2kr9jv4cbInZ12n5FQFv6sgHHZgTEUneJUa328PB36DX/gePuRoc AZYLLnjEB7P7yXzp1fCpoNpECDg4KsDsxMnL/7U= X-Google-Smtp-Source: AMrXdXt8DtbsXIRJg2KAGCxNpDVqcLxEyL5hrC2cjuYJtZnyBBo3xlGYRLS2VnjHMvniv8jc5ygDn7CoZqkQrOGMRpA= X-Received: by 2002:a17:90a:ad8a:b0:212:e24e:16b3 with SMTP id s10-20020a17090aad8a00b00212e24e16b3mr2162251pjq.69.1672423220437; Fri, 30 Dec 2022 10:00:20 -0800 (PST) In-Reply-To: <4540a3e6-f736-9050-0aac-0a9be1459248@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252148 Archived-At: On Fri, Dec 30, 2022 at 10:02 AM Dmitry Gutov wrote: > > Hi Aaron, > > On 30/12/2022 00:59, Aaron Jensen wrote: > > On Wed, Dec 28, 2022 at 4:24 PM Dmitry Gutov wrote: > >> On 28/12/2022 14:47, Dmitry Gutov wrote: > >>> I guess that particular trend started with ruby-method-params-indent, > >>> where I haven't managed to choose better names for the var, or the values. > >> Semantics aside (I suppose we could go back and revise the naming a > >> little later), could you test this new revision of the patch? > >> > >> I think I got the implementation simple enough now. > >> > >> The number of options has grown, though: > >> > >> (setq ruby-after-operator-indent nil > >> ruby-block-indent nil > >> ruby-method-call-indent nil > >> ruby-parenless-call-arguments-indent nil) > > I'll give it a shot some more, but these appear problematic: > > > > fixture( > > EntityProjection::Fixtures::Projection, > > projection, > > deleted > > ) do|projection| > > projection.assert_attributes_copied([ > > { :document_id => :id } > > ]) > > end > > > > Should be: > > > > fixture( > > EntityProjection::Fixtures::Projection, > > projection, > > deleted > > ) do|projection| > > projection.assert_attributes_copied([ > > { :document_id => :id } > > ]) > > end > > This example is for https://debbugs.gnu.org/60321, I think. Which we > split off and postponed a little. > > The last patch was the latest revision of the changes for > https://debbugs.gnu.org/60186. My mistake, it seems to work for these things aside from the method params in the example below. I can't reproduce that in emacs -Q, only with my own config, so I will have to see if I can figure out what the difference is. > As long as this example is unchanged (indented the same as the current > version of ruby-mode), it's good enough. It looks like this on my > machine, though: > > fixture( > EntityProjection::Fixtures::Projection, > projection, > deleted > ) do |projection| > projection.assert_attributes_copied([ > { :document_id => :id } > ]) > end > > Could you please give the v6 patch a good run soon-ish: we have a good > chance of getting it into Emacs 29 (together with ruby-ts-mode, which > should reuse some or most of the options), as I've just found out. > > The deadline for checking all this in is pretty near, alas: 1-2 days.