From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.bugs Subject: bug#56102: 29.0.50; fit-frame-to-buffer's window-text-pixel-size calculation can be incorrect when only is set to vertically Date: Mon, 27 Jun 2022 09:24:14 -0400 Message-ID: References: <834k0ckdet.fsf@gnu.org> <0807c810-af05-f92c-17ce-991056906629@gmx.at> <62155072-ac5f-2a3d-b1dd-0c9363c74975@gmx.at> <1a6138f1-fae9-4d33-28b4-7069028ccc36@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 56102@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 27 15:25:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5ojx-0008XL-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 15:25:21 +0200 Original-Received: from localhost ([::1]:38536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5ojv-0006Il-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 09:25:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5ojf-0006Ey-0s for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 09:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5oje-0008W8-OI for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 09:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5oje-0000cq-JJ for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 09:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aaron Jensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2022 13:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56102 X-GNU-PR-Package: emacs Original-Received: via spool by 56102-submit@debbugs.gnu.org id=B56102.16563362732363 (code B ref 56102); Mon, 27 Jun 2022 13:25:02 +0000 Original-Received: (at 56102) by debbugs.gnu.org; 27 Jun 2022 13:24:33 +0000 Original-Received: from localhost ([127.0.0.1]:50303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5ojB-0000c3-AO for submit@debbugs.gnu.org; Mon, 27 Jun 2022 09:24:33 -0400 Original-Received: from mail-pl1-f178.google.com ([209.85.214.178]:44716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5oj9-0000bm-AX for 56102@debbugs.gnu.org; Mon, 27 Jun 2022 09:24:31 -0400 Original-Received: by mail-pl1-f178.google.com with SMTP id l6so8145151plg.11 for <56102@debbugs.gnu.org>; Mon, 27 Jun 2022 06:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LRaeJ/3iMidZpTsoaXEeadfwieBnbAfUyTtOecEF1Vg=; b=KcvXcAU56obSVMnPCcXQMBX5m0o++/MTzEnjjkh2gx/U5a/rO1sR2aVL8FEhoQqx+i 7cM4gzbsuVmdwitlEyLV2lb9URrhaRLChzapm1q8XIxJyMD/672HPF02x1rtnXqqaeMk 0Jj1PDhMM4cKoVL3pclk8Zpot59ZLrPT2a4KGvqPZ5Ofu7LBHbrEvkLl8ZJ3X6/V3J1g QRixgC5SSjEUuykJ7Ffy9k+OGssUiySQGXjBVB4C8Lszxe3JIDH7hLERJzsGlDGpDqE4 Lb713w3BEdkgojOsLh1pTWkOi9Z9aTJXi70HW+wujduUc94B5+B33GhZYV+JCk8M0xX0 RMlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LRaeJ/3iMidZpTsoaXEeadfwieBnbAfUyTtOecEF1Vg=; b=tR/iUGYXtK8lDl4vY8JUyFMHCTr+M6wLhsuD0S6kh6KHEfVDEUiJ/D2peJJivAzmuM vrqoM/CiHMJ2+I6VIWSrzlaExelCb9+Sk6X/JvCVkEo49Eb/vyAycYwGmcVqOPaNmQqw 9xHNnH6FGHFGDo4DU6JEc3Jaw8lF7G5uK1+kIUzGNgs+f6ZfzK2jJwuvVz6mab7MAM3c rU25MsuCkayTePoanw75U907d3/4A4eruGhntGxYMNbASfDlZTPmYwH+qG9fME82K9zP q2mlVsTpNbv13mh1mabPfefNSDUh0n1TB6ei3mAQHA+WRadf8svdWYQuzasZ+xrHL+rg F+XA== X-Gm-Message-State: AJIora9FU6duS8k7SuK0g6F0acOTwm/oON/d0zQKCar5J+Ok4S6kmhm9 HlLBxS7Pca5WCElqwsUhII9kTCK5Dp3U8+1GVhc= X-Google-Smtp-Source: AGRyM1tA9lAqgMTnoZdy+UPW7jfoGy7YmyRd+x4xvvtH0fpScCVw2FvegMI+b+1yg1iV3fytjO7jn94aDefLxGWmdFM= X-Received: by 2002:a17:902:900c:b0:16a:4521:10fd with SMTP id a12-20020a170902900c00b0016a452110fdmr14620501plp.75.1656336265312; Mon, 27 Jun 2022 06:24:25 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235453 Archived-At: On Mon, Jun 27, 2022 at 4:24 AM martin rudalics wrote: > > >> With a non-standard setup, say > >> after doing > >> > >> (set-window-margins nil 10 10) > >> > >> in the root window, your fix will fail with the scenario you provided > >> earlier. > > > > Ah, I can confirm this. Is there a reasonable way for me to calculate > > a max-width that would be based on the root window that would work? > > Here > > (set-window-margins nil 10 10) > (fit-frame-to-buffer nil nil nil (window-body-width) nil 'vertically) > > seems to work. Thanks, I'll update the workaround to use this instead. > I don't know yet either. I'll send you a patch as soon as I have one. Sounds good, thanks. Aaron