unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Burks <rburksdev@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 70189@debbugs.gnu.org, Andrea Corallo <acorallo@gnu.org>
Subject: bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
Date: Fri, 5 Apr 2024 16:56:03 -0400	[thread overview]
Message-ID: <CAHvcHq5dtZ355BVF_+jPgtvHGoKqsipMgy5yNEEth_D+Cw9KqA@mail.gmail.com> (raw)
In-Reply-To: <CAHvcHq4aHmqy154japbk8EQpioCB1RteY21Xy65UaXe2YjhzMQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1687 bytes --]

Please include the attached with the group of 31 patches I sent prior.
This patch removes the warning suppression from a test in patch 20.
At some point I had altered the test and forgot to remove the warning
suppression.  This is one of the non-bug related tests.

Additionally, if after review you would like me to handle updating bug
numbers in the commits to the ones assigned or correct any typos let me
know.

On Thu, Apr 4, 2024 at 2:06 PM Robert Burks <rburksdev@gmail.com> wrote:

> I have submitted the request for the forms for past and future changes.
>
> That aspect slipped my mind.  The chain of emails I sent was originally
> just a
> couple lines to fix the segmentation fault in 'get-variable-watchers' and
> then
> just kept growing.
>
> I have sent an official request to assign copyright to GNU Emacs for any
> future
> works and for the past original works I have recently submitted for the
> following
> documents:
> lisp/bindings.el
> lisp/progmodes/flymake.el
> src/buffer.c
> src/data.c
> src/eval.c
> src/lisp.h
> test/src/data-tests.el
> test/src/eval-tests.el
>
> Robert A. Burks
>
> On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev@gmail.com> wrote:
>
>> I've only submitted one trivial patch prior to this.  I will submit the
>> copyright assignment here shortly.
>>
>> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> > Cc: 70189@debbugs.gnu.org
>>> > From: Andrea Corallo <acorallo@gnu.org>
>>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>>> >
>>> > Hi Robert,
>>> >
>>> > the patch LGTM, do you have the copyright assignment already done?
>>>
>>> He doesn't.
>>>
>>

[-- Attachment #1.2: Type: text/html, Size: 3738 bytes --]

[-- Attachment #2: 0032-Removed-warning-suppression.patch --]
[-- Type: text/x-patch, Size: 1402 bytes --]

From 4fbe173304d684ce9bfa3c20f3dea0a05031eb3f Mon Sep 17 00:00:00 2001
From: "Robert A. Burks" <rburksdev@gmail.com>
Date: Fri, 5 Apr 2024 16:27:08 -0400
Subject: [PATCH 32/32] ; * Removed warning suppression

* test/src/eval-tests.el (eval-tests-defvaralias-errorcases):
---
 test/src/eval-tests.el | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el
index 8627503ce27..f824d338db1 100644
--- a/test/src/eval-tests.el
+++ b/test/src/eval-tests.el
@@ -372,12 +372,11 @@ eval-tests-defvaralias-errorcases
   ;; 'defvaralias' should error if new_alias has been
   ;; dynamically bound by 'let', otherwise it creates the alias.
   (defvar eval-tests-defvaralias-error-cases-a 5)
-  (with-no-warnings
-    (let ((eval-tests-defvaralias-error-cases-a 10))
-      ;; A dynamically let-bound symbol cannot be made an alias
-      (should-error (defvaralias
-                      'eval-tests-defvaralias-error-cases-a
-                      'load-path))))
+  (let ((eval-tests-defvaralias-error-cases-a 10))
+    ;; A dynamically let-bound symbol cannot be made an alias
+    (should-error (defvaralias
+                    'eval-tests-defvaralias-error-cases-a
+                    'load-path)))
   (with-temp-buffer
     (make-local-variable 'eval-tests-defvaralias-errorcases-a1)
     ;; A blv cannot be made an alias
-- 
2.34.1


  reply	other threads:[~2024-04-05 20:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04  8:46 bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list Robert Burks
2024-04-04  9:51 ` Andrea Corallo
2024-04-04 11:57   ` Eli Zaretskii
2024-04-04 17:02     ` Robert Burks
2024-04-04 18:06       ` Robert Burks
2024-04-05 20:56         ` Robert Burks [this message]
2024-04-05 22:51           ` Robert Burks
2024-04-06  7:19             ` Eli Zaretskii
2024-04-06  7:45           ` Eli Zaretskii
2024-04-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <CAHvcHq7=hgcR1P3xgpFH1dM=CSdbvtp2Dq58GH9BpmyhDk7e0A@mail.gmail.com>
2024-04-07  0:18     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07  6:32       ` Robert Burks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHvcHq5dtZ355BVF_+jPgtvHGoKqsipMgy5yNEEth_D+Cw9KqA@mail.gmail.com \
    --to=rburksdev@gmail.com \
    --cc=70189@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).