unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
@ 2024-04-04  8:46 Robert Burks
  2024-04-04  9:51 ` Andrea Corallo
  2024-04-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 2 replies; 12+ messages in thread
From: Robert Burks @ 2024-04-04  8:46 UTC (permalink / raw)
  To: 70189


[-- Attachment #1.1: Type: text/plain, Size: 144 bytes --]

(8 of 9)

Patch 0024:  I am submitting this patch as a simple request to add native
compiled
files to the 'completion-ignored-extensions' list.

[-- Attachment #1.2: Type: text/html, Size: 184 bytes --]

[-- Attachment #2: 0024-Added-.eln-to-completion-ignored-extensions.patch --]
[-- Type: application/x-patch, Size: 906 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-04  8:46 bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list Robert Burks
@ 2024-04-04  9:51 ` Andrea Corallo
  2024-04-04 11:57   ` Eli Zaretskii
  2024-04-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 1 reply; 12+ messages in thread
From: Andrea Corallo @ 2024-04-04  9:51 UTC (permalink / raw)
  To: Robert Burks; +Cc: 70189

Robert Burks <rburksdev@gmail.com> writes:

> (8 of 9)
>
> Patch 0024:  I am submitting this patch as a simple request to add native compiled
> files to the 'completion-ignored-extensions' list.

Hi Robert,

the patch LGTM, do you have the copyright assignment already done?

For this single patch should be not necessary but I see you are sending
out a number of...

Thanks

  Andrea





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-04  9:51 ` Andrea Corallo
@ 2024-04-04 11:57   ` Eli Zaretskii
  2024-04-04 17:02     ` Robert Burks
  0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2024-04-04 11:57 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: 70189, rburksdev

> Cc: 70189@debbugs.gnu.org
> From: Andrea Corallo <acorallo@gnu.org>
> Date: Thu, 04 Apr 2024 05:51:02 -0400
> 
> Hi Robert,
> 
> the patch LGTM, do you have the copyright assignment already done?

He doesn't.





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-04 11:57   ` Eli Zaretskii
@ 2024-04-04 17:02     ` Robert Burks
  2024-04-04 18:06       ` Robert Burks
  0 siblings, 1 reply; 12+ messages in thread
From: Robert Burks @ 2024-04-04 17:02 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 70189, Andrea Corallo

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

I've only submitted one trivial patch prior to this.  I will submit the
copyright assignment here shortly.

On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > Cc: 70189@debbugs.gnu.org
> > From: Andrea Corallo <acorallo@gnu.org>
> > Date: Thu, 04 Apr 2024 05:51:02 -0400
> >
> > Hi Robert,
> >
> > the patch LGTM, do you have the copyright assignment already done?
>
> He doesn't.
>

[-- Attachment #2: Type: text/html, Size: 922 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-04 17:02     ` Robert Burks
@ 2024-04-04 18:06       ` Robert Burks
  2024-04-05 20:56         ` Robert Burks
  0 siblings, 1 reply; 12+ messages in thread
From: Robert Burks @ 2024-04-04 18:06 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 70189, Andrea Corallo

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

I have submitted the request for the forms for past and future changes.

That aspect slipped my mind.  The chain of emails I sent was originally
just a
couple lines to fix the segmentation fault in 'get-variable-watchers' and
then
just kept growing.

I have sent an official request to assign copyright to GNU Emacs for any
future
works and for the past original works I have recently submitted for the
following
documents:
lisp/bindings.el
lisp/progmodes/flymake.el
src/buffer.c
src/data.c
src/eval.c
src/lisp.h
test/src/data-tests.el
test/src/eval-tests.el

Robert A. Burks

On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev@gmail.com> wrote:

> I've only submitted one trivial patch prior to this.  I will submit the
> copyright assignment here shortly.
>
> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Cc: 70189@debbugs.gnu.org
>> > From: Andrea Corallo <acorallo@gnu.org>
>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>> >
>> > Hi Robert,
>> >
>> > the patch LGTM, do you have the copyright assignment already done?
>>
>> He doesn't.
>>
>

[-- Attachment #2: Type: text/html, Size: 2744 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-04 18:06       ` Robert Burks
@ 2024-04-05 20:56         ` Robert Burks
  2024-04-05 22:51           ` Robert Burks
  2024-04-06  7:45           ` Eli Zaretskii
  0 siblings, 2 replies; 12+ messages in thread
From: Robert Burks @ 2024-04-05 20:56 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 70189, Andrea Corallo


[-- Attachment #1.1: Type: text/plain, Size: 1687 bytes --]

Please include the attached with the group of 31 patches I sent prior.
This patch removes the warning suppression from a test in patch 20.
At some point I had altered the test and forgot to remove the warning
suppression.  This is one of the non-bug related tests.

Additionally, if after review you would like me to handle updating bug
numbers in the commits to the ones assigned or correct any typos let me
know.

On Thu, Apr 4, 2024 at 2:06 PM Robert Burks <rburksdev@gmail.com> wrote:

> I have submitted the request for the forms for past and future changes.
>
> That aspect slipped my mind.  The chain of emails I sent was originally
> just a
> couple lines to fix the segmentation fault in 'get-variable-watchers' and
> then
> just kept growing.
>
> I have sent an official request to assign copyright to GNU Emacs for any
> future
> works and for the past original works I have recently submitted for the
> following
> documents:
> lisp/bindings.el
> lisp/progmodes/flymake.el
> src/buffer.c
> src/data.c
> src/eval.c
> src/lisp.h
> test/src/data-tests.el
> test/src/eval-tests.el
>
> Robert A. Burks
>
> On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev@gmail.com> wrote:
>
>> I've only submitted one trivial patch prior to this.  I will submit the
>> copyright assignment here shortly.
>>
>> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> > Cc: 70189@debbugs.gnu.org
>>> > From: Andrea Corallo <acorallo@gnu.org>
>>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>>> >
>>> > Hi Robert,
>>> >
>>> > the patch LGTM, do you have the copyright assignment already done?
>>>
>>> He doesn't.
>>>
>>

[-- Attachment #1.2: Type: text/html, Size: 3738 bytes --]

[-- Attachment #2: 0032-Removed-warning-suppression.patch --]
[-- Type: text/x-patch, Size: 1402 bytes --]

From 4fbe173304d684ce9bfa3c20f3dea0a05031eb3f Mon Sep 17 00:00:00 2001
From: "Robert A. Burks" <rburksdev@gmail.com>
Date: Fri, 5 Apr 2024 16:27:08 -0400
Subject: [PATCH 32/32] ; * Removed warning suppression

* test/src/eval-tests.el (eval-tests-defvaralias-errorcases):
---
 test/src/eval-tests.el | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el
index 8627503ce27..f824d338db1 100644
--- a/test/src/eval-tests.el
+++ b/test/src/eval-tests.el
@@ -372,12 +372,11 @@ eval-tests-defvaralias-errorcases
   ;; 'defvaralias' should error if new_alias has been
   ;; dynamically bound by 'let', otherwise it creates the alias.
   (defvar eval-tests-defvaralias-error-cases-a 5)
-  (with-no-warnings
-    (let ((eval-tests-defvaralias-error-cases-a 10))
-      ;; A dynamically let-bound symbol cannot be made an alias
-      (should-error (defvaralias
-                      'eval-tests-defvaralias-error-cases-a
-                      'load-path))))
+  (let ((eval-tests-defvaralias-error-cases-a 10))
+    ;; A dynamically let-bound symbol cannot be made an alias
+    (should-error (defvaralias
+                    'eval-tests-defvaralias-error-cases-a
+                    'load-path)))
   (with-temp-buffer
     (make-local-variable 'eval-tests-defvaralias-errorcases-a1)
     ;; A blv cannot be made an alias
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-05 20:56         ` Robert Burks
@ 2024-04-05 22:51           ` Robert Burks
  2024-04-06  7:19             ` Eli Zaretskii
  2024-04-06  7:45           ` Eli Zaretskii
  1 sibling, 1 reply; 12+ messages in thread
From: Robert Burks @ 2024-04-05 22:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 70189, Andrea Corallo


[-- Attachment #1.1: Type: text/plain, Size: 2157 bytes --]

I had some time so I went ahead and updated the bug numbers in all the
patches.
Please see revised patches attached.

1) Revised all bug numbers to the assigned numbers.
2) Squashed #32 from the email prior to this into #20
3) Fixed the wording of a comment in #11
4) Rebased, rebuilt, and retested on commit 64e1cfb98cb

On Fri, Apr 5, 2024 at 4:56 PM Robert Burks <rburksdev@gmail.com> wrote:

> Please include the attached with the group of 31 patches I sent prior.
> This patch removes the warning suppression from a test in patch 20.
> At some point I had altered the test and forgot to remove the warning
> suppression.  This is one of the non-bug related tests.
>
> Additionally, if after review you would like me to handle updating bug
> numbers in the commits to the ones assigned or correct any typos let me
> know.
>
> On Thu, Apr 4, 2024 at 2:06 PM Robert Burks <rburksdev@gmail.com> wrote:
>
>> I have submitted the request for the forms for past and future changes.
>>
>> That aspect slipped my mind.  The chain of emails I sent was originally
>> just a
>> couple lines to fix the segmentation fault in 'get-variable-watchers' and
>> then
>> just kept growing.
>>
>> I have sent an official request to assign copyright to GNU Emacs for any
>> future
>> works and for the past original works I have recently submitted for the
>> following
>> documents:
>> lisp/bindings.el
>> lisp/progmodes/flymake.el
>> src/buffer.c
>> src/data.c
>> src/eval.c
>> src/lisp.h
>> test/src/data-tests.el
>> test/src/eval-tests.el
>>
>> Robert A. Burks
>>
>> On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev@gmail.com> wrote:
>>
>>> I've only submitted one trivial patch prior to this.  I will submit the
>>> copyright assignment here shortly.
>>>
>>> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>>> > Cc: 70189@debbugs.gnu.org
>>>> > From: Andrea Corallo <acorallo@gnu.org>
>>>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>>>> >
>>>> > Hi Robert,
>>>> >
>>>> > the patch LGTM, do you have the copyright assignment already done?
>>>>
>>>> He doesn't.
>>>>
>>>

[-- Attachment #1.2: Type: text/html, Size: 4870 bytes --]

[-- Attachment #2: revised-040524.tar.gz --]
[-- Type: application/gzip, Size: 21909 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-05 22:51           ` Robert Burks
@ 2024-04-06  7:19             ` Eli Zaretskii
  0 siblings, 0 replies; 12+ messages in thread
From: Eli Zaretskii @ 2024-04-06  7:19 UTC (permalink / raw)
  To: Robert Burks, Stefan Monnier; +Cc: 70189, acorallo

> From: Robert Burks <rburksdev@gmail.com>
> Date: Fri, 5 Apr 2024 18:51:12 -0400
> Cc: Andrea Corallo <acorallo@gnu.org>, 70189@debbugs.gnu.org
> 
> I had some time so I went ahead and updated the bug numbers in all the patches.
> Please see revised patches attached.
> 
> 1) Revised all bug numbers to the assigned numbers.
> 2) Squashed #32 from the email prior to this into #20
> 3) Fixed the wording of a comment in #11
> 4) Rebased, rebuilt, and retested on commit 64e1cfb98cb

I'm confused.  You originally filed no fewer than 8 separate bug
reports, each one with several patches.  Does this revised set replace
all of them? some of them?  If the latter, which ones does it replace
and which ones are still relevant as originally submitted?

In general, lumping together several different patches is not a good
idea, especially if you opened several separate bugs for them.  It
makes our work of reviewing and managing these bugs much harder,
especially given the fact that there are no less than 31 patches
overall here with overlapping changes and issues.

(We need to wait for the completion of your legal paperwork anyway.)





^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-05 20:56         ` Robert Burks
  2024-04-05 22:51           ` Robert Burks
@ 2024-04-06  7:45           ` Eli Zaretskii
  1 sibling, 0 replies; 12+ messages in thread
From: Eli Zaretskii @ 2024-04-06  7:45 UTC (permalink / raw)
  To: Robert Burks; +Cc: 70189, acorallo

> From: Robert Burks <rburksdev@gmail.com>
> Date: Fri, 5 Apr 2024 16:56:03 -0400
> Cc: Andrea Corallo <acorallo@gnu.org>, 70189@debbugs.gnu.org
> 
> Please include the attached with the group of 31 patches I sent prior.
> This patch removes the warning suppression from a test in patch 20.
> At some point I had altered the test and forgot to remove the warning
> suppression.  This is one of the non-bug related tests.

Thanks, but this should be part of the patch which triggers the
warning.  IOW, instead of two patches, one on top of the other, please
submit a single patch with both of the change sets.






^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-04  8:46 bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list Robert Burks
  2024-04-04  9:51 ` Andrea Corallo
@ 2024-04-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
       [not found]   ` <CAHvcHq7=hgcR1P3xgpFH1dM=CSdbvtp2Dq58GH9BpmyhDk7e0A@mail.gmail.com>
  1 sibling, 1 reply; 12+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-04-06 13:22 UTC (permalink / raw)
  To: Robert Burks; +Cc: 70189

> Patch 0024:  I am submitting this patch as a simple request to add native
> compiled files to the 'completion-ignored-extensions' list.

I don't see a big problem with it, but I wonder why you found it necessary:
AFAICT `.eln` files are always kept in a special directory that contains
nothing but `.eln` files, so it seems hard/unlikely to encounter
a situation where your patch would make a difference.


        Stefan






^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
       [not found]   ` <CAHvcHq7=hgcR1P3xgpFH1dM=CSdbvtp2Dq58GH9BpmyhDk7e0A@mail.gmail.com>
@ 2024-04-07  0:18     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2024-04-07  6:32       ` Robert Burks
  0 siblings, 1 reply; 12+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-04-07  0:18 UTC (permalink / raw)
  To: Robert Burks; +Cc: 70189

[ Re-added 70189@debbugs.gnu.org in the Cc.  ]

> I am trying to recall the specifics, I had added it to my config file
> months ago, then moved it there.  I believe at the time I was working
> in my '.emacs' directory often and I believe it was flex matching IDO that
> was completing on filenames.

A concrete case would be helpful.


        Stefan






^ permalink raw reply	[flat|nested] 12+ messages in thread

* bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list
  2024-04-07  0:18     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-04-07  6:32       ` Robert Burks
  0 siblings, 0 replies; 12+ messages in thread
From: Robert Burks @ 2024-04-07  6:32 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 70189

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Thanks, I'll look into it.

On Sat, Apr 6, 2024 at 8:18 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> [ Re-added 70189@debbugs.gnu.org in the Cc.  ]
>
> > I am trying to recall the specifics, I had added it to my config file
> > months ago, then moved it there.  I believe at the time I was working
> > in my '.emacs' directory often and I believe it was flex matching IDO
> that
> > was completing on filenames.
>
> A concrete case would be helpful.
>
>
>         Stefan
>
>

[-- Attachment #2: Type: text/html, Size: 965 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-04-07  6:32 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-04  8:46 bug#70189: [PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list Robert Burks
2024-04-04  9:51 ` Andrea Corallo
2024-04-04 11:57   ` Eli Zaretskii
2024-04-04 17:02     ` Robert Burks
2024-04-04 18:06       ` Robert Burks
2024-04-05 20:56         ` Robert Burks
2024-04-05 22:51           ` Robert Burks
2024-04-06  7:19             ` Eli Zaretskii
2024-04-06  7:45           ` Eli Zaretskii
2024-04-06 13:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <CAHvcHq7=hgcR1P3xgpFH1dM=CSdbvtp2Dq58GH9BpmyhDk7e0A@mail.gmail.com>
2024-04-07  0:18     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07  6:32       ` Robert Burks

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).