From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Erik van Zwol Newsgroups: gmane.emacs.bugs Subject: bug#57343: hscroll current-line scrolls short lines too far to the left Date: Tue, 23 Aug 2022 21:48:16 -0600 Message-ID: References: <83czcr85mw.fsf@gnu.org> <87tu62c30d.fsf@rub.de> <83mtbu7ut8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c73de505e6f48dd9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stephen Berman , 57343@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 24 05:49:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQhOO-00078O-Vy for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 05:49:25 +0200 Original-Received: from localhost ([::1]:35654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQhON-0007Vg-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Aug 2022 23:49:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQhO4-0007Us-2u for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 23:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQhO2-0006LQ-9Y for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 23:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQhO2-00042u-5L for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 23:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Erik van Zwol Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2022 03:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57343 X-GNU-PR-Package: emacs Original-Received: via spool by 57343-submit@debbugs.gnu.org id=B57343.166131291515517 (code B ref 57343); Wed, 24 Aug 2022 03:49:02 +0000 Original-Received: (at 57343) by debbugs.gnu.org; 24 Aug 2022 03:48:35 +0000 Original-Received: from localhost ([127.0.0.1]:45358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQhNb-00042D-0E for submit@debbugs.gnu.org; Tue, 23 Aug 2022 23:48:35 -0400 Original-Received: from mail-oa1-f48.google.com ([209.85.160.48]:46886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQhNa-000421-6H for 57343@debbugs.gnu.org; Tue, 23 Aug 2022 23:48:34 -0400 Original-Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-11c5505dba2so19182899fac.13 for <57343@debbugs.gnu.org>; Tue, 23 Aug 2022 20:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=6amYO6EzGX5cR2E0BeHPrZ5qRU13vHeq51Pz2cuhAQc=; b=QaqVA+OUR3CERhXP49JjyMh94B36gsdpwhDE/pMYYm1hAp56Pr7OPK0k1M+9LsyT43 tZpRGcHWX+jfPmUj7b5eg2AHHc65YJNM2jYYJmDU73f4fcvceN7VRWvGvbr3vobSHons 7RFqaDOUcRsdkfV1ofa2TE6jDmoHGHXAnsxDgzNjmQzd1cbD8NxX7adHy+I5tFtIHm22 ZuokYvikZVTCJYRq/iiRncLX6SnNUSokL1NAGwyXGfkAJu2gFBvGsNJb+tVWoMVZMMxM cDZykB1/kO3E/12oRprlhizPvxN3ngA8dIxayT7yWQZRNgd5Liao0cqbqTitG1hCKSyA x5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=6amYO6EzGX5cR2E0BeHPrZ5qRU13vHeq51Pz2cuhAQc=; b=wJK0peTQlW5EW++Rru/zQkk3u70h3we6LZdFYcjkN9/fAYYB3CF9B81mNULRq1/F5z 3IvySa+zOh+3cfCOx8pInFs1Vcrsv7d5jKz4CuEeqo+PsdDll70c3xM9Sc21bgZ6kxyG RYTrqnB9BAyklYLhezqW6Bu7mfwzxyDP13u/e7ZOOgaj5qiOu2WjDq9/2VBLC3EBVevT sbUY/HxLG9MIqdOTm2OaJEK0rtc46LwzfxGHiCueoSemD01KcUFRBf1ZPQhXFGLY2wAa 9t4EeavA1GTD8mm9IRvUfOpZpuXevX3OvRzz5yxwxDLqYHPJ3GKy5qk8xDpT3RZpsYXG myDA== X-Gm-Message-State: ACgBeo0Ir6eML+U0we0xrpdCxOBRYHQ5JnQMo+Icc/Adjd7FTTDpjUzi OMSumoJPVxXiOqTNhmlmqAubUwGq8/ib/t7oXQY= X-Google-Smtp-Source: AA6agR6PL8LSsizj2ANq1lz29gboZoOye7J0wot71+nKA8h//UCHSeP5nLZKRC4GuXe6no6qKxN0pi2nnF2cyV/EDF4= X-Received: by 2002:a05:6870:3914:b0:11c:8c2c:9016 with SMTP id b20-20020a056870391400b0011c8c2c9016mr2744138oap.111.1661312908605; Tue, 23 Aug 2022 20:48:28 -0700 (PDT) In-Reply-To: <83mtbu7ut8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240587 Archived-At: --000000000000c73de505e6f48dd9 Content-Type: text/plain; charset="UTF-8" I believe the issue happens when the line you are moving the cursor from a line that is hscrolled to a line that is shorter than (frame_width - hscroll_margin), the issue occurs. However, if the line you are moving the cursor to is greater than or equal to (frame_width - hscroll_margin), the problem does not occur. This is more evident when you set the hscroll-margin to something smaller, like 1 or 2. The patch I attached has modified the if statement that has this condition in it (point >= frame_width - hscroll_margin) or something like that, I don't have the code in front of me. On Tue, Aug 23, 2022 at 11:07 AM Eli Zaretskii wrote: > > From: Stephen Berman > > Cc: Erik van Zwol , 57343@debbugs.gnu.org > > Date: Tue, 23 Aug 2022 18:56:34 +0200 > > > > > I feel there's something else at work here, because if you move the > > > cursor up instead of down (i.e., to the previous instead of the next > > > line), the problem doesn't happen. > > > > I see the same hscrolling when moving to the next and to the previous > > line, both the same length (too short for hscrolling), see the attached > > screenshots. > > You are saying that what you see on your system invalidates my > observations on my system? > > All I'm saying is that what I see here tells me there's more here than > meets the eye. AFAIU, your evidence actually affirms my feeling. > --000000000000c73de505e6f48dd9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I believe the issue happens when the line you are moving t= he cursor from a line that is hscrolled to a line that is shorter than (fra= me_width - hscroll_margin), the issue occurs.=C2=A0 However, if the line yo= u are moving the cursor to is greater than or equal to (frame_width - hscro= ll_margin), the problem does not occur.=C2=A0 This is more evident when you= set the hscroll-margin to something smaller, like 1 or 2.

The patch I attached has modified the if statement that has this conditi= on in it (point >=3D frame_width - hscroll_margin) or something like tha= t, I don't have the code in front of me.


<= /div>

On Tue, Aug 23, 2022 at 11:07 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Erik van Zwol <thejofat@gmail.com>,=C2=A0 57343@debbugs.gnu.org
> Date: Tue, 23 Aug 2022 18:56:34 +0200
>
> > I feel there's something else at work here, because if you mo= ve the
> > cursor up instead of down (i.e., to the previous instead of the n= ext
> > line), the problem doesn't happen.
>
> I see the same hscrolling when moving to the next and to the previous<= br> > line, both the same length (too short for hscrolling), see the attache= d
> screenshots.

You are saying that what you see on your system invalidates my
observations on my system?

All I'm saying is that what I see here tells me there's more here t= han
meets the eye.=C2=A0 AFAIU, your evidence actually affirms my feeling.
--000000000000c73de505e6f48dd9--