From: Erik van Zwol <thejofat@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stephen Berman <stephen.berman@gmx.net>, 57343@debbugs.gnu.org
Subject: bug#57343: hscroll current-line scrolls short lines too far to the left
Date: Tue, 23 Aug 2022 21:48:16 -0600 [thread overview]
Message-ID: <CAHqWQpeC3HSVq_Zz9jMWTXJFLEJj4fZSVcpab76z5pgikk9UBA@mail.gmail.com> (raw)
In-Reply-To: <83mtbu7ut8.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]
I believe the issue happens when the line you are moving the cursor from a
line that is hscrolled to a line that is shorter than (frame_width -
hscroll_margin), the issue occurs. However, if the line you are moving the
cursor to is greater than or equal to (frame_width - hscroll_margin), the
problem does not occur. This is more evident when you set the
hscroll-margin to something smaller, like 1 or 2.
The patch I attached has modified the if statement that has this condition
in it (point >= frame_width - hscroll_margin) or something like that, I
don't have the code in front of me.
On Tue, Aug 23, 2022 at 11:07 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Stephen Berman <stephen.berman@gmx.net>
> > Cc: Erik van Zwol <thejofat@gmail.com>, 57343@debbugs.gnu.org
> > Date: Tue, 23 Aug 2022 18:56:34 +0200
> >
> > > I feel there's something else at work here, because if you move the
> > > cursor up instead of down (i.e., to the previous instead of the next
> > > line), the problem doesn't happen.
> >
> > I see the same hscrolling when moving to the next and to the previous
> > line, both the same length (too short for hscrolling), see the attached
> > screenshots.
>
> You are saying that what you see on your system invalidates my
> observations on my system?
>
> All I'm saying is that what I see here tells me there's more here than
> meets the eye. AFAIU, your evidence actually affirms my feeling.
>
[-- Attachment #2: Type: text/html, Size: 2062 bytes --]
next prev parent reply other threads:[~2022-08-24 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 4:03 bug#57343: hscroll current-line scrolls short lines too far to the left Erik van Zwol
2022-08-23 13:13 ` Eli Zaretskii
2022-08-23 16:56 ` Stephen Berman
2022-08-23 17:07 ` Eli Zaretskii
2022-08-24 3:48 ` Erik van Zwol [this message]
2022-08-24 3:50 ` Erik van Zwol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHqWQpeC3HSVq_Zz9jMWTXJFLEJj4fZSVcpab76z5pgikk9UBA@mail.gmail.com \
--to=thejofat@gmail.com \
--cc=57343@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).