unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20681@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>,
	Nick Andryshak <nandryshak@gmail.com>,
	Angelo Graziosi <angelo.graziosi@alice.it>
Subject: bug#20681: Build failure [MSYS2/MINGW64, OSX]
Date: Mon, 1 Jun 2015 20:41:02 +0200	[thread overview]
Message-ID: <CAHpGcMJYcMUugFbGJynaPob_kN3Uytsx=Xkr16pT_g3JOyez=Q@mail.gmail.com> (raw)
In-Reply-To: <83vbf7s4yw.fsf@gnu.org>

2015-06-01 19:39 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
> ??? If it were true, set-permissions.c would compile on Windows.  It
> doesn't.

I've already explained, at length, why it currently doesn't compile, and
at least three ways of how it could be fixed.

> So there's more to this job than just copying the code.

Yes, adding some #ifdefs and autoconf checks, that kind of thing.
That's not so hard.

>> > There's also the minor (but important for Emacs) point of supporting
>> > file names with characters outside of the current system codepage,
>> > which Gnulib can only provide in UTF-8 locales, something that doesn't
>> > exist on Windows.
>>
>> This has nothing to do with get_permissions and set_permissions.
>
> It's a reason not to use Gnulib for any file-related operations in
> Emacs on Windows, because Emacs on Windows uses Unicode APIs to access
> files by their names.

So it's okay to have this function in emacs:

  src/w32.c:acl_get_file (const char *fname, acl_type_t type)

but the same interface in gnulib wouldn't be okay? Right ...

I'll stop this discussion now, you're just not making sense.

Andreas





  reply	other threads:[~2015-06-01 18:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 12:55 bug#20681: Build failure [MSYS2/MINGW64, OSX] Angelo Graziosi
2015-05-28 17:47 ` Eli Zaretskii
2015-05-29 12:27   ` Angelo Graziosi
2015-05-29 16:56     ` Paul Eggert
2015-05-29 19:06       ` bug#20681: [PATCH] acl-permissions: Fix build on Mac OS X and older AIX (Bug#20681) Andreas Gruenbacher
2015-05-29 19:09       ` bug#20681: Build failure [MSYS2/MINGW64, OSX] Andreas Grünbacher
2015-05-29 19:45         ` Paul Eggert
2015-05-29 19:56           ` Nick Andryshak
2015-05-29 19:57             ` Andreas Grünbacher
2015-05-30 10:22               ` Eli Zaretskii
2015-05-30 12:02                 ` Andreas Grünbacher
2015-05-30 12:10                   ` Eli Zaretskii
2015-05-30 13:06                     ` Andreas Grünbacher
2015-05-31 14:29                       ` Eli Zaretskii
2015-05-31 19:18                         ` Andreas Grünbacher
2015-06-01 15:05                           ` Eli Zaretskii
2015-06-01 16:18                             ` Andreas Grünbacher
2015-06-01 17:39                               ` Eli Zaretskii
2015-06-01 18:41                                 ` Andreas Grünbacher [this message]
2015-06-01 19:01                                   ` Eli Zaretskii
2015-05-29 21:49           ` Angelo Graziosi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHpGcMJYcMUugFbGJynaPob_kN3Uytsx=Xkr16pT_g3JOyez=Q@mail.gmail.com' \
    --to=andreas.gruenbacher@gmail.com \
    --cc=20681@debbugs.gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=nandryshak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).