unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Felipe Ochoa <felipe.nospam.ochoa@gmail.com>
To: 24896@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Cc: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Subject: bug#24896: JSX prop indentation after fat arrow
Date: Thu, 8 Dec 2016 12:12:42 +0100	[thread overview]
Message-ID: <CAHp7JgjQ+a1aanNcLSmZiJyLRmkxqmapZmuvBqX9o68BCmqUqQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

Thanks -- seems reasonable. I figured as much but wanted to confirm.

I wonder what could be done in js-mode, too. A syntax-propertize-function
> rule, maybe.
>

syntax-propertize-function is outside my limited knowledge of emacs
internals. But to the extent that one could say "Outside of comments and
strings, propertize `=>' as punctuation," I imagine that would fix it.

Also, this may be a dumb question, but are the tests in the "manual"
directory meant to be run manually? If not, how would I run the tests there?

And then finally, should I just email a patch with the proposed change &
tests for this?

>

(Sorry Jackson for the double email -- forgot to reply all)

[-- Attachment #2: Type: text/html, Size: 1261 bytes --]

  parent reply	other threads:[~2016-12-08 11:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07  9:56 bug#24896: JSX prop indentation after fat arrow Felipe Ochoa
2016-11-19 22:47 ` Dmitry Gutov
2016-11-22  5:48   ` Jackson Ray Hamilton
     [not found]     ` <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com>
2016-12-08 11:12       ` Felipe Ochoa [this message]
2016-12-09  0:18         ` Dmitry Gutov
2017-01-06 17:44           ` Felipe Ochoa
2017-01-15  2:04             ` Dmitry Gutov
2017-01-23  9:26               ` Felipe Ochoa
2017-01-23 17:07                 ` Jackson Ray Hamilton
2017-01-25  1:59                 ` Dmitry Gutov
2019-06-05  2:47 ` Jackson Ray Hamilton
2019-06-06  6:59 ` Jackson Ray Hamilton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp7JgjQ+a1aanNcLSmZiJyLRmkxqmapZmuvBqX9o68BCmqUqQ@mail.gmail.com \
    --to=felipe.nospam.ochoa@gmail.com \
    --cc=24896@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=jackson@jacksonrayhamilton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).