* bug#24896: JSX prop indentation after fat arrow @ 2016-11-07 9:56 Felipe Ochoa 2016-11-19 22:47 ` Dmitry Gutov ` (2 more replies) 0 siblings, 3 replies; 12+ messages in thread From: Felipe Ochoa @ 2016-11-07 9:56 UTC (permalink / raw) To: 24896 [-- Attachment #1: Type: text/plain, Size: 1575 bytes --] (Preemptive apologies if this is the wrong list/format for this comment -- first time filer here!) When indenting JSX code using js2- or js-mode, the indentation function gets confused when there's a fat arrow function in a JSX prop. Compare the way the following two code blocks are auto-indented: const Component = props => ( // Incorrect indentation <FatArrow a={e => c} b={123}> </FatArrow> ); const Component = props => ( // Correct indentation <NoFatArrow a={123} b={123}> </NoFatArrow> ); I've tracked the problem down to `sgml-calculate-indent' using `parse-partial-sexp' with `sgml-tag-syntax-table', where `>' is treated as a close-parenthesis character (and thus the end-of-tag marker). I don't think there's a way to patch the syntax table that would let `>' flip between punctuation and close-parens based on context, but one possible fix when using js2-mode (not sure about js-mode) is to apply a "." 'syntax-table text property to the `>' when parsing a fat arrow. Unfortunately, `js-jsx-indent-line' calls `sgml-indent-line' using `js--as-sgml', which sets `parse-sexp-lookup-properties' to nil. Would there be any harm in setting `parse-sexp-lookup-properties' to t instead? As far as I can tell, js-mode and js2-mode only use 'syntax-table propeties for regex literals. As a side-note, there may well be a different solution to this problem; I still don't understand why the following block is indented correctly: const Component = props => ( <WithRegex a={/>/} b={123}> </WithRegex> ); [-- Attachment #2: Type: text/html, Size: 2475 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2016-11-07 9:56 bug#24896: JSX prop indentation after fat arrow Felipe Ochoa @ 2016-11-19 22:47 ` Dmitry Gutov 2016-11-22 5:48 ` Jackson Ray Hamilton 2019-06-05 2:47 ` Jackson Ray Hamilton 2019-06-06 6:59 ` Jackson Ray Hamilton 2 siblings, 1 reply; 12+ messages in thread From: Dmitry Gutov @ 2016-11-19 22:47 UTC (permalink / raw) To: Felipe Ochoa, 24896, Jackson Hamilton Hi! On 07.11.2016 11:56, Felipe Ochoa wrote: > (Preemptive apologies if this is the wrong list/format for this comment > -- first time filer here!) Not at all, thanks for the report. > I > don't think there's a way to patch the syntax table that would let `>' > flip between punctuation and close-parens based on context, but one > possible fix when using js2-mode (not sure about js-mode) I wonder what could be done in js-mode, too. A syntax-propertize-function rule, maybe. > is to apply a > "." 'syntax-table text property to the `>' when parsing a fat arrow. > > Unfortunately, `js-jsx-indent-line' calls `sgml-indent-line' using > `js--as-sgml', which sets `parse-sexp-lookup-properties' to nil. > > Would there be any harm in setting `parse-sexp-lookup-properties' to t > instead? As far as I can tell, js-mode and js2-mode only use > 'syntax-table propeties for regex literals. They also set that variable to t anyway. The only possible danger might come from sgml-mode, which does not do that. I'm not sure which danger exactly, because all examples in test/indent/js-jsx.js seem to behave identically whether js--as-sgml includes the parse-sexp-lookup-properties binding or not. Jackson, could you maybe shed some light on this? ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2016-11-19 22:47 ` Dmitry Gutov @ 2016-11-22 5:48 ` Jackson Ray Hamilton [not found] ` <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com> 0 siblings, 1 reply; 12+ messages in thread From: Jackson Ray Hamilton @ 2016-11-22 5:48 UTC (permalink / raw) To: Dmitry Gutov, Felipe Ochoa, 24896 Hi guys, Sorry that I cannot provide a definitive answer for the purpose of that line of code - I probably should have provided a more detailed comment or committed in smaller hunks - but I'll make a guess informed by the way I usually think, and thus probably thought, when I wrote that. When figuring out how to get `sgml-indent-line' to behave correctly, and upon discovering that I needed to use `with-syntax-table', I probably read the manual entry on syntax tables and discovered the existence of `parse-sexp-lookup-properties', and as a (redundant) safety measure tried to emulate the sgml-mode environment as closely as possible. If the tests still pass then let's try enabling it. Jackson On 11/19/2016 02:47 PM, Dmitry Gutov wrote: > Hi! > > On 07.11.2016 11:56, Felipe Ochoa wrote: >> (Preemptive apologies if this is the wrong list/format for this comment >> -- first time filer here!) > > Not at all, thanks for the report. > >> I >> don't think there's a way to patch the syntax table that would let `>' >> flip between punctuation and close-parens based on context, but one >> possible fix when using js2-mode (not sure about js-mode) > > I wonder what could be done in js-mode, too. A > syntax-propertize-function rule, maybe. > >> is to apply a >> "." 'syntax-table text property to the `>' when parsing a fat arrow. >> >> Unfortunately, `js-jsx-indent-line' calls `sgml-indent-line' using >> `js--as-sgml', which sets `parse-sexp-lookup-properties' to nil. >> >> Would there be any harm in setting `parse-sexp-lookup-properties' to t >> instead? As far as I can tell, js-mode and js2-mode only use >> 'syntax-table propeties for regex literals. > > They also set that variable to t anyway. The only possible danger might > come from sgml-mode, which does not do that. > > I'm not sure which danger exactly, because all examples in > test/indent/js-jsx.js seem to behave identically whether js--as-sgml > includes the parse-sexp-lookup-properties binding or not. > > Jackson, could you maybe shed some light on this? ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com>]
* bug#24896: JSX prop indentation after fat arrow [not found] ` <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com> @ 2016-12-08 11:12 ` Felipe Ochoa 2016-12-09 0:18 ` Dmitry Gutov 0 siblings, 1 reply; 12+ messages in thread From: Felipe Ochoa @ 2016-12-08 11:12 UTC (permalink / raw) To: 24896, Dmitry Gutov; +Cc: Jackson Ray Hamilton [-- Attachment #1: Type: text/plain, Size: 675 bytes --] Thanks -- seems reasonable. I figured as much but wanted to confirm. I wonder what could be done in js-mode, too. A syntax-propertize-function > rule, maybe. > syntax-propertize-function is outside my limited knowledge of emacs internals. But to the extent that one could say "Outside of comments and strings, propertize `=>' as punctuation," I imagine that would fix it. Also, this may be a dumb question, but are the tests in the "manual" directory meant to be run manually? If not, how would I run the tests there? And then finally, should I just email a patch with the proposed change & tests for this? > (Sorry Jackson for the double email -- forgot to reply all) [-- Attachment #2: Type: text/html, Size: 1261 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2016-12-08 11:12 ` Felipe Ochoa @ 2016-12-09 0:18 ` Dmitry Gutov 2017-01-06 17:44 ` Felipe Ochoa 0 siblings, 1 reply; 12+ messages in thread From: Dmitry Gutov @ 2016-12-09 0:18 UTC (permalink / raw) To: Felipe Ochoa, 24896; +Cc: Jackson Ray Hamilton On 08.12.2016 13:12, Felipe Ochoa wrote: > syntax-propertize-function is outside my limited knowledge of emacs > internals. But to the extent that one could say "Outside of comments and > strings, propertize `=>' as punctuation," I imagine that would fix it. Yes, it can help with that. > Also, this may be a dumb question, but are the tests in the "manual" > directory meant to be run manually? If not, how would I run the tests there? You can e.g. 'cd test/manual/indent' and run 'make js-jsx.js.test', to compare the indentation in js-jsx.js against what the current js.el does. > And then finally, should I just email a patch with the proposed change & > tests for this? An email with a diff attached could be enough. But if you wanted to include a "proper" commit message as well, see CONTRIBUTE in the top directory. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2016-12-09 0:18 ` Dmitry Gutov @ 2017-01-06 17:44 ` Felipe Ochoa 2017-01-15 2:04 ` Dmitry Gutov 0 siblings, 1 reply; 12+ messages in thread From: Felipe Ochoa @ 2017-01-06 17:44 UTC (permalink / raw) To: Dmitry Gutov; +Cc: 24896, Jackson Ray Hamilton [-- Attachment #1: Type: text/plain, Size: 1864 bytes --] So I've thought about this some more, and realized that this won't fix everything. There are still issues with greater-than and less-than as binary operators. Maybe a better idea is to give '{' and '}' comment syntax ('<' and '>') so that SGML ignores all the bracketed JS stuff. I've been trialing this with the following: (defvar js-jsx-tag-syntax-table (let ((table (make-syntax-table sgml-tag-syntax-table))) (modify-syntax-entry ?\{ "<" table) (modify-syntax-entry ?\} ">" table) table)) (defun advice-js-jsx-indent-line (orig-fun) (interactive) (let ((sgml-tag-syntax-table js-jsx-tag-syntax-table)) (apply orig-fun nil))) (advice-add 'js-jsx-indent-line :around 'advice-js-jsx-indent-line) and have gotten good results so far. This works for js-mode and js2-mode. If you're both happy with this approach, I'll convert the advice into a patch for `js-jsx-indent-line' and will send along! On Fri, Dec 9, 2016 at 1:18 AM, Dmitry Gutov <dgutov@yandex.ru> wrote: > On 08.12.2016 13:12, Felipe Ochoa wrote: > > syntax-propertize-function is outside my limited knowledge of emacs >> internals. But to the extent that one could say "Outside of comments and >> strings, propertize `=>' as punctuation," I imagine that would fix it. >> > > Yes, it can help with that. > > Also, this may be a dumb question, but are the tests in the "manual" >> directory meant to be run manually? If not, how would I run the tests >> there? >> > > You can e.g. 'cd test/manual/indent' and run 'make js-jsx.js.test', to > compare the indentation in js-jsx.js against what the current js.el does. > > And then finally, should I just email a patch with the proposed change & >> tests for this? >> > > An email with a diff attached could be enough. > > But if you wanted to include a "proper" commit message as well, see > CONTRIBUTE in the top directory. > [-- Attachment #2: Type: text/html, Size: 2862 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2017-01-06 17:44 ` Felipe Ochoa @ 2017-01-15 2:04 ` Dmitry Gutov 2017-01-23 9:26 ` Felipe Ochoa 0 siblings, 1 reply; 12+ messages in thread From: Dmitry Gutov @ 2017-01-15 2:04 UTC (permalink / raw) To: Felipe Ochoa; +Cc: 24896, Jackson Ray Hamilton On 06.01.2017 20:44, Felipe Ochoa wrote: > So I've thought about this some more, and realized that this won't fix > everything. There are still issues with greater-than and less-than as > binary operators. Inside XML literals, you mean? > Maybe a better idea is to give '{' and '}' comment > syntax ('<' and '>') so that SGML ignores all the bracketed JS stuff. > I've been trialing this with the following: How's your experience so far? > (defvar js-jsx-tag-syntax-table > (let ((table (make-syntax-table sgml-tag-syntax-table))) > (modify-syntax-entry ?\{ "<" table) > (modify-syntax-entry ?\} ">" table) > table)) > > (defun advice-js-jsx-indent-line (orig-fun) > (interactive) > (let ((sgml-tag-syntax-table js-jsx-tag-syntax-table)) > (apply orig-fun nil))) Here's the problem: js-indent-line uses syntax-ppss. sgml-indent-line doesn't (for now), but js-jsx-indent-line calls js-indent-line in certain contexts. And this is a problem because calling syntax-ppss in different contexts with incompatible (paren-wise) syntax tables will make syntax-ppss cache broken, and lead to likewise broken behaviors. So, one thing we could do here is let-bind the variables that constitute syntax-ppss cache around the call to orig-fun (i.e. around the context where we modify the syntax table). Another, somewhat more difficult approach, would be to try to apply the "<" and ">" syntax classes in syntax-propertize-function, only to occurrences of "{" and "}" inside XML literals. That would require knowing where the said literals begin and end, but we do know that somehow already, seeing as we know which indentation function to choose, right? This way we don't depend on syntax-ppss internals (the cache is not really a public API), and reindenting the whole buffer might be faster, because we would keep syntax-ppss cache around more. Still, not sure how much faster that would be in practice. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2017-01-15 2:04 ` Dmitry Gutov @ 2017-01-23 9:26 ` Felipe Ochoa 2017-01-23 17:07 ` Jackson Ray Hamilton 2017-01-25 1:59 ` Dmitry Gutov 0 siblings, 2 replies; 12+ messages in thread From: Felipe Ochoa @ 2017-01-23 9:26 UTC (permalink / raw) To: 'Dmitry Gutov', 'Felipe Ochoa' Cc: 24896, 'Jackson Ray Hamilton' >> There are still issues with greater-than and less-than >> as binary operators. > Inside XML literals, you mean? Yes, exactly. > How's your experience so far? It's actually worked very well. I had an issue once where indenting an entire region took several passes to get right, but now I'm not able to reproduce it :( > Here's the problem: js-indent-line uses syntax-ppss. > sgml-indent-line doesn't (for now), but js-jsx-indent-line > calls js-indent-line in certain contexts. And this is a problem > because calling syntax-ppss in different contexts with > incompatible (paren-wise) syntax tables will make > syntax-ppss cache broken, and lead to likewise broken > behaviors. I'm not sure I'm grasping this part entirely. I understand conceptually that using syntax-ppss with incompatible syntax tables could lead to cache problems. But it seems to me that the js*-mode and sgml-*-mode syntax tables are already incompatible (namely, "<" and ">", which are causing all this grief!). Would introducing this additional incompatibility cause more problems? > So, one thing we could do here is let-bind the variables that > constitute syntax-ppss cache around the call to orig-fun > (i.e. around the context where we modify the syntax table). > ... (the cache is not really a public API) This sounds like a bit of a headache. E.g., indenting a region would require binding and unbinding the cache carefully as you stepped into and out of JSX. What if we just scrap the syntax-ppss cache altogether? Would the performance penalty be too great? > Another, somewhat more difficult approach, would be to try > to apply the "<" and ">" syntax classes in > syntax-propertize-function, only to occurrences of "{" and "}" > inside XML literals. That would require knowing where the said > literals begin and end, but we do know that somehow already, > seeing as we know which indentation function to choose, right? This is based on a rough heuristic that essentially backtracks looking for "[(,]\n *<" (it also handles comments). This misses any JSX which is not at the start of the line, and it only tells us the start of the tag, not the end or where the body ends. In js2 and rjsx there is of course the full parser to give us this information. > This way we don't depend on syntax-ppss internals, and reindenting > the whole buffer might be faster, because we would keep syntax-ppss > cache around more. Still, not sure how much faster that would be in > practice. I think we could use a regex like the following to identify JSX start tokens: (rx (seq (or (any "-+*/%=><?:&") (seq (or "return" "typeof" "delete" "instanceof") whitespace) (any "([{,;")) (* whitespace) ; Should also skip over comments "<")) I.e., any "<" after an operator or at the beginning of an expression or statement. We'd have to filter out some false positives (postfix ++ and --, strings, and comments, possibly others), but this would get all the JSX start tags, I think. We could use a similar regex to find the ">" that close JSX tags: (rx (seq ">" (* whitespace) ; Should also skip over comments (or (any "-+*/%=><?:&") (seq (or "return" "typeof" "delete" "instanceof") whitespace) (any "(}],;")) Not sure how to go from there to the "{" and "}" tokens though. Is it possible to run syntax-ppss using different tables for different parts of the buffer? ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2017-01-23 9:26 ` Felipe Ochoa @ 2017-01-23 17:07 ` Jackson Ray Hamilton 2017-01-25 1:59 ` Dmitry Gutov 1 sibling, 0 replies; 12+ messages in thread From: Jackson Ray Hamilton @ 2017-01-23 17:07 UTC (permalink / raw) To: Felipe Ochoa, 'Dmitry Gutov', 'Felipe Ochoa'; +Cc: 24896 Hi Felipe, Regarding, > This is based on a rough heuristic that essentially backtracks looking for "[(,]\n *<" (it also handles comments). This misses any JSX which is not at the start of the line, and it only tells us the start of the tag, not the end or where the body ends. In js2 and rjsx there is of course the full parser to give us this information. Please note Dmitry's comment: https://github.com/mooz/js2-mode/issues/140#issuecomment-40887172, > As for indentation . . . there's a question how one would determine whether point is inside an XML expression (and expression's bounds) without using the AST (using it was rejected in the past on the grounds of that being slow). And see here for my explanation of that design: https://github.com/mooz/js2-mode/issues/140#issuecomment-145325361 Feel free the improve upon this algorithm, although do take care to benchmark the code before and after your changes, with buffers of various sizes. Large files won't hold up well if using an AST for indentation. Probably better to extend the current heuristic to be more accurate. Jackson On 01/23/2017 01:26 AM, Felipe Ochoa wrote: >>> There are still issues with greater-than and less-than >>> as binary operators. >> Inside XML literals, you mean? > > Yes, exactly. > >> How's your experience so far? > > It's actually worked very well. I had an issue once where indenting an entire region took several passes to get right, but now I'm not able to reproduce it :( > >> Here's the problem: js-indent-line uses syntax-ppss. >> sgml-indent-line doesn't (for now), but js-jsx-indent-line >> calls js-indent-line in certain contexts. And this is a problem >> because calling syntax-ppss in different contexts with >> incompatible (paren-wise) syntax tables will make >> syntax-ppss cache broken, and lead to likewise broken >> behaviors. > > I'm not sure I'm grasping this part entirely. I understand conceptually that using syntax-ppss with incompatible syntax tables could lead to cache problems. But it seems to me that the js*-mode and sgml-*-mode syntax tables are already incompatible (namely, "<" and ">", which are causing all this grief!). Would introducing this additional incompatibility cause more problems? > >> So, one thing we could do here is let-bind the variables that >> constitute syntax-ppss cache around the call to orig-fun >> (i.e. around the context where we modify the syntax table). >> ... (the cache is not really a public API) > > This sounds like a bit of a headache. E.g., indenting a region would require binding and unbinding the cache carefully as you stepped into and out of JSX. What if we just scrap the syntax-ppss cache altogether? Would the performance penalty be too great? > >> Another, somewhat more difficult approach, would be to try >> to apply the "<" and ">" syntax classes in >> syntax-propertize-function, only to occurrences of "{" and "}" >> inside XML literals. That would require knowing where the said >> literals begin and end, but we do know that somehow already, >> seeing as we know which indentation function to choose, right? > > This is based on a rough heuristic that essentially backtracks looking for "[(,]\n *<" (it also handles comments). This misses any JSX which is not at the start of the line, and it only tells us the start of the tag, not the end or where the body ends. In js2 and rjsx there is of course the full parser to give us this information. > >> This way we don't depend on syntax-ppss internals, and reindenting >> the whole buffer might be faster, because we would keep syntax-ppss >> cache around more. Still, not sure how much faster that would be in >> practice. > > I think we could use a regex like the following to identify JSX start tokens: > > (rx (seq (or (any "-+*/%=><?:&") > (seq (or "return" "typeof" "delete" "instanceof") whitespace) > (any "([{,;")) > (* whitespace) ; Should also skip over comments > "<")) > > I.e., any "<" after an operator or at the beginning of an expression or statement. We'd have to filter out some false positives (postfix ++ and --, strings, and comments, possibly others), but this would get all the JSX start tags, I think. We could use a similar regex to find the ">" that close JSX tags: > > (rx (seq ">" > (* whitespace) ; Should also skip over comments > (or (any "-+*/%=><?:&") > (seq (or "return" "typeof" "delete" "instanceof") whitespace) > (any "(}],;")) > > Not sure how to go from there to the "{" and "}" tokens though. Is it possible to run syntax-ppss using different tables for different parts of the buffer? > ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2017-01-23 9:26 ` Felipe Ochoa 2017-01-23 17:07 ` Jackson Ray Hamilton @ 2017-01-25 1:59 ` Dmitry Gutov 1 sibling, 0 replies; 12+ messages in thread From: Dmitry Gutov @ 2017-01-25 1:59 UTC (permalink / raw) To: 'Felipe Ochoa'; +Cc: 24896, 'Jackson Ray Hamilton' On 23.01.2017 12:26, Felipe Ochoa wrote: > It's actually worked very well. I had an issue once where indenting an entire region took several passes to get right, but now I'm not able to reproduce it :( Unreproducible wonky behavior might be the result of busting syntax-ppss cache. > But it seems to me that the js*-mode and sgml-*-mode syntax tables are already incompatible (namely, "<" and ">", which are causing all this grief!). Right. For now, we seem to have avoided the problem because sgml-indent-line does not call syntax-ppss. > Would introducing this additional incompatibility cause more problems? ...so if you change the syntax table just around the call to sgml-calculate-indent (not the whole js-jsx-indent-line), it shouldn't make things worse. > This sounds like a bit of a headache. E.g., indenting a region would require binding and unbinding the cache carefully as you stepped into and out of JSX. What if we just scrap the syntax-ppss cache altogether? Would the performance penalty be too great? Let-binding the cache variables to nil around the call to sgml-calculate-indent might be fast enough, because multiple calls to syntax-ppss (if any) inside that functions will still be amortized. But this is really going to be more useful when sgml-calculate-indent starts using syntax-ppss, which really might never happen. So the previous solution (changing the syntax table only where needed) might be preferable in the meantime. > This is based on a rough heuristic that essentially backtracks looking for "[(,]\n *<" (it also handles comments). This misses any JSX which is not at the start of the line, and it only tells us the start of the tag, not the end or where the body ends. I think sgml-skip-tag-forward could help with the last one. > In js2 and rjsx there is of course the full parser to give us this information. Like Jackson mentioned, probably not a good idea. > I think we could use a regex like the following to identify JSX start tokens: > > (rx (seq (or (any "-+*/%=><?:&") Can all of these (e.g. >) be realistically expected before a JSX literal? And it seems like the << operator would cause a false positive. I like the general direction, though. > We could use a similar regex to find the ">" that close JSX tags: sgml-skip-tag-forward seems like the more reliable option to me. Although it might work worse on invalid code. > Is it possible to run syntax-ppss using different tables for different parts of the buffer? If you perform the previously mentioned cache fiddling, yes. If not, then the answer is maybe, and that depends on how and when you'll be calling it. So maybe you should get into the underlying mechanics first. ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2016-11-07 9:56 bug#24896: JSX prop indentation after fat arrow Felipe Ochoa 2016-11-19 22:47 ` Dmitry Gutov @ 2019-06-05 2:47 ` Jackson Ray Hamilton 2019-06-06 6:59 ` Jackson Ray Hamilton 2 siblings, 0 replies; 12+ messages in thread From: Jackson Ray Hamilton @ 2019-06-05 2:47 UTC (permalink / raw) To: 24896 A set of changes I pushed to the Emacs master branch 2 months ago should resolve this issue. (First fixed in be86ece42c, but there were several commits after that when I broke/fixed it again. The master branch is your best bet.) ^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#24896: JSX prop indentation after fat arrow 2016-11-07 9:56 bug#24896: JSX prop indentation after fat arrow Felipe Ochoa 2016-11-19 22:47 ` Dmitry Gutov 2019-06-05 2:47 ` Jackson Ray Hamilton @ 2019-06-06 6:59 ` Jackson Ray Hamilton 2 siblings, 0 replies; 12+ messages in thread From: Jackson Ray Hamilton @ 2019-06-06 6:59 UTC (permalink / raw) To: 24896-done Marking this done. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-06-06 6:59 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-07 9:56 bug#24896: JSX prop indentation after fat arrow Felipe Ochoa 2016-11-19 22:47 ` Dmitry Gutov 2016-11-22 5:48 ` Jackson Ray Hamilton [not found] ` <CAHp7JggpF+APETs=BaX-yJMrcX+u55NoXanj_krbfdD-78WRTw@mail.gmail.com> 2016-12-08 11:12 ` Felipe Ochoa 2016-12-09 0:18 ` Dmitry Gutov 2017-01-06 17:44 ` Felipe Ochoa 2017-01-15 2:04 ` Dmitry Gutov 2017-01-23 9:26 ` Felipe Ochoa 2017-01-23 17:07 ` Jackson Ray Hamilton 2017-01-25 1:59 ` Dmitry Gutov 2019-06-05 2:47 ` Jackson Ray Hamilton 2019-06-06 6:59 ` Jackson Ray Hamilton
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).