From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Jaros=C5=82aw_?= =?UTF-8?Q?Rzesz=C3=B3tko?= Newsgroups: gmane.emacs.bugs Subject: bug#16192: hl-line-mode: Current line highlighting takes precedence over region highlighting Date: Thu, 19 Dec 2013 18:41:51 +0100 Message-ID: References: <4497f846-4399-48b4-bd48-4bf15a44be81@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b6dc1a43805d204ede6ade2 X-Trace: ger.gmane.org 1387474929 20946 80.91.229.3 (19 Dec 2013 17:42:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Dec 2013 17:42:09 +0000 (UTC) Cc: 16192@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 19 18:42:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vthbz-0001oM-6p for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2013 18:42:15 +0100 Original-Received: from localhost ([::1]:45567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vthby-0008ON-Sw for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2013 12:42:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vthbr-0008O4-My for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 12:42:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vthbm-0007gN-Ny for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 12:42:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vthbm-0007gJ-KL for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 12:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vthbm-0005DT-Al for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2013 12:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jaros=C5=82aw_?= =?UTF-8?Q?Rzesz=C3=B3tko?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2013 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16192-submit@debbugs.gnu.org id=B16192.138747491620027 (code B ref 16192); Thu, 19 Dec 2013 17:42:01 +0000 Original-Received: (at 16192) by debbugs.gnu.org; 19 Dec 2013 17:41:56 +0000 Original-Received: from localhost ([127.0.0.1]:58873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vthbf-0005Cw-V2 for submit@debbugs.gnu.org; Thu, 19 Dec 2013 12:41:56 -0500 Original-Received: from mail-pb0-f51.google.com ([209.85.160.51]:43623) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vthbc-0005Cn-BM for 16192@debbugs.gnu.org; Thu, 19 Dec 2013 12:41:53 -0500 Original-Received: by mail-pb0-f51.google.com with SMTP id up15so1453879pbc.10 for <16192@debbugs.gnu.org>; Thu, 19 Dec 2013 09:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mwsQL2XUzvoCkhMosCka0CC9jRuIVvXXFiTupQJQPLQ=; b=ZMSBhzsfmZgNyVsbsEeuWy4cbimVgt2LGye+/Nqi4e7mpigdnK9FZ2xVHjljIsnByX vGdNx0fCbTBWOOAM9L7d36b72JJIIOHYPgOiJ/LqvVCctfJJ3KjOqxJQys8rEC3JPuGo FscfnAY9q4OOoO1HvuDhqcOQ3IBUBxgjTbZaT1oyNn6R55Dd/h+z4Dilfpf3utemhzJD p9eP/CrRXX10m5z5dkdKwrmc57b+wBIJwaB+I1sbPQ6elEhMB8/ojz1Clq27XJ8Hp/xq O0gPd6FxKOtbxu1oh758DffH6m5zte9B07xVqw5j3BhNPn7fLtHiwIkcnSo5bdnLmTHH lUUA== X-Received: by 10.68.99.99 with SMTP id ep3mr3087109pbb.107.1387474911231; Thu, 19 Dec 2013 09:41:51 -0800 (PST) Original-Received: by 10.66.77.230 with HTTP; Thu, 19 Dec 2013 09:41:51 -0800 (PST) In-Reply-To: <4497f846-4399-48b4-bd48-4bf15a44be81@default> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82232 Archived-At: --047d7b6dc1a43805d204ede6ade2 Content-Type: text/plain; charset=ISO-8859-1 Correction from my side, the last problem seems to actually be independent of the fix, I reproduced it with vanilla emacs from vcs, no hl-line-mode, emacs ran with --no-init, without any .Xresources etc., just: (setq-default left-margin-width 1) open a new buffer, select a few lines, and you get this: http://imgur.com/M1LFjeF 2013/12/19 Drew Adams > > I've just installed a patch which lowers the priority of the hl-line > > highlighting, which seems like a good thing to do in general and which > > should resolve this problem (unless you use the same attributes for the > > region and the hl-line faces). > > It's not about the priority of the hl-line highlighting. (And other code > might well expect the priority that was there before.) > > It's about the priority of the region highlighting. Raise that, > instead of lowering other priorities case by case (and possibly breaking > other code). It is the region overlay that is new. It is its priority > that needs fixing. > > But didn't you say that you didn't want to be fiddling with priorities, > to deal with the problems introduced by this change? > --047d7b6dc1a43805d204ede6ade2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Correction from my side, the last problem s= eems to actually be independent of the fix, I reproduced it with vanilla em= acs from vcs, no hl-line-mode, emacs ran with --no-init, without any .Xreso= urces etc., just:

(setq-default left-margin-width 1)

open a new buffer= , select a few lines, and you get this:

http://imgur.com/M1LFjeF


2013/12/19 Drew Adams = <drew.adams@o= racle.com>
> I've just installed a patch which lowers the pri= ority of the hl-line
> highlighting, which seems like a good thing to do in general and which=
> should resolve this problem (unless you use the same attributes for th= e
> region and the hl-line faces).

It's not about the priority of the hl-line highlighting. (And oth= er code
might well expect the priority that was there before.)

It's about the priority of the region highlighting. =A0Raise that,
instead of lowering other priorities case by case (and possibly breaking other code). =A0It is the region overlay that is new. =A0It is its priority=
that needs fixing.

But didn't you say that you didn't want to be fiddling with priorit= ies,
to deal with the problems introduced by this change?

--047d7b6dc1a43805d204ede6ade2--