From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Hanson Newsgroups: gmane.emacs.bugs Subject: bug#8454: Themes can't work right due to design Date: Sun, 4 Dec 2011 22:54:09 -0800 Message-ID: References: <867hb45bh2.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1323106107 5999 80.91.229.12 (5 Dec 2011 17:28:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Dec 2011 17:28:27 +0000 (UTC) To: 8454@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 05 18:28:23 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RXcL1-0004Ou-6U for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Dec 2011 18:28:23 +0100 Original-Received: from localhost ([::1]:34353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXcL0-0000V6-Pa for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Dec 2011 12:28:22 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:38904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXc6d-0007SS-J8 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2011 12:13:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXc6c-0002hy-Cp for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2011 12:13:31 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXc6c-0002hu-6G for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2011 12:13:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RXc78-0004LP-Io for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2011 12:14:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <867hb45bh2.fsf@gmail.com> Resent-From: Chris Hanson Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2011 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.132310519716632 (code B ref 8454); Mon, 05 Dec 2011 17:14:02 +0000 Original-Received: (at 8454) by debbugs.gnu.org; 5 Dec 2011 17:13:17 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXc6O-0004KC-1I for submit@debbugs.gnu.org; Mon, 05 Dec 2011 12:13:16 -0500 Original-Received: from mail-qy0-f172.google.com ([209.85.216.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXSS5-000507-5L for 8454@debbugs.gnu.org; Mon, 05 Dec 2011 01:55:01 -0500 Original-Received: by qcsf15 with SMTP id f15so1259085qcs.3 for <8454@debbugs.gnu.org>; Sun, 04 Dec 2011 22:54:30 -0800 (PST) Original-Received: by 10.224.31.66 with SMTP id x2mr6826054qac.27.1323068070164; Sun, 04 Dec 2011 22:54:30 -0800 (PST) Original-Received: by 10.229.124.136 with HTTP; Sun, 4 Dec 2011 22:54:09 -0800 (PST) X-Mailman-Approved-At: Mon, 05 Dec 2011 12:13:14 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 05 Dec 2011 12:14:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Mon, 05 Dec 2011 12:28:20 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54719 Archived-At: I've just started using Emacs 24 (pretest 3), and have run into problems getting Zenburn to work right. Previously in Emacs 23 I used the color-theme package and a zenburn theme designed for that package. It needed a little tweaking but is otherwise fine. In Emacs 24, using custom-theme and a similar zenburn theme designed for that package, I'm having trouble getting the theme to work properly. I believe there are two underlying problems causing this behavior. The first is that :inherit isn't very useful as a way to say "make the current face like the specified one". Because color-theme clobbers face-defface-spec, it effectively erases any previous face settings, so that the theme settings are self-contained. There is no equivalent way to do this with custom-theme, which has led me to write things like `(font-lock-type-face ,zenburn-primary-3) rather than `(font-lock-type-face ((t (:inherit zenburn-primary-3)))) . This works but is somewhat unsatisfying. The second is that a face attribute that's explicitly set can't be overridden by a custom theme, for reasons I'm not completely clear on. For example, "cc-fonts.el" contains (set-face-foreground 'c-annotation-face "blue") and the theme doesn't seem to be able to override this foreground under any circumstances, even with an explicitly set :foreground attribute. This just seems like a bug. I'll probably just go back to using color-theme, since at least it works. I was hoping that Emacs 24 would allow me get good behavior without it, but alas... Let me know if you need help debugging anything.