From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Guy Gastineau Newsgroups: gmane.emacs.erc.general,gmane.emacs.bugs Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer Date: Fri, 28 Jan 2022 23:29:31 -0500 Message-ID: References: <87ee4rutmo.fsf@neverwas.me> <871r0rusl5.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000024015f05d6b1004b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11580"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org To: "J.P." Original-X-From: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Sat Jan 29 05:29:54 2022 Return-path: Envelope-to: sf-erc-help@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDfN4-0002qH-69 for sf-erc-help@m.gmane-mx.org; Sat, 29 Jan 2022 05:29:54 +0100 Original-Received: from localhost ([::1]:33490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDfN2-0002h9-IC for sf-erc-help@m.gmane-mx.org; Fri, 28 Jan 2022 23:29:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDfMz-0002gs-JS; Fri, 28 Jan 2022 23:29:49 -0500 Original-Received: from [2a00:1450:4864:20::129] (port=40648 helo=mail-lf1-x129.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDfMx-0005Nm-1B; Fri, 28 Jan 2022 23:29:48 -0500 Original-Received: by mail-lf1-x129.google.com with SMTP id a28so15692748lfl.7; Fri, 28 Jan 2022 20:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V9MAA9/bA5oZInpsJqAx7EkbBGbZJqCPI2ZTjAAauoo=; b=RpL6TKK+ezhi5y6PRTtKDuw7q4/XNjn6hOB0a9/hYJMHVeyEsSup65rHJLOCiLLMV8 SGnpK5qKZFIJY579KQUDIWSekH/stOBc/qEQuEmS8dhFcEifJctVAxqLwxGt3nldwfbe 29PtQexLcqqIfTyM2ZmU4ike31tw34y6RXW0vpCsixm99ed1oEKaA2PExxfpciP0WHs+ pYUbVtJ7bgxjDLfzn/n9PUA0kHGRRY3oNn8Vop0Y0bEHvy1t3LLPdyFrKhGFPRznhbK6 ef2ZlUaYD4p/8fTdfRkSgHEMTgBs9Wx76W/WHsc4ANq1be8pv/LrsvRPIEwe+PgWE7br 62LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V9MAA9/bA5oZInpsJqAx7EkbBGbZJqCPI2ZTjAAauoo=; b=t4IUXuyk9fek8iRLVyF+03p4FOLYm+Hbr4BANFvQlAz4qqpf/MzBUS9h9YmpPPxdrx jQXOiYZK/i+19tO7XjLHxUL9UrG0uQyQ4n6bz3Svlhgs4FGod1+XGsIHEVJ7gzf0rBP/ wfk0Gth1oUQjXsnCs0678GT+Et+/K9vd8EwtkjABliAllLQQm5P6HaJWqNHdYqCcA+BD MvGfYN5YFDLImJnDzRHzH7ciyFHrK7tvVRmZ0y2jW4RXarVXWOZidQC2qdB3eL8wyrfP NxRcw1RvcALuATACw8aQ4EPjo2fTCb7kIPQLI4MmOgUn2bwIfv+TqqjHaxNjHv6Xr/CV yFfw== X-Gm-Message-State: AOAM532Ky5egNcM9eN9bGWZ3AxeeJih0SRE+vupa6KVHWtFZD4pQtWx/ r/J5CGbK0poj1gJ+YmifnF/jz/oHwfLodlzAg3DXcAyV X-Google-Smtp-Source: ABdhPJzKfJ254QwzjHk12jnQqDe6TsuhlLrjLj3vVIlJ/0ZQeas08Yxdn9ROnhvbxemCiojwIGlnIi8Czkm3q5zg6X4= X-Received: by 2002:ac2:5542:: with SMTP id l2mr8194725lfk.252.1643430583442; Fri, 28 Jan 2022 20:29:43 -0800 (PST) In-Reply-To: <871r0rusl5.fsf@neverwas.me> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::129 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=strings.stringsandstrings@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-erc@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: General discussion about ERC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Original-Sender: "emacs-erc" Xref: news.gmane.io gmane.emacs.erc.general:1709 gmane.emacs.bugs:225506 Archived-At: --00000000000024015f05d6b1004b Content-Type: multipart/alternative; boundary="00000000000024015c05d6b10049" --00000000000024015c05d6b10049 Content-Type: text/plain; charset="UTF-8" Here it is. I don't think my pgp key is on any keyserver, but I signed it anyway. Thank you for the encouragement. On Fri, Jan 28, 2022 at 10:30 PM J.P. wrote: > Guy Gastineau writes: > > > Sure. I will do it. > > Nice! > > > The emacs bug report buffer provided access to a help page. It > > suggested I make a patch with `diff -u`. Is it preferable to provide a > > patch as made with git? > > Definitely with git. The "Getting involved with development" section in > CONTRIBUTE lays it out in full [1], but basically (after committing), > you just run something like > > git-format-patch -M origin/master -o /tmp > > and look for a file named /tmp/0001-foo.patch and attach that in a > reply. > > [1] https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n54 > --00000000000024015c05d6b10049 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here it is.=C2=A0 I don't think my pgp key is on any k= eyserver, but I signed it anyway.=C2=A0 Thank you for the encouragement.

On Fri, Jan 28, 2022 at 10:30 PM J.P. <jp@neverwas.me> wrote:
Guy Gastineau <strings.stringsandstrings@gmail.com>= writes:

> Sure. I will do it.

Nice!

> The emacs bug report buffer provided access to a help page. It
> suggested I make a patch with `diff -u`. Is it preferable to provide a=
> patch as made with git?

Definitely with git. The "Getting involved with development" sect= ion in
CONTRIBUTE lays it out in full [1], but basically (after committing),
you just run something like

=C2=A0 git-format-patch -M origin/master -o /tmp

and look for a file named /tmp/0001-foo.patch and attach that in a
reply.

[1] https://git.savannah.gnu.org/cgit= /emacs.git/tree/CONTRIBUTE#n54
--00000000000024015c05d6b10049-- --00000000000024015f05d6b1004b Content-Type: application/pgp-encrypted; name="0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch.gpg" Content-Disposition: attachment; filename="0001-Remove-redundant-checks-in-erc-switch-to-buffer.patch.gpg" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kyzc3p1v0 owGNVHtsFEUcvmJBusgjCEWUx693IHvc7XV3730WUqy0hUYhpYGAkDi7O3u35W732EcPsEQImFgx VKogVRFUUIhBwtOIDQaQWDRBEku08moI/kF4JBxV5Bln70oh4B9OdrMz3/7m+37fzG/m3YFPOPoX tLWcfWb0xGxdwY7CNUKMZVmOqcUprQEzOpYsVUKqyYgJLC40GEVlsC4yRkYxxQRjaoxgyTLWfWlE xqj7cKJS11Igh/1+PhgNCWGW5wWZY3GQD4RQMIgEFMJBQZYEFBFDErysqTALp4ELA8vGcg/wRJ+y aWJQZS2BKmSYioqRBWWGqStq3PD1fJEq9fTK4ymkJH2ilppMvYRMHINKXfECH4HpSCWEPA+8P8bx sQAPDBtkWWqWJdRj0YzBqzOn1FVUL4C8Yeg1DHnDoKhgG37cMUXJUT4oi1G/gMQAJ4VDPC9xiIBh 7PcLLA77I7IcDAospLBNaGqEPSdiJhTDC4JlgmJSGWRAEssmCDihqJKPYhiGgqRipEuJsP36cBIa IQweJtco4EBWkphkiNQ4lrxkrKgG1k1FU2mP2wshkHAS20ODZtwUJSmyDAwTV0xApY8yC48iFMkC L4YoxhHJHxFY3ueLRlGE8wcEXgSOZUOBgJ3k41yUx+P5D77ycmC4cIjzcjx4cp0wEEwlO+akoKgI 6CRKCRICmiytilLYnUOB4NgE2kaBVsgrEkNpeDjIDqNFSe8FgY5js2eLekHSKCbHSKIzCazaf3oR guV2OD+JyQk8SMkNphvSuia6H55AiiHBiJauY/VhNTuE2CGFCbSEdaUBS0xKkzAhnWBr2H13PijP o+lAq1Yy+UAh5wgvygG5yiMb22CnRcbYMNy9jfLcd2TL5XL+XzZ6ZtsJyla+uB+tbaCf19J2+aAk ID1OggGcM8mJTJsgk5TJmZpaWwE9waSu8wSk56Ngjr2+itqgLcQS2OtEZLGsLLaZrBRZLy9YBgZE TD8gMXwAc0isZpmktIDiff6gj6WopoI9hY6C/o7RxSWF10OdrglvOrKJo86v799YffvYd46DKhpy HznvGXD3uVN/3qptdg2qv3opmt3yytOdZbu+PbvF9eHbW4f82u/M4Bb0xe291aV9xynvVxaHOwp/ XLfjyKlJE727p2x4Uvy4+wY64DpUebPW2Ti9vKXPqpFLR68XBw9tX3dg36iB2Wl7lvzsGqtw/dWN u0dlv5x77V74+HBP+Yxk8c6aeUsjYxpOt7d9M0p5YWvqTN3rfZeP/6H78Mlz1oV49eTvXtt/sbVp 3LZtl+avjNbt0g6xR/cuufzO76Wz5885X9dWNabCeadj72bpesmeIDvNeaSkvhGv3b70e9/UIdNG zHgr+1SLM9OldN67ntp07Og+esvJc380/b1r+5F/WlcOGzus+tZd+tOSMWn2GpTN3l90Y7N+sOZY ZWvzJ5d3Tuh670Wj4xd3W9eAEascn13568rg2Ss6aipuz/rIGlk2aPmO0mVoY2fx8NUH5y0Cy9VY M74y0549fcLzVfWdN5xX5t7MbB7atGbFwObjbc2Hhgl3uqKZg5suxEtcax3L6kf2a2dPtCdubfjg t0nrnw34P7968acF/wI= --00000000000024015f05d6b1004b--