unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Kjeldahl <marius.kjeldahl@gmail.com>
To: Christopher League <league@contrapunctus.net>
Cc: 49645@debbugs.gnu.org
Subject: bug#49645: 28.0.50; Bookmark line highlighting remain stuck
Date: Sun, 25 Jul 2021 23:14:42 +0200	[thread overview]
Message-ID: <CAHdMyCLDYctTqW-Y1w+G1+wHs58RqysAi822AVSMSZKB6uZkxg@mail.gmail.com> (raw)
In-Reply-To: <CAHdMyCKxz0MjSPqLgnGBNorYu_Qr+U75JUJ+j-qVnkvG3rMkzQ@mail.gmail.com>

Still does NOT seem to work, sorry about that.

Thanks,

Marius K.

On Sun, Jul 25, 2021 at 11:14 PM Marius Kjeldahl
<marius.kjeldahl@gmail.com> wrote:
>
> I rebuilt emacs from head (brew reinstall emacs-head@28 --with-cocoa
> --with-native-comp) and it still does seem to work.
>
> If I set four bookmarks and then delete all bookmarks, only the last
> one set will actually be cleaned up visually. Even though there are no
> active bookmarks any longer, the three first will still have
> highlighted lines.
>
> Thanks,
>
> Marius K.
>
> On Sun, Jul 25, 2021 at 4:34 PM Christopher League
> <league@contrapunctus.net> wrote:
> >
> > Marius Kjeldahl <marius.kjeldahl@gmail.com> writes:
> >
> > > A few months ago highlighting the bookmark lines got turned on
> > > by default. While it's possible to delete bookmarks, the
> > > highlighting seems to remain stuck. Setting and clearing many
> > > temporary bookmarks while working in code means the the code
> > > gets littered with such highlights. I haven't found any way of
> > > cleaning up those highlights, except killing the buffer and
> > > reloading the file. I've turned it off by setting
> > > bookmark-fontify. But surely, the current behaviour must be
> > > considered a bug.
> >
> > Hi Marius,
> >
> > I think today we committed a fix for this issue of stuck bookmark
> > highlights:
> > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=142961bcdfb202ca3347a085e55c87b164bb2fb9
> >
> > Can you confirm that it resolves the problem you saw?
> >
> > If you're not building from git regularly, you should be able to
> > just download the most recent bookmark.el from here and
> > ‘eval-buffer’ it to test:
> > https://git.savannah.gnu.org/cgit/emacs.git/plain/lisp/bookmark.el
> >
> > In my analysis, clearing the highlight worked previously when
> > using ‘bookmark-delete’, but not when overwriting an existing
> > bookmark with a new location. The current version should fix it.
> > Thanks.
> >
> > CL





  reply	other threads:[~2021-07-25 21:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 14:44 bug#49645: 28.0.50; Bookmark line highlighting remain stuck Marius Kjeldahl
2021-07-19 15:34 ` Lars Ingebrigtsen
2021-07-20 14:14   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 14:34 ` Christopher League
2021-07-25 21:14   ` Marius Kjeldahl
2021-07-25 21:14     ` Marius Kjeldahl [this message]
2021-07-25 22:29     ` bug#49645: [External] : " Drew Adams
2022-08-21 18:03 ` Lars Ingebrigtsen
2022-08-21 18:46   ` Marius Kjeldahl
2022-08-21 18:58     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHdMyCLDYctTqW-Y1w+G1+wHs58RqysAi822AVSMSZKB6uZkxg@mail.gmail.com \
    --to=marius.kjeldahl@gmail.com \
    --cc=49645@debbugs.gnu.org \
    --cc=league@contrapunctus.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).