From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sho Takemori Newsgroups: gmane.emacs.bugs Subject: bug#23105: 25.0.92; map-put does not change its argument MAP Date: Sat, 26 Mar 2016 00:00:30 +0900 Message-ID: References: <8760waoddm.fsf@petton.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11419b18f82dab052ee0d263 X-Trace: ger.gmane.org 1458918985 14803 80.91.229.3 (25 Mar 2016 15:16:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Mar 2016 15:16:25 +0000 (UTC) To: Nicolas Petton , 23105@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 25 16:16:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ajTEd-00043Q-8i for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Mar 2016 16:01:11 +0100 Original-Received: from localhost ([::1]:56572 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajTEc-0000wg-7A for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Mar 2016 11:01:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajTEY-0000wa-V5 for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2016 11:01:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajTET-0002Yy-Vu for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2016 11:01:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajTET-0002Yu-Rf for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2016 11:01:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ajTET-0006BP-J0 for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2016 11:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sho Takemori Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Mar 2016 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 23105-submit@debbugs.gnu.org id=B23105.145891803823731 (code B ref 23105); Fri, 25 Mar 2016 15:01:01 +0000 Original-Received: (at 23105) by debbugs.gnu.org; 25 Mar 2016 15:00:38 +0000 Original-Received: from localhost ([127.0.0.1]:37976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajTE5-0006Ah-Ok for submit@debbugs.gnu.org; Fri, 25 Mar 2016 11:00:37 -0400 Original-Received: from mail-lf0-f48.google.com ([209.85.215.48]:33741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajTE4-0006AV-Pi for 23105@debbugs.gnu.org; Fri, 25 Mar 2016 11:00:37 -0400 Original-Received: by mail-lf0-f48.google.com with SMTP id f67so2074268lfb.0 for <23105@debbugs.gnu.org>; Fri, 25 Mar 2016 08:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=yDb5BWtRKKSnr19o1ICrcVTLxJ7phCp6lO0mnZhkrN0=; b=YOidXXgh1LZdq7YL3Zh+DFPlqnM8Quc01r0K1b00ukHRpDNJQvLGYCgiZ4CoHxaGaR sq1JO4zqdVrag/EJie7NmocYOILL7qru+rzYnirJURSnruEZZ/nIMGPqMdv4cUDoieY5 pZGTSDhDLa0R9qSq56p1Iyt5Cy+zRYXJ3if9LSPtBjzVa08ikIpCJM4LgpUfqYvhgfmc CBG0U8s45pks7RDxWcU3UxnTAwitG1oJaHVH71avVMQZnSof48f0YFxOC46JJnJC0Z+b lQCEvbLctu/GUa+sdBoo+3A83aRONEAvzGVXdYr9tfby/mHPVVgIcIfx72kx6YsIa76y LYAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=yDb5BWtRKKSnr19o1ICrcVTLxJ7phCp6lO0mnZhkrN0=; b=FQ9PhGpQgREfmMwbyyIlHqAq0/NiNVod8upiy9msYHtmDQTdGwFFZzcsn6vaOt4dxQ k/C03g1Jc9CI4HZQhnBQ7AQC5Y5rcKJGbget3I3gevbWXL1lOhrldzk5ygDs/MKd/2cC /rwKxvaII1KXWw4SGDQpD/+Baksf5xAROiskuZr+3kVtxM3kzKOXw+Dy3BwM/iTd422m IhuuNRuOFRBvj0ajeqC+Lc9rfaEf7W7P5k1GeL5euRcyRVJbI9+8wK74wSJ8rZc12PMJ AUNz1sO2nWf5LWrHSD4n9emAQqF0YjE8dik8rVBwMry33QHywP50wFRwFBumwGQJQBRq eeDg== X-Gm-Message-State: AD7BkJKnM7329AAdF5GQMJ8qLz/e7HWao58CJW9cDIxsfRDOLmniaI+7dKixEA56Ufr+PTydydwuYGrXAScSnA== X-Received: by 10.25.84.1 with SMTP id i1mr5790194lfb.2.1458918030580; Fri, 25 Mar 2016 08:00:30 -0700 (PDT) Original-Received: by 10.112.35.231 with HTTP; Fri, 25 Mar 2016 08:00:30 -0700 (PDT) In-Reply-To: <8760waoddm.fsf@petton.fr> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115482 Archived-At: --001a11419b18f82dab052ee0d263 Content-Type: text/plain; charset=UTF-8 Thanks for the fix. But after the fix, if MAP is a list literal, then it raises an error. For example, this raises an error. (map-put '((a . 1)) 'a "value") This works. (map-put [0 1 2] 1 "value") It is an expected error? Sho Takemori 2016-03-25 23:12 GMT+09:00 Nicolas Petton : > Sho Takemori writes: > > > I'm not sure if this is a bug, but the function map-put does not change > its > > argument MAP if the map is an alist and the key is not found. > > I pushed a fix to emacs-25. > > Nico > --001a11419b18f82dab052ee0d263 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks for the fix. But after the fix, if MAP is a list li= teral, then it raises an error.
For example, this raises an error.
(map-put '((a . 1)) 'a "value")

<= /div>
This works.
(map-put [0 1 2] 1 "value")

It is an expected error?

S= ho Takemori


2016-03-25 23:12 GMT+09:00 Nicolas Petton <nicolas@pe= tton.fr>:
Sho Takemori <= stakemorii@gmail.com> writes= :

> I'm not sure if this is a bug, but the function map-put does not c= hange its
> argument MAP if the map is an alist and the key is not found.

I pushed a fix to emacs-25.

Nico

--001a11419b18f82dab052ee0d263--