From: Jonathan Tomer <jktomer@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35497@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#35497: [PATCH] Don't rewrite buffer contents after saving by rename
Date: Wed, 1 May 2019 12:56:35 -0700 [thread overview]
Message-ID: <CAHY_+qzXi_=9q2ZWsztcxfnjcn0DGh=L1FoME9Gdv9-Xq21=CA@mail.gmail.com> (raw)
In-Reply-To: <83tveeosqe.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Wed, May 1, 2019 at 12:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Jonathan Tomer <jktomer@google.com>
> > Date: Wed, 1 May 2019 12:29:42 -0700
> > Cc: Michael Albinus <michael.albinus@gmx.de>, 35497@debbugs.gnu.org
> >
> > It's true that notifications are imperfect, but IMO they are the only
> possible way to test that particular invariant,
>
> I'm not sure. You could instead advise or hook write-region, and see
> that it is not being called to write to the file, for example.
> Wouldn't that be easier and more reliable?
>
Oh, of course -- that's quite a bit better. Thanks, will send a new patch
in a moment.
[-- Attachment #2: Type: text/html, Size: 1194 bytes --]
next prev parent reply other threads:[~2019-05-01 19:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 23:20 bug#35497: [PATCH] Don't rewrite buffer contents after saving by rename Jonathan Tomer
2019-04-30 7:18 ` Michael Albinus
2019-04-30 19:27 ` Jonathan Tomer
2019-04-30 20:47 ` Michael Albinus
2019-04-30 21:10 ` Jonathan Tomer
2019-04-30 21:21 ` Michael Albinus
2019-04-30 22:42 ` Jonathan Tomer
2019-05-01 0:26 ` bug#35497: [PATCH v2] " Jonathan Tomer
2019-05-01 17:48 ` bug#35497: [PATCH] " Eli Zaretskii
2019-05-01 19:29 ` Jonathan Tomer
2019-05-01 19:54 ` Eli Zaretskii
2019-05-01 19:56 ` Jonathan Tomer [this message]
2019-05-01 23:02 ` bug#35497: [PATCH v3] " Jonathan Tomer
2019-05-02 11:50 ` Michael Albinus
2019-05-02 22:04 ` Jonathan Tomer
2019-05-02 22:06 ` bug#35497: [PATCH v4] " Jonathan Tomer
2019-05-03 7:52 ` Michael Albinus
2019-05-03 12:29 ` Eli Zaretskii
2019-05-06 20:45 ` Jonathan Tomer
2019-05-07 14:05 ` Michael Albinus
2019-05-07 23:46 ` Richard Stallman
2019-05-06 20:46 ` bug#35497: [PATCH v5] " Jonathan Tomer
2019-05-06 20:48 ` bug#35497: [PATCH v6] " Jonathan Tomer
2019-05-07 14:03 ` Michael Albinus
2019-05-07 14:10 ` Michael Albinus
2019-05-07 17:25 ` Jonathan Tomer
2019-05-07 17:33 ` bug#35497: [PATCH v7] " Jonathan Tomer
2019-05-08 7:48 ` Michael Albinus
2019-05-08 17:03 ` Jonathan Tomer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHY_+qzXi_=9q2ZWsztcxfnjcn0DGh=L1FoME9Gdv9-Xq21=CA@mail.gmail.com' \
--to=jktomer@google.com \
--cc=35497@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).