From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: TOMAS FABRIZIO ORSI Newsgroups: gmane.emacs.bugs Subject: bug#71438: [PATCH] Allow ping to receive optional arguments Date: Sun, 16 Jun 2024 23:03:23 -0300 Message-ID: References: <86v82i9qiz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pbreton@cs.umb.edu, Eli Zaretskii , 71438@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 17 04:06:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJ1lI-00024w-57 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jun 2024 04:06:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ1ky-00074m-Kc; Sun, 16 Jun 2024 22:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ1kv-00074G-D3 for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 22:06:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJ1ku-0000mq-Rx for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 22:06:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJ1kw-00015r-69 for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 22:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: TOMAS FABRIZIO ORSI Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2024 02:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71438-submit@debbugs.gnu.org id=B71438.17185899114134 (code B ref 71438); Mon, 17 Jun 2024 02:06:02 +0000 Original-Received: (at 71438) by debbugs.gnu.org; 17 Jun 2024 02:05:11 +0000 Original-Received: from localhost ([127.0.0.1]:58171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJ1k6-00014b-5d for submit@debbugs.gnu.org; Sun, 16 Jun 2024 22:05:10 -0400 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:53600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJ1k2-000144-WC for 71438@debbugs.gnu.org; Sun, 16 Jun 2024 22:05:08 -0400 Original-Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a6f1f33486eso238763166b.3 for <71438@debbugs.gnu.org>; Sun, 16 Jun 2024 19:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fi-uba-ar.20230601.gappssmtp.com; s=20230601; t=1718589839; x=1719194639; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d59PC+c/jIPt/+APt9dLPn1lXVF5j7e31hqUCFIsi4c=; b=reWWSHv6yByhaweFLyEPDv16/+Tv057+/fKQpe3PTfJgvt3aURmGdyPV/Nz1G9za3+ ZMlg9FyUJ/EIlHp1qHBxu7A7yyqadoThR9S1+Yrjb80hmrkMVyQKccnogbsr5Fg20fOR 6/lOFoHqWTfYYgVPU6dedVWHW4khFwqrhdvOS3M9neFWOjhSHVg6kWFyx3TJahO4X1U2 7zxj2zEiI7HideNOHV8M7SmYvr8+AN/DdgNxF24deIzn4h3MQW2/N+omIQN2ncpFR7eP yr7VZsOjFYD1F0lo9waEwhVkBDwvgAoveEYdy+4czVshVeFDItkRB5NrS+ndp3v1a5xr bHbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718589839; x=1719194639; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d59PC+c/jIPt/+APt9dLPn1lXVF5j7e31hqUCFIsi4c=; b=f3WXb2Bji190VWnwdqj/6VsHUi4TyMFi8z/0pJjVPTFiSqvTGVsDVjIU+EXwRUYMyo NpYBfwHGsZRKO3KtnpIW3LynVwmdTiEG6mZ0A7z7HaISfiCEfoHFYfi655LN3xEHk0Fk 1ICHcj942z+FM6jdBYw64Y2dYgrRzWZ9hAoqFVMvMsBxrJfF/CLtcHeQczom4+KyBjWC FoMmfX59ZdFJFM6xzt3vyRi+QV1AnvWWAfor02exYWVsvvFOHvA28eOjxE6CaD9KvoII 3SsmjswdQVjje/5tK/dFgb80BHO8mKwydWtrRs1GzJLRST5oG6LeeHv4M3IJSUDtZhHU EHgg== X-Forwarded-Encrypted: i=1; AJvYcCWgQ5yrYDaGIDd6twyNauJ+kGMaJ4DwnjrSvjMlyxhXHS8YfeofZMYJY0YFh9BbNDVqEuQKnkZhv9F0zYpnQqAnrJCnk7I= X-Gm-Message-State: AOJu0Yxkmgrb/f3G//skWT0UDmlLdE1zpFUHGYHSAD105glN/7xB/zkO HtBV3oj9Zw7fsUmFAAZvWlN5oJ1Kesn6fYJWSjDS3PrC8rQ7rJTWOr2EYI2i/wYjTr0VAwZvxhC 4Z6d++/1HadqDrgNYAF0RZ2p0LmSZHcqx9jzXBQ== X-Google-Smtp-Source: AGHT+IHYcR9eX4VfyU0oiECgMaywqiEPAu8ghOZG7nXms8qj58s5mo6T8/np19a/0GvYLy9SUVoApmZ4nyFTxKuQa2c= X-Received: by 2002:a50:ccd5:0:b0:57c:8035:50ef with SMTP id 4fb4d7f45d1cf-57cbd8b98e6mr6210040a12.35.1718589839195; Sun, 16 Jun 2024 19:03:59 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287351 Archived-At: Hello Stefan, > Sorry for the late reply. No worries Stefan! I'm glad you are taking the time to help me with the patch. Thank you for all of the work you do! > I think this patch (to be applied on top of yours) might provide a > slighly better experience. I also made an attempt at improving the > docstring. What do you think? The docstring is greatly improved; without a doubt. However, I've been thinking. Both my original patch and yours ask the user for additional flags if *any* prefix argument is passed. Isn't that closing the door for further additions to this function? Maybe, it would be better if (for instance) "0" is passed as a prefix argument. In that way, if any other additions were to be made, those could use a different prefix argument (1,2,3, and so on); thus avoiding backwards incompatibility. So, instead of using when/if; cond could be used. What do you think? Best regards, - Fabrizio