From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: TOMAS FABRIZIO ORSI Newsgroups: gmane.emacs.bugs Subject: bug#71438: [PATCH] Allow ping to receive optional arguments Date: Sun, 9 Jun 2024 12:03:37 -0300 Message-ID: References: <86v82i9qiz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29413"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pbreton@cs.umb.edu, 71438@debbugs.gnu.org To: Eli Zaretskii , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 17:13:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGKEK-0007QF-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 17:13:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGKDw-0001nk-2J; Sun, 09 Jun 2024 11:12:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGKDt-0001nI-Iq for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 11:12:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGKDt-00078U-A2 for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 11:12:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGKE9-0001cx-MM for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 11:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: TOMAS FABRIZIO ORSI Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71438-submit@debbugs.gnu.org id=B71438.17179459536181 (code B ref 71438); Sun, 09 Jun 2024 15:13:01 +0000 Original-Received: (at 71438) by debbugs.gnu.org; 9 Jun 2024 15:12:33 +0000 Original-Received: from localhost ([127.0.0.1]:43753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGKDg-0001bZ-BR for submit@debbugs.gnu.org; Sun, 09 Jun 2024 11:12:33 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:44408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGKDd-0001b6-6F for 71438@debbugs.gnu.org; Sun, 09 Jun 2024 11:12:30 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a6ef64b092cso188076866b.1 for <71438@debbugs.gnu.org>; Sun, 09 Jun 2024 08:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fi-uba-ar.20230601.gappssmtp.com; s=20230601; t=1717945867; x=1718550667; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0XKKk3/m6Q/ck39jhxBxIElZTedtm8xkwNZyZYcNyvQ=; b=jX74DOEUgdAAzVdO+H19VZ1W1jFfO9Xss4v9LQq0skv71YTilBqDsh406jmVUxukgF aB3VNq5s2y7PYGsnyRdoTLjq5u0FLtGwAZkYfvER26shOiQXqo0Ns0gBySf+g+ImB0mf G5ckD/LzR8LRWfiaPjVGhEI7GPIohbiriANMa1BG54RbXlimG7Y8DHIpu9ocatJA6vAm /uQEwlPT7JpCTtQ7pYJHi98MJNF3bMwaeEQ4M7lVZ6d9Fecd59Z2baFzPA9K38WYV/41 CkWTxRjoESqaHuv9v0RefHyV5SaH9zFAob9AJLGv9kXXXdIfY8hkBnXO61mnIcxlq4GD mD3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717945867; x=1718550667; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0XKKk3/m6Q/ck39jhxBxIElZTedtm8xkwNZyZYcNyvQ=; b=CkoDzCBzSDqGVY3bZezhGnv6hJol2Wnqi9wBTWAM1IRi7aE6RKhqBHlPXBwdHJnHN1 6xPePjX0SNTWYm/tlt/Bim/krLXlmRSlkUo/Tj6rgx769EQyJTymd86BP8Niqx9qHUys /T3rV9bCJT7qd494NKFKy9pDABiz2xeZDqO4IpLfZKd1L33Y3MEfnIyYVvnCgp04LJ0N 5Q8SiLouX8hf/IYWjrIJVPdhW75l7cFbBMSsrSKhDqExOXntN08Wmwpyl946bE5hrwar Gr3SHhCmoz+s/Lp9a1SVpWQeo3WFJ2dnR+7LsgDQLXnfTEkmRYZkfEXvp6NUKOeZ/HBa NbWg== X-Forwarded-Encrypted: i=1; AJvYcCWXw8g9vZoYwW4t6/RvUPXHb966p835bbn+1OhQqwKxjLL6+Aeqf2YTvAz68332TjaJXFDgIpaI3zdEkNxbJpyYejmVruc= X-Gm-Message-State: AOJu0Yx3pS+W2d9ePvmN6Xk9/HcUkIgaj0gXW3S84Dc6ohYxgJkJ1L+4 iWBm1IMatF+2zZAOpjrv0ywSFmGZvfJDQJ8cwQ+Zb5mBYMZQ93MhO/bEiDnmI5MPsiA4+9ckqeb MSr9cW40/QcDtHYCmChkFR2Ni7Fd8O8s09/rO7AYx561/dYvEjKQZ9Klp X-Google-Smtp-Source: AGHT+IF1RcTA5w3kY0OnLnAHyVpoCoqMLknJqOq8oTF3MS9hSMRHlz/33j/jAEo7q9nuKv11EgCV/PRTN5tlCWo8XkI= X-Received: by 2002:a17:906:e250:b0:a6f:1443:1e20 with SMTP id a640c23a62f3a-a6f14432083mr143280666b.33.1717945453799; Sun, 09 Jun 2024 08:04:13 -0700 (PDT) In-Reply-To: <86v82i9qiz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286945 Archived-At: Hello Eli and Stefan, Thanks for the quick response. I'll reply to both of your emails here; I hope I am not breaking Emacs email etiquette. Stefan Kangas said: > Consider adding a ChangeLog entry to the commit message, see CONTRIBUTE. Noted. I thought my patch was too small to be mentioned in ChangeLog. I'll keep this in mind for future patches :D. As a side note, I found the CONTRIBUTE file very helpful. I personally found https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html to be a bit unclear. Stefan Kangas said: > Note that we don't usually use "Signed-off-by" trailers so that can > probably be removed as redundant. Noted. I'll remove that as well. Do patches need to be PGP signed? Eli Zaretskii said: > I actually wonder why change the name of the option at all? I thought that changing the name of the variable would better indicate its intended purpose. Since, with the patch, those variables would only be as a fallback/default (hence the name change). In retrospect, maybe it's a bit unnecessary and the name should be kept the same. Eli Zaretskii said: > Yes, I think we should do that, in which case the change is no longer backward-incompatible. Great! What's the procedure now? Should I upload a new patch to this same thread with the changes you both mentioned? As a side note, any additional notes? Any style comments? Elisp advice? Any other function I should look into to "imitate" the style of a good use of prefix argument? Thank you for all the feedback, Best regards, - Fabrizio