From: TOMAS FABRIZIO ORSI <torsi@fi.uba.ar>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Kangas <stefankangas@gmail.com>
Cc: pbreton@cs.umb.edu, 71438@debbugs.gnu.org
Subject: bug#71438: [PATCH] Allow ping to receive optional arguments
Date: Sun, 9 Jun 2024 12:03:37 -0300 [thread overview]
Message-ID: <CAHTSwYg_5mNMLG9qnxhgLq1E2e0cKmF6XQcXoqrOMNFGSOAsCw@mail.gmail.com> (raw)
In-Reply-To: <86v82i9qiz.fsf@gnu.org>
Hello Eli and Stefan,
Thanks for the quick response.
I'll reply to both of your emails here; I hope I am not breaking Emacs
email etiquette.
Stefan Kangas said:
> Consider adding a ChangeLog entry to the commit message, see CONTRIBUTE.
Noted. I thought my patch was too small to be mentioned in ChangeLog.
I'll keep this in mind for future patches :D.
As a side note, I found the CONTRIBUTE file very helpful.
I personally found
https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html
to be a bit unclear.
Stefan Kangas said:
> Note that we don't usually use "Signed-off-by" trailers so that can
> probably be removed as redundant.
Noted. I'll remove that as well. Do patches need to be PGP signed?
Eli Zaretskii said:
> I actually wonder why change the name of the option at all?
I thought that changing the name of the variable would better
indicate its intended purpose. Since, with the patch, those
variables would only be as a fallback/default (hence the name
change). In retrospect, maybe it's a bit unnecessary and the
name should be kept the same.
Eli Zaretskii said:
> Yes, I think we should do that, in which case the change is no longer
backward-incompatible.
Great! What's the procedure now? Should I upload a new patch to this
same thread with the changes you both mentioned?
As a side note, any additional notes?
Any style comments? Elisp advice? Any other function I should look into
to "imitate" the style of a good use of prefix argument?
Thank you for all the feedback,
Best regards,
- Fabrizio
next prev parent reply other threads:[~2024-06-09 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 15:28 bug#71438: [PATCH] Allow ping to receive optional arguments TOMAS FABRIZIO ORSI
2024-06-08 18:48 ` Peter Breton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 18:57 ` TOMAS FABRIZIO ORSI
2024-06-09 12:02 ` Stefan Kangas
2024-06-09 13:47 ` Eli Zaretskii
2024-06-09 15:03 ` TOMAS FABRIZIO ORSI [this message]
2024-06-09 15:21 ` Eli Zaretskii
2024-06-09 15:38 ` Stefan Kangas
2024-06-09 15:48 ` TOMAS FABRIZIO ORSI
2024-06-16 21:46 ` TOMAS FABRIZIO ORSI
2024-06-17 1:14 ` Stefan Kangas
2024-06-17 2:03 ` TOMAS FABRIZIO ORSI
2024-06-17 6:19 ` Stefan Kangas
2024-06-19 2:17 ` TOMAS FABRIZIO ORSI
2024-06-20 18:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHTSwYg_5mNMLG9qnxhgLq1E2e0cKmF6XQcXoqrOMNFGSOAsCw@mail.gmail.com \
--to=torsi@fi.uba.ar \
--cc=71438@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=pbreton@cs.umb.edu \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).