From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ryan Thompson Newsgroups: gmane.emacs.bugs Subject: bug#27193: 25.2; tmm should use completing-read-default Date: Fri, 02 Jun 2017 23:10:13 +0000 Message-ID: References: <7241c3bc-d7eb-4ce3-998e-dcc21d54ef7f@default> <6a2811d5-8a21-47a6-b416-41bda3e36f67@default> <669d7dff-a4bf-75b2-1652-6217efb84c72@yandex.ru> <236c968a-a11f-4a5a-88bc-f60edb50aa18@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113f7a740f4fa70551024226" X-Trace: blaine.gmane.org 1496445074 20581 195.159.176.226 (2 Jun 2017 23:11:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Jun 2017 23:11:14 +0000 (UTC) To: Drew Adams , Dmitry Gutov , 27193@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 03 01:11:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGvil-00050Y-10 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jun 2017 01:11:07 +0200 Original-Received: from localhost ([::1]:51778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGviq-0002mP-9p for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Jun 2017 19:11:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGvij-0002m8-4j for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2017 19:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGvif-00024l-W2 for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2017 19:11:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dGvif-00024d-SK for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2017 19:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dGvif-00059R-Lr for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2017 19:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ryan Thompson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jun 2017 23:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27193-submit@debbugs.gnu.org id=B27193.149644503019764 (code B ref 27193); Fri, 02 Jun 2017 23:11:01 +0000 Original-Received: (at 27193) by debbugs.gnu.org; 2 Jun 2017 23:10:30 +0000 Original-Received: from localhost ([127.0.0.1]:52099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGviA-00058i-8V for submit@debbugs.gnu.org; Fri, 02 Jun 2017 19:10:30 -0400 Original-Received: from mail-it0-f45.google.com ([209.85.214.45]:33648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGvi8-00058W-Vn for 27193@debbugs.gnu.org; Fri, 02 Jun 2017 19:10:29 -0400 Original-Received: by mail-it0-f45.google.com with SMTP id w68so11218436itc.0 for <27193@debbugs.gnu.org>; Fri, 02 Jun 2017 16:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=jpQa9jrDBk35YbDEve90DCy30vm4tFRtnRLkHAQnEvg=; b=ZLlS6/zEB711bZ2C1rh2aMK5fJYqLNfVI09ZoCy5bwgLEiuMdIhin3uMA1jhq0ZZ3P +R/92t6w4p2XLgAZ1jeS6lEHnhaXSEFynjmIO5gvzIZ/D7Q3bZQGb7A7cgArQehAjirq eiixV0Dd8U8YzHjH9NvDTsfU8W8+i9xn3ITVktSBsk80CyozqoxZH8BgD0umQ8euP/RM hBKqOD3W600GvQ0EGkg4ASqBqIepQz4QvkCDFRKSdWq9XkjYzDMfxTI9zLMZjuyxhxfo ANgO8sTALBepkgvWHRCGPPoG5P/D4pvGH50D6ZvFR8XckkD/gAT3llqpiQZCSEbHmwBx NNhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=jpQa9jrDBk35YbDEve90DCy30vm4tFRtnRLkHAQnEvg=; b=Isr0DsgHV48nFiVN1XiR69lYQ/gW2ltAxE8DgHm6R5l9izqP0W34YYX6QMZyRXtYrQ u2BfIVTpJU39C5ZF5GcvD2SeVvi9GEj/WFv4y5as9lX5sPVVdbh4oUAm0/05KjWlQ1Jr eVmVzCjCORKkxEh2eEcRDfsB/t8unU2J0DRA8qD1ka4D0r+dZryw6UNc9DjpAxRdaIX7 HD128JAjCmFc7J20af7B2zjkd4Bh3ztt8t7mVh/lrQac85y+4YZyUJvCxogu+vtOSJOF cMO1fkBnHmtEnRTw41kUj6sgsIcFbYVDr5T/hY1QDHKEqScGatrRq3O7bFUkoWQvQDqU CAvQ== X-Gm-Message-State: AODbwcAL1f0z55Nx4Q5fkqLM+SJC4vZtjLCTi1ovwvV+4g6kP7bENhNz ZmXBpf1joryXwwxlYE2IoK3C6hed3/287cM= X-Received: by 10.36.108.212 with SMTP id w203mr1896138itb.55.1496445023629; Fri, 02 Jun 2017 16:10:23 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133190 Archived-At: --001a113f7a740f4fa70551024226 Content-Type: text/plain; charset="UTF-8" Or to put the same thing in a more user-centric context, I think users would be surprised if changing the value of completing-read-function changed the behavior of tmm. On Fri, Jun 2, 2017 at 7:08 PM Ryan Thompson wrote: > On Fri, Jun 2, 2017 at 6:19 PM Drew Adams wrote: > >> Ido's completion behavior is as far from that of >> vanilla `completing-read' as is Tmm's completion behavior >> ("the result"). >> > > This is kind of my point. If someone calls ido-completing-read, you > wouldn't expect it to do something different based on the value of > completing-read-function, even if it ido used completing-read internally > (which it might have actually done in the past, but currently does not), > because by calling ido-completing-read the code has already specified it > wants ido completion. Similarly, tmm is implementing a very different > behavior from completing-read that is only recognizable as regular > completion if you specifically go looking for leaks in the abstraction, and > for the same reason I don't think tmm should be paying attention to > completing-read-function. > --001a113f7a740f4fa70551024226 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Or to put the same thing in a more user-centric context, I= think users would be surprised if changing the value of completing-read-fu= nction changed the behavior of tmm.

On Fri, Jun 2, 2017 at 7:08 PM Ryan Thompson <rct@thompsonclan.org> wrote:
On Fri, Jun 2, 2017 at 6:19 PM Drew Adams <drew.adams@oracle.com> = wrote:
Ido's completion behavio= r is as far from that of
vanilla `completing-read' as is Tmm's completion behavior
("the result").

This is kind of my point. If som= eone calls ido-completing-read, you wouldn't expect it to do something = different based on the value of completing-read-function, even if it ido us= ed completing-read internally (which it might have actually done in the pas= t, but currently does not), because by calling ido-completing-read the code= has already specified it wants ido completion. Similarly, tmm is implement= ing a very different behavior from completing-read that is only recognizabl= e as regular completion if you specifically go looking for leaks in the abs= traction, and for the same reason I don't think tmm should be paying at= tention to completing-read-function.
--001a113f7a740f4fa70551024226--