unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dani Moncayo <dmoncayo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, 24759@debbugs.gnu.org
Subject: bug#24759: 25.1.50; electric-quote-mode
Date: Sat, 22 Oct 2016 12:36:38 +0200	[thread overview]
Message-ID: <CAH8Pv0jmiaN4xAhWdwNYqNdJgPT=B4nPadLOVS99wUfO4YUomg@mail.gmail.com> (raw)
In-Reply-To: <83funorbp2.fsf@gnu.org>

>> > And if electric-quote-mode wants to be more user-friendly, it could
>> > ask, upon the first insertion of any electric quote character into a
>> > buffer, whether the user would like to her buffer-file-coding-system
>> > switched to UTF-8.
>>
>> I'd like such a feature, but I'd rather make it general (not specific
>> to electric-quote-mode).  That is, whenever a buffer gets a character
>> (whether typed, yanked, electrically inserted, ...) which is not
>> representable in the current buffer-file-coding-system, Emacs could
>> offer the user to switch the coding system to UTF-8 (or another one
>> which can represent all the characters currently present in the
>> buffer), like happens when the buffer is about to be saved to a file.
>
> IMO, this would be too annoying and detrimental to performance in many
> cases.  I think you underestimate how much 'insert' is used in Emacs,
> without the user knowing anything about that.  In most such cases, the
> buffer into which the character is entered will never be saved to any
> file.
>
> My proposal was specifically for the case where keyboard input caused
> these characters be inserted after conversion by electric-quote-mode,
> which hopefully restricts the applicable use cases to those where the
> user is typing at the keyboard.

OK.  In that case I withdraw my general approach.

> Date: Sat, 22 Oct 2016 09:49:00 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 24759@debbugs.gnu.org
>
> So I actually question the need for any test in electric--insertable-p.
> What bad things, besides the prompt at save-buffer time, will happen
> if we remove the test, and insert the characters unconditionally?

FWIW: I'd also prefer to remove that check from electric-quote-mode,
so that the quote conversion would always happen (if the minor mode is
enabled in the current buffer), regardless of
buffer-file-coding-system.

Thanks.

-- 
Dani Moncayo





  reply	other threads:[~2016-10-22 10:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 19:38 bug#24759: 25.1.50; electric-quote-mode Dani Moncayo
2016-10-21 19:58 ` Eli Zaretskii
2016-10-21 20:26   ` Dani Moncayo
2016-10-21 21:01     ` Paul Eggert
2016-10-21 21:04   ` Paul Eggert
2016-10-22  6:49     ` Eli Zaretskii
2016-10-22  7:47       ` Eli Zaretskii
2016-10-22  8:16         ` Dani Moncayo
2016-10-22  9:10           ` Eli Zaretskii
2016-10-22 10:36             ` Dani Moncayo [this message]
2016-10-22 18:47       ` Paul Eggert
2016-10-22 19:04         ` Eli Zaretskii
2016-10-22 19:34           ` Eli Zaretskii
2016-10-23  4:10             ` Paul Eggert
2016-10-23  7:13               ` Eli Zaretskii
2016-10-23  8:24                 ` Paul Eggert
2016-10-23  8:51                   ` Eli Zaretskii
2016-10-22 19:20         ` Andreas Schwab
2016-10-23  3:55           ` Paul Eggert
2016-10-23  7:00             ` Eli Zaretskii
2016-10-23  8:15               ` Paul Eggert
2016-10-23  8:55                 ` Eli Zaretskii
2016-10-23  9:15                   ` Dani Moncayo
2016-10-23  9:28                     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH8Pv0jmiaN4xAhWdwNYqNdJgPT=B4nPadLOVS99wUfO4YUomg@mail.gmail.com' \
    --to=dmoncayo@gmail.com \
    --cc=24759@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).