From: Dani Moncayo <dmoncayo@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 16099@debbugs.gnu.org
Subject: bug#16099: 24.3.50; Build failure, undefined function `cl-member'
Date: Sat, 14 Dec 2013 22:32:36 +0100 [thread overview]
Message-ID: <CAH8Pv0gYxZYxE7xh_2LPtCo0G7LCtjp3MTE+sVwTrGHJ=B8xWw@mail.gmail.com> (raw)
In-Reply-To: <ne61qrfb5x.fsf@fencepost.gnu.org>
On Sat, Dec 14, 2013 at 9:08 PM, Glenn Morris <rgm@gnu.org> wrote:
>
> The only comment I'd make is: can you restrict doing this to when srcdir
> is absolute to start with? Which must mean the user has specified an
> absolute path to configure's srcdir, which I would imagine to be rare.
> On Unix systems, this would be trivial - just check if srcdir starts
> with "/". I don't know what you need to do for MS.
I think that the patch below would do it.
> Forcing srcdir to be absolute all the time will eg break using a srcdir
> with spaces in.
I don't understand this. For example if the original value of srcdir
was "../my nice repo", with the current trunk it would be translated
to something like "/c/foo/bar/my nice repo". What breakage might it
cause?
diff --git a/configure.ac b/configure.ac
index 2e9eee6..0c4b98b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,11 +28,14 @@ if test "x$MSYSTEM" = "xMINGW32"
then
. $srcdir/nt/mingw-cfg.site
- # Convert srcdir to an absolute MSYS path of the form "/c/foo/bar"
- # to simplify later conversions of paths to windows-native format
- # "c:/foo/bar"
- srcdir=`cd "${srcdir}" && pwd -W`
- srcdir="/${srcdir:0:1}${srcdir:2}"
+ if test ${srcdir:0:1} = "/" -o ${srcdir:1:1} = ":"
+ then
+ # srcdir is an absolute path. In this case, force the format
+ # "/c/foo/bar", to simplify later conversions to native Windows
+ # format ("c:/foo/bar")
+ srcdir=`cd "${srcdir}" && pwd -W`
+ srcdir="/${srcdir:0:1}${srcdir:2}"
+ fi
fi
dnl Set emacs_config_options to the options of 'configure', quoted
for the shell,
--
Dani Moncayo
next prev parent reply other threads:[~2013-12-14 21:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:13 bug#16099: 24.3.50; Build failure, undefined function `cl-member' Richard Copley
2013-12-10 16:46 ` Eli Zaretskii
2013-12-10 16:53 ` Richard Copley
2013-12-10 17:09 ` Glenn Morris
2013-12-10 18:05 ` Eli Zaretskii
2013-12-10 18:13 ` Richard Copley
2013-12-10 18:16 ` Glenn Morris
2013-12-10 18:35 ` Eli Zaretskii
[not found] ` <handler.16099.D16099.138669538824350.notifdone@debbugs.gnu.org>
2013-12-10 17:42 ` bug#16099: closed (Re: bug#16099: 24.3.50; Build failure, undefined function `cl-member') Richard Copley
2013-12-10 17:55 ` Richard Copley
2013-12-10 18:12 ` bug#16099: 24.3.50; Build failure, undefined function `cl-member' Glenn Morris
2013-12-10 18:25 ` Richard Copley
2013-12-10 18:34 ` Eli Zaretskii
2013-12-10 18:37 ` Richard Copley
2013-12-10 18:59 ` Eli Zaretskii
2013-12-10 20:47 ` Richard Copley
2013-12-10 20:58 ` Eli Zaretskii
2013-12-10 21:08 ` Glenn Morris
2013-12-11 17:07 ` Eli Zaretskii
2013-12-10 18:42 ` Glenn Morris
2013-12-10 18:48 ` Glenn Morris
2013-12-10 18:58 ` Eli Zaretskii
2013-12-10 20:09 ` Dani Moncayo
2013-12-10 20:31 ` Eli Zaretskii
2013-12-10 20:57 ` Dani Moncayo
2013-12-11 17:12 ` Eli Zaretskii
2013-12-12 14:08 ` Dani Moncayo
2013-12-12 16:33 ` Eli Zaretskii
2013-12-12 19:53 ` Dani Moncayo
2013-12-14 9:33 ` Dani Moncayo
2013-12-14 9:56 ` Eli Zaretskii
2013-12-14 20:08 ` Glenn Morris
2013-12-14 21:32 ` Dani Moncayo [this message]
2013-12-14 21:43 ` Glenn Morris
2013-12-14 21:56 ` Dani Moncayo
2013-12-10 18:58 ` Eli Zaretskii
2013-12-10 18:13 ` bug#16099: closed (Re: bug#16099: 24.3.50; Build failure, undefined function `cl-member') Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH8Pv0gYxZYxE7xh_2LPtCo0G7LCtjp3MTE+sVwTrGHJ=B8xWw@mail.gmail.com' \
--to=dmoncayo@gmail.com \
--cc=16099@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).