unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dani Moncayo <dmoncayo@gmail.com>
To: Juri Linkov <juri@jurta.org>
Cc: 9918@debbugs.gnu.org
Subject: bug#9918: 24.0.90; lazy-highlighting in Info mode
Date: Tue, 1 Nov 2011 10:39:36 +0100	[thread overview]
Message-ID: <CAH8Pv0gKqCsfh92KzYJ_OUd5tdbrnSjRCboqARS7EFTFRUCPcg@mail.gmail.com> (raw)
In-Reply-To: <87vcr4pxau.fsf@mail.jurta.org>

> But Info Isearch sets `isearch-error' to "initial node", so
> `isearch-lazy-highlight-new-loop' doesn't start lazy-highlighting.
> It seems with the error "initial node", it's still possible to
> lazy-highlight other matches.  So it's not a normal error,
> and we can make an exception for this type of "error".
> This will work with the following patch:
>
> [...]
>
> But it's not good to hardcode it, so perhaps we should introduce
> a special property for errors that are not quite an error,
> and set it just for "initial node".

Indeed.

IIUC, "initial node" just inform the user that the current search is
failing inside this node (where the search started), but this should
not be considered an error (like "incomplete input" or "No previous
search string"), because "initial node", unlike "incomplete input",
does not deactivate the current Isearch.

So, I think that maybe TRT would be to move the "inital node" message
to the Isearch prompt, so that such prompt would be "Failing I-search
(initial node): ".

BTW: while looking for sentences that set the value of `isearch-error'
inside lisp/isearch.el, I've noticed that some errors begins with an
uppercase letter ("No previous search string") and others don't
("incomplete input").  This should be fixed to make it consistent for
all error messages.

-- 
Dani Moncayo





  reply	other threads:[~2011-11-01  9:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 14:46 bug#9918: 24.0.90; lazy-highlighting in Info mode Dani Moncayo
2011-10-31 20:43 ` Eli Zaretskii
2011-10-31 21:00   ` Drew Adams
2011-10-31 21:08   ` Dani Moncayo
2011-10-31 21:13     ` Drew Adams
2011-10-31 21:30       ` Dani Moncayo
2011-10-31 21:39         ` Drew Adams
2011-10-31 23:15 ` Juri Linkov
2011-11-01  9:39   ` Dani Moncayo [this message]
2011-11-01 10:21     ` Dani Moncayo
2011-11-01 23:07     ` Juri Linkov
2011-11-02  7:54       ` Dani Moncayo
2011-11-03  9:07         ` Juri Linkov
2011-11-03  9:44           ` Dani Moncayo
2011-11-03 19:24             ` Dani Moncayo
2011-11-03 19:56               ` Juri Linkov
2011-11-03 20:43                 ` Dani Moncayo
2011-11-03 21:11                   ` Juri Linkov
2011-12-01  7:45                     ` Juri Linkov
2011-11-19 21:04                 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH8Pv0gKqCsfh92KzYJ_OUd5tdbrnSjRCboqARS7EFTFRUCPcg@mail.gmail.com \
    --to=dmoncayo@gmail.com \
    --cc=9918@debbugs.gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).