From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Otness Newsgroups: gmane.emacs.bugs Subject: bug#25967: [PATCH] Add support for ImageMagick 7 (Bug#25967) Date: Tue, 28 Aug 2018 15:32:26 -0500 Message-ID: References: <6a48dc20-17fc-4e4b-b793-4c37c6bcbcc5@Spark> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1535488412 23408 195.159.176.226 (28 Aug 2018 20:33:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Aug 2018 20:33:32 +0000 (UTC) Cc: 25967@debbugs.gnu.org To: rgm@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 28 22:33:28 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fukg3-0005yv-O3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Aug 2018 22:33:27 +0200 Original-Received: from localhost ([::1]:39912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fukiA-0006qM-3V for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Aug 2018 16:35:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fukhg-0006Xo-N9 for bug-gnu-emacs@gnu.org; Tue, 28 Aug 2018 16:35:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fukfe-0007KA-C6 for bug-gnu-emacs@gnu.org; Tue, 28 Aug 2018 16:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59198) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fukfd-0007K0-Ta for bug-gnu-emacs@gnu.org; Tue, 28 Aug 2018 16:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fukfd-0001Zu-Qn for bug-gnu-emacs@gnu.org; Tue, 28 Aug 2018 16:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Karl Otness Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Aug 2018 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25967-submit@debbugs.gnu.org id=B25967.15354883696048 (code B ref 25967); Tue, 28 Aug 2018 20:33:01 +0000 Original-Received: (at 25967) by debbugs.gnu.org; 28 Aug 2018 20:32:49 +0000 Original-Received: from localhost ([127.0.0.1]:35983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fukfQ-0001ZT-Ev for submit@debbugs.gnu.org; Tue, 28 Aug 2018 16:32:48 -0400 Original-Received: from mail-it0-f65.google.com ([209.85.214.65]:55562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fukfO-0001ZD-7P for 25967@debbugs.gnu.org; Tue, 28 Aug 2018 16:32:46 -0400 Original-Received: by mail-it0-f65.google.com with SMTP id d10-v6so4551568itj.5 for <25967@debbugs.gnu.org>; Tue, 28 Aug 2018 13:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karlotness-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PpLbuSni9s9sqcg2NwOroRT7EY4WSNMKu1xyzNgquNw=; b=Ep7D6g5ZEf7S9jb1Pxg9kqRxWh90a0WSTRxCiBN0JW9kdZ7AIOIg1QmbuIamUXfJLt qwP/Ur2lDCOAPEsYBhxqbyDK0Tks/0emJRiLsyNxAD5E2kGbFhqhHE5PRdYlMt0wJwPu cIhQECJRNZyiRlxfiDrJpXzhYl+d8Am0ONl4QGFhakunk/hSWrrYnOK86YkbYsJ5dfTO WaRv6cg6667+GtGogjlhOqCvsxH29SxHdVYvy37d4qz+HUFRuVnd+qI3pt/g5uVJDvLv SgRpY5A909Wcsp9NzOF+TBfdQBTBIq0LR36MNZLdpLyD3pmQ9fwd/sPQQGER63epxFvX ADJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PpLbuSni9s9sqcg2NwOroRT7EY4WSNMKu1xyzNgquNw=; b=CYjDmNgHBxe4CiFgZqPDTGm7ZxvWRhDjbA3+/NLoktqalcJcrUw2gLFcG8e4fBEUWS CCLHSyIc1qPr2oSaG28qy3xA9bUKGXfzmAWQfA8nNqn8lcu6Kh04da5Kbw+5NRujbH94 dUoC4lxYF90PmWRXeoudiS3ZF/SoZcWl9T+oKLGaKeKSTN2jOBBWDqjpJEw2Wv0a21hX ffwbKPyNkjNl7Sukt0FShD/0EYatDso4NrKXpQjQW43+Bah4/Ml7VlRh2sjGrspn2Blo g8DDA1VzphwGMndtyHvbtTOXs5BYgcM0NmqiEeX6jFJKgVYMQEERRARrSNTjBsIWivTY 0SyQ== X-Gm-Message-State: APzg51ANyydpXgjYk5127eELoLktcdTpIi+qq1rb/pAYXVLDtTSmH+Md IOgxa2E6tVio0Eqe+za5I2gIhZtI4Ug= X-Google-Smtp-Source: ANB0VdYtdZsomBGPzkvsGbRPghDd6BiU69AAb8zvF+Ul4g3/YAMpTMO46TFUzOhTUZaBhio9jcZp/g== X-Received: by 2002:a02:6c45:: with SMTP id w66-v6mr2954360jab.87.1535488360254; Tue, 28 Aug 2018 13:32:40 -0700 (PDT) Original-Received: from mail-io0-f172.google.com (mail-io0-f172.google.com. [209.85.223.172]) by smtp.gmail.com with ESMTPSA id u68-v6sm1112468ita.36.2018.08.28.13.32.39 for <25967@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Aug 2018 13:32:39 -0700 (PDT) Original-Received: by mail-io0-f172.google.com with SMTP id 75-v6so2587265iou.11 for <25967@debbugs.gnu.org>; Tue, 28 Aug 2018 13:32:39 -0700 (PDT) X-Received: by 2002:a6b:90d4:: with SMTP id s203-v6mr2874726iod.249.1535488358875; Tue, 28 Aug 2018 13:32:38 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149808 Archived-At: I hate to say this, but it looks like the modified patch might not be linking up quite right. It seems like the issue has to do with the new "IMAGEMAGICK7" prefix for EMACS_CHECK_MODULES. Some of the downstream tests, specifically looking for MagickRelinquishMemory try to use the IMAGEMAGICK_CFLAGS which won't be defined if configure finds version 7. The test will then fail ImageMagick and it won't be linked. I don't remember exactly, but I think this may have been the reason why I had initially set it up to use the same HAVE_IMAGEMAGICK prefix for both pkg-config checks, and then manually added the IMAGEMAGICK_MAJOR definition to sort out which was actually found. Using separate test variables can probably work, but will require updating the AC_CHECK_FUNCS tests later on. When I put together the initial patch, I think I wanted to touch as little of configure as possible, so I left those alone. It may be simpler to go back to using the same IMAGEMAGICK prefix for both package checks, but I agree it is nicer to not re-use the same pkg-config variables. Thanks for helping get this checked in. Karl On Mon, Aug 27, 2018 at 9:10 PM Glenn Morris wrote: > > Karl Otness wrote: > > > I have attached a patch which adds support for ImageMagick version 7. > > Thanks very much! It looks much simpler than I was expecting. > > I applied it as 5729486, then tweaked it in bf1b147 (mainly to avoid > printing two identical "checking for imagemagick"); it would be good if you > check I did not break it. :) > > We normally like to get copyright assignments for Emacs; see eg > https://www.gnu.org/licenses/why-assign.en.html > > I think your patch is just small enought not to require this. > But if you would like to contribute more in future, or just would like > to, you can start the assignment process by filing out the form at > > http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future > > Thanks again!