From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.bugs Subject: bug#21898: scss-mode font-lock face for variables Date: Thu, 12 Nov 2015 22:37:57 -0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b41904bd224720524664cc4 X-Trace: ger.gmane.org 1447396759 9821 80.91.229.3 (13 Nov 2015 06:39:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2015 06:39:19 +0000 (UTC) To: 21898@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 13 07:39:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zx80q-0002JU-NQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Nov 2015 07:39:08 +0100 Original-Received: from localhost ([::1]:51269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx80p-0000uR-Un for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Nov 2015 01:39:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx80l-0000uL-8B for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:39:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx80k-0004rC-9W for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:39:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx80k-0004qi-6J for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zx80j-0006UO-Va for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jackson Hamilton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Nov 2015 06:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21898 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.144739670224898 (code B ref -1); Fri, 13 Nov 2015 06:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Nov 2015 06:38:22 +0000 Original-Received: from localhost ([127.0.0.1]:36501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zx806-0006TW-9H for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:22 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zx7zm-0006T2-C2 for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx7zk-0004BT-Sl for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:01 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx7zk-0004BK-PG for submit@debbugs.gnu.org; Fri, 13 Nov 2015 01:38:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx7zj-0000mn-Ql for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:38:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx7zi-0004A8-IP for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:37:59 -0500 Original-Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:35557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx7zi-00049h-CG for bug-gnu-emacs@gnu.org; Fri, 13 Nov 2015 01:37:58 -0500 Original-Received: by obbnk6 with SMTP id nk6so66643039obb.2 for ; Thu, 12 Nov 2015 22:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=plqQ7gyWh/AJOMHOedPzw0t9eI49up0SX7sNyH1K3Uw=; b=WvAiSzOQzjsT33XIB2o73a7B47O6OpBNbmFFPmoKGavp2+dpRaP8UvRE0UN+H7sVDA ZxNGe4p2PJJFN/teLCR8U1e20hMEo5e7p2V+tNXy8zQCcZInJ9RcNYSA/2f8YMLnxG/f AcErSXiVi17rHblZI+kqoCQ/vQKA0nlgv8ERjq3hXhGbQ9m9l7ghMybNEjK9g6bMcRTE BIC9Ii5kglQyf0wtG9SwzPHzo5Xaq4eHPHFHqMN+sqFfs5ezsMoOibS6cjnWNZdN2N+Y jpde2rfPnBv7IBnmJ2RsDddQ0VhGWgMvCTTEBA+saipZ3sP4UZ0ZeZ2mEa4dA1kHxTXK eRTQ== X-Received: by 10.60.165.72 with SMTP id yw8mr11679402oeb.45.1447396677639; Thu, 12 Nov 2015 22:37:57 -0800 (PST) Original-Received: by 10.76.55.4 with HTTP; Thu, 12 Nov 2015 22:37:57 -0800 (PST) X-Google-Sender-Auth: 1bxq_oGqvNF8E2Z3zmDlKQRf_o4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108706 Archived-At: --047d7b41904bd224720524664cc4 Content-Type: multipart/alternative; boundary=047d7b41904bd2246d0524664cc2 --047d7b41904bd2246d0524664cc2 Content-Type: text/plain; charset=UTF-8 I'd like to propose the following change to the scss-mode on master: Use font-lock-constant-face for SCSS variables. This may not seem intuitive from a naming perspective, but font-lock-variable-name-face is already used for CSS properties. That makes it harder to distinguish between properties and variables. AFAIK, Sass doesn't even have constants, so I don't see much harm in using this face. It'd be a less dramatic change for those who have grown used to variable coloring for CSS properties. I guess the alternative would be to inherit the property face from something else, to free up the face for real variables. But then what do we use for properties? (Inheriting from nothing doesn't look good IMO.) Attached is the proposed patch. --047d7b41904bd2246d0524664cc2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I'd like to propose the following change to the scss-m= ode on master: Use font-lock-constant-face for SCSS variables.

This may not seem intuitive from a naming perspective, but font-lock= -variable-name-face is already used for CSS properties. That makes it harde= r to distinguish between properties and variables.

AFAIK, Sass doesn't even have constants, so I don't see much harm = in using this face. It'd be a less dramatic change for those who have g= rown used to variable coloring for CSS properties.

I guess the alternative would be to inherit the property face from somethi= ng else, to free up the face for real variables. But then what do we use fo= r properties? (Inheriting from nothing doesn't look good IMO.)

Attached is the proposed patch.
--047d7b41904bd2246d0524664cc2-- --047d7b41904bd224720524664cc4 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Use-font-lock-constant-face-for-scss-variables.patch" Content-Disposition: attachment; filename="0001-Use-font-lock-constant-face-for-scss-variables.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igxakozw0 RnJvbSA3MmZiNDY3MDIyODMyNGI1OTUzMWExOTQwOTYxODI3N2I2MmFkMjMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNrc29uIFJheSBIYW1pbHRvbiA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgpEYXRlOiBUaHUsIDEyIE5vdiAyMDE1IDIyOjIxOjM4IC0wODAwClN1 YmplY3Q6IFtQQVRDSF0gVXNlIGBmb250LWxvY2stY29uc3RhbnQtZmFjZScgZm9yIHNjc3MgdmFy aWFibGVzCgoqIGNzcy1tb2RlLmVsIChzY3NzLWZvbnQtbG9jay1rZXl3b3Jkcyk6IENoYW5nZSBm YWNlLgotLS0KIGxpc3AvdGV4dG1vZGVzL2Nzcy1tb2RlLmVsIHwgMiArLQogMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXh0 bW9kZXMvY3NzLW1vZGUuZWwgYi9saXNwL3RleHRtb2Rlcy9jc3MtbW9kZS5lbAppbmRleCAzZTg0 YjQzLi5lMzVlNmNiIDEwMDY0NAotLS0gYS9saXNwL3RleHRtb2Rlcy9jc3MtbW9kZS5lbAorKysg Yi9saXNwL3RleHRtb2Rlcy9jc3MtbW9kZS5lbApAQCAtNTI1LDcgKzUyNSw3IEBAIHBzZXVkby1j bGFzc2VzLCBhbmQgYXQtcnVsZXMuIgogICAgIHN0KSkKIAogKGRlZnZhciBzY3NzLWZvbnQtbG9j ay1rZXl3b3JkcwotICAoYXBwZW5kIGAoKCwoY29uY2F0ICIkIiBjc3MtaWRlbnQtcmUpICgwIGZv bnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKSkKKyAgKGFwcGVuZCBgKCgsKGNvbmNhdCAiJCIg Y3NzLWlkZW50LXJlKSAoMCBmb250LWxvY2stY29uc3RhbnQtZmFjZSkpKQogICAgICAgICAgIChj c3MtLWZvbnQtbG9jay1rZXl3b3JkcyAnc2Fzc3kpCiAgICAgICAgICAgYCgoLChjb25jYXQgIkBt aXhpblsgXHRdK1xcKCIgY3NzLWlkZW50LXJlICJcXClbIFx0XSooIikKICAgICAgICAgICAgICAo MSBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKSkpKSkKLS0gCjIuNi4zCgo= --047d7b41904bd224720524664cc4--