From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Piotr Wasik Newsgroups: gmane.emacs.bugs Subject: bug#21808: 24.3; tramp sorting with regular expression crashes whole dir listing Date: Sun, 1 Nov 2015 15:49:12 +0000 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113c61802a892a05237c9ab5 X-Trace: ger.gmane.org 1446402263 26122 80.91.229.3 (1 Nov 2015 18:24:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Nov 2015 18:24:23 +0000 (UTC) To: 21808@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 01 19:24:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsxIZ-0000wS-Rv for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Nov 2015 19:24:12 +0100 Original-Received: from localhost ([::1]:38365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsxIZ-0006Vy-0S for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Nov 2015 13:24:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsxIU-0006VV-3a for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 13:24:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsxIS-0000Sw-TI for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 13:24:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsxIS-0000Sp-Qf for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 13:24:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZsxIS-0007a0-IR for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 13:24:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Piotr Wasik Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2015 18:24:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.144640222729069 (code B ref -1); Sun, 01 Nov 2015 18:24:04 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Nov 2015 18:23:47 +0000 Original-Received: from localhost ([127.0.0.1]:48053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZsxIB-0007Yg-1M for submit@debbugs.gnu.org; Sun, 01 Nov 2015 13:23:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41561) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zsusf-0002JG-Fe for submit@debbugs.gnu.org; Sun, 01 Nov 2015 10:49:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zsusd-0000FW-Pr for submit@debbugs.gnu.org; Sun, 01 Nov 2015 10:49:17 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsusd-0000FS-Mc for submit@debbugs.gnu.org; Sun, 01 Nov 2015 10:49:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsusc-0004Bw-Ig for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 10:49:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zsusb-0000Dx-MH for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 10:49:14 -0500 Original-Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:36721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsusb-0000Ds-Gm for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2015 10:49:13 -0500 Original-Received: by qkcl124 with SMTP id l124so46171793qkc.3 for ; Sun, 01 Nov 2015 07:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=CK/FVGttu+5DQRt4c5Zs4sYbPMu6LuYeiybGnrvSJUA=; b=sg8NlgAOOGc7MVf9b7gd2qpRWwLOdMheKxPE1XR7hExT/g4mDu1jpqQcAc9F4qrP/C 6O11DCHVQEgZDXQ24MGJ6GkOIvXknTJhxt89G0vEsKhtz75Clg/MMQJPGxF0mFm170ee DFvWYwa+x5ELJQvT/QCGTQkfPy0aLbMT5AlnTT3dfww2Z/f/QUI1QhiyDOuq8k+WIuL9 CObdsEkIHr6q40A/e5uWCADfBw63+jwTI3uoYH7fltE7eSUmFvFk3VmG3TgY2gVJqRMu lk9hjzP9JR7cwzdaKhKT6a2upY2tTWrbE6z3ioq/EnGt3jyTSR0ugQpjzcZTSCFAG2OP bx5g== X-Received: by 10.55.200.132 with SMTP id t4mr13883604qkl.78.1446392952947; Sun, 01 Nov 2015 07:49:12 -0800 (PST) Original-Received: by 10.55.133.70 with HTTP; Sun, 1 Nov 2015 07:49:12 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sun, 01 Nov 2015 13:23:44 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108276 Archived-At: --001a113c61802a892a05237c9ab5 Content-Type: text/plain; charset=UTF-8 hi, I try to set up tramp with adb to access nexus. Its root directory contains a protected file called factory and directory listing returns: "lstat '//factory' failed: Permission denied" as one of files. it crashes with the following backtrace ;; Debugger entered--Lisp error: (args-out-of-range "lstat '//factory' failed: Permission denied" 55 43) ;; tramp-adb-ls-output-name-less-p("lstat '//factory' failed: Permission denied" "lrwxrwxrwx root root 0 2015-11-01 13:49 etc -> /system/etc") ;; sort(("drwxr-xr-x root root 0 2015-11-01 13:49 acct" "drwxrwx--- system cache 0 2015-11-01 15:03 cache" "lrwxrwxrwx root root 0 1970-01-01 01:00 charger -> /sbin/healthd" "dr-x------ root root 0 2015-11-01 13:49 config" "lrwxrwxrwx root root 0 2015-11-01 13:49 d -> /sys/kernel/debug") tramp-adb-ls-output-name-less-p) ;; tramp-adb-sh-fix-ls-output() ;; tramp-adb-handle-directory-files-and-attributes("/adb::/") ;; eval((tramp-adb-handle-directory-files-and-attributes "/adb::/") nil) ;; eval-last-sexp-1(t) ;; eval-last-sexp(t) ;; eval-print-last-sexp() ;; call-interactively(eval-print-last-sexp nil nil) I suggest a fix: (defun tramp-adb-ls-output-name-less-p (a b) "Sort \"ls\" output by name, ascending." (let (posa posb matched-a matched-b) (setq matched-a (string-match dired-move-to-filename-regexp a)) (setq posa (match-end 0)) (setq matched-b (string-match dired-move-to-filename-regexp b)) (setq posb (match-end 0)) (string-lessp (substring a (if matched-a a 0)) (substring b (if matched-b b 0))))) I added matched-a and matched-b variables so even if directory listing returns something unexpected, sorting completes normally. Cheers, Piotr --001a113c61802a892a05237c9ab5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
hi,

I try to set up tramp with adb to a= ccess nexus. Its root directory contains a protected file called factory an= d directory listing returns:=C2=A0"lstat '//factory' failed: P= ermission denied" as one of files.

it crashes= with the following backtrace
;; Debugger entered--Lisp erro= r: (args-out-of-range "lstat '//factory' failed: Permission de= nied" 55 43)
;; =C2=A0 tramp-adb-ls-output-name-less-p("= ;lstat '//factory' failed: Permission denied" "lrwxrwxrwx= root =C2=A0 =C2=A0 root =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00 2015-11= -01 13:49 etc -> /system/etc")
;; =C2=A0 sort(("drwx= r-xr-x root =C2=A0 =C2=A0 root =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00 2= 015-11-01 13:49 acct" "drwxrwx--- system =C2=A0 cache =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 0 2015-11-01 15:03 cache" "lrwxrwxrwx ro= ot =C2=A0 =C2=A0 root =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00 1970-01-01= 01:00 charger -> /sbin/healthd" "dr-x------ root =C2=A0 =C2= =A0 root =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00 2015-11-01 13:49 config= " "lrwxrwxrwx root =C2=A0 =C2=A0 root =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A00 2015-11-01 13:49 d -> /sys/kernel/debug") tramp-adb= -ls-output-name-less-p)
;; =C2=A0 tramp-adb-sh-fix-ls-output()
;; =C2=A0 tramp-adb-handle-directory-files-and-attributes("/ad= b::/")
;; =C2=A0 eval((tramp-adb-handle-directory-files-and-= attributes "/adb::/") nil)
;; =C2=A0 eval-last-sexp-1(t= )
;; =C2=A0 eval-last-sexp(t)
;; =C2=A0 eval-print-last= -sexp()
;; =C2=A0 call-interactively(eval-print-last-sexp nil nil= )

I suggest a fix:

=
(defun tramp-adb-ls-output-name-less-p (a b)
=C2=A0 "So= rt \"ls\" output by name, ascending."
=C2=A0 (let = (posa posb matched-a matched-b)
=C2=A0 =C2=A0 (setq matched-a (st= ring-match dired-move-to-filename-regexp a))
=C2=A0 =C2=A0 (setq = posa (match-end 0))
=C2=A0 =C2=A0 (setq matched-b (string-match d= ired-move-to-filename-regexp b))
=C2=A0 =C2=A0 (setq posb (match-= end 0))
=C2=A0 =C2=A0 (string-lessp (substring a (if matched-a a = 0)) (substring b (if matched-b b 0)))))

I ad= ded matched-a and matched-b variables so even if directory listing returns = something unexpected, sorting completes normally.

= Cheers,
Piotr

--001a113c61802a892a05237c9ab5--